0057722: OTF Coupon can be created and applied with a negative or zero 'Number of Uses Limit' value

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0057722

POS2

POS

public

2024-12-20 17:13

2025-01-27 11:20

Reporter

Daria_Sh

Assigned To

ranjith_qualiantech_com

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

24Q4.2

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0057722: OTF Coupon can be created and applied with a negative or zero 'Number of Uses Limit' value

Description

When a zero or negative value is entered as the 'Number of Uses Limit' in the OTF Rule in the Backoffice, the rule is saved, and the OTF Coupon can still be generated and applied in the POS.

Pre - configurations:
1. Go to 'Discounts and Promotions' window
2. Open 'Test Coupon' discount
3. Tick 'Uses coupon codes' and 'Is OTF Coupon' flags
4. Ensure discount is active
5. Go to 'OTF Coupons Generation Rules' window
6. Create new Rule → Fulfill the following fields:
- Applicant, Search Key, Description and Starting Date
- Active: ✔
- Issuance Time: At Paid Time
- Promotion/Discount: Test Coupon
- Number of Uses: N Uses
- Number of Uses Limit: 0|-1
7. Proceed to 'Print' tab → Fulfill the required fields
8. Launch the HW manager

Steps To Reproduce

1. Login to POS (livebuilds:vallblanca/openbravo)
2. Add product to the Order
3. Complete the Order (Click 'Pay', select 'Cash' and click 'Done')
4. Select 'Print' delivery option
5. Verify the printed Coupon in the HW manager
Actual Result: The Coupon is printed and saved in the BO (Discount Coupon window) with 'Number of Uses Limit' equal to 0 or -1

6. Add product to the Order
7. Scan or redeem Coupon Code
Actual Result: The coupon is applied

Proposed Solution

The validation should be set for this field preventing to save OTF rule with zero or negative value in 'Number of Uses Limit' field

Additional Information