0057671: Problem with “Maximum discount per role” functionality, does not work correctly.

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0057671

POS2

POS

public

2025-01-17 06:33

2025-02-06 14:44

Reporter

axelmercado

Assigned To

prakashmurugesan88

Priority

high

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

25Q2

Merge Request Status

Review Assigned To

OBNetwork customer

OBPS

Support ticket

110411

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0057671: Problem with “Maximum discount per role” functionality, does not work correctly.

Description

We apply the changes but there is an error in the way decimals and rounding are handled, resulting in inconsistencies when validating the maximum discounts allowed. This allows the system to accept final prices that are below the calculated limits for both the Unit Price and the List Price.

Steps To Reproduce

Navigate to role and configure the detailed actions and the maximum discount as below.
In the terminal, add a product and to the line, add a manual discount as below.
You can notice following Rounding issue.

Initial Context:

Product with List Price: 5.90€.
Product with Unit Price (price already reduced): 4.90€.
Observed Behavior:

The system warns that the maximum discount allowed is 16%, based on the Unit Price.

Calculated discount: 4.90€ × 0.16 = 0.784€ ≈ 0.78€ (rounding).
Expected minimum allowed price: €4.90 - €0.78 = €4.12.
However, the POS allows to apply a price of €4.11, which is below the expected limit of €4.12.

Extended Case:

If the original List Price of €5.90 is considered, a maximum discount of 30% would imply:

Minimum price allowed: €5.90 × 0.70 = €4.13.
But the system allows applying a discount that results in a final price of 4.11€, equivalent to a discount of 30.33%, exceeding the established limit.

Proposed Solution

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0056718		closed	prakashmurugesan88	Problem with “Maximum discount per role” functionality, does not work correctly.
depends on	backport	0057672	25Q1	closed	prakashmurugesan88	Problem with “Maximum discount per role” functionality, does not work correctly.