Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057671POS2POSpublic2025-01-17 06:332025-01-17 21:52
Reporteraxelmercado 
Assigned Toprakashmurugesan88 
PriorityhighSeveritymajorReproducibilityalways
StatusscheduledResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057671: Problem with “Maximum discount per role” functionality, does not work correctly.
DescriptionWe apply the changes but there is an error in the way decimals and rounding are handled, resulting in inconsistencies when validating the maximum discounts allowed. This allows the system to accept final prices that are below the calculated limits for both the Unit Price and the List Price.
Steps To ReproduceNavigate to role and configure the detailed actions and the maximum discount as below.
In the terminal, add a product and to the line, add a manual discount as below.
You can notice following Rounding issue.


Initial Context:

Product with List Price: 5.90€.
Product with Unit Price (price already reduced): 4.90€.
Observed Behavior:

The system warns that the maximum discount allowed is 16%, based on the Unit Price.

Calculated discount: 4.90€ × 0.16 = 0.784€ ≈ 0.78€ (rounding).
Expected minimum allowed price: €4.90 - €0.78 = €4.12.
However, the POS allows to apply a price of €4.11, which is below the expected limit of €4.12.

Extended Case:

If the original List Price of €5.90 is considered, a maximum discount of 30% would imply:

Minimum price allowed: €5.90 × 0.70 = €4.13.
But the system allows applying a discount that results in a final price of 4.11€, equivalent to a discount of 30.33%, exceeding the established limit.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0056718 closed prakashmurugesan88 Problem with “Maximum discount per role” functionality, does not work correctly. 
depends on backport 005767225Q1 scheduled prakashmurugesan88 Problem with “Maximum discount per role” functionality, does not work correctly. 
Not all the children of this issue are yet resolved or closed.
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2025-01-17 06:33prakashmurugesan88New Issue
2025-01-17 06:33prakashmurugesan88Assigned To => prakashmurugesan88
2025-01-17 06:33prakashmurugesan88Triggers an Emergency Pack => No
2025-01-17 06:34prakashmurugesan88Relationship addedrelated to 0056718
2025-01-17 06:36prakashmurugesan88Issue cloned0057672
2025-01-17 06:40prakashmurugesan88Relationship addeddepends on 0057672
2025-01-17 06:40prakashmurugesan88Statusnew => scheduled
2025-01-17 06:58prakashmurugesan88Note Added: 0174253
2025-01-17 07:55prakashmurugesan88Note Edited: 0174253bug_revision_view_page.php?bugnote_id=0174253#r29064
2025-01-17 21:52axelmercadoReporterprakashmurugesan88 => axelmercado

Notes
(0174253)
prakashmurugesan88   
2025-01-17 06:58   
(edited on: 2025-01-17 07:55)
Created following Merge Request
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3359 [^]