Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057650Retail ModulesDiscounts and Promotionspublic2025-01-15 13:312025-02-07 11:33
Reportersofidossant 
Assigned ToBimla_vm 
PrioritynormalSeverityminorReproducibilityunable to reproduce
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket118354
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057650: [COUPONS] - N applications per customer coupons cannot be used with an external bp
DescriptionWith the change https://issues.openbravo.com/view.php?id=54402 [^] if we use an external business partner, we can not use it, because in some cases the external is not created in openbravo, but it is external, and in the bp we have the anonymous customer.
Steps To ReproduceWe have not been able to reproduce it in livebuilds, since we do not have bp that are not created in openbravo but in the external one.

Create discount with gift product, and coupons (configured N uses per customer coupons, and without crm reference or bp)
1- Open webpos.
2- Add an external bp (not in openbravo).
3- Add products and the gift product.
4 - Try to add the coupon for the discount.
You have the problem
Proposed Solution      if (isAnon && null == crmReference) {
        criteria.add(Restrictions.ne(Coupon.PROPERTY_NUMBEROFUSES, "NC"));
      }
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0057912RR25Q1 closed Bimla_vm [COUPONS] - N applications per customer coupons cannot be used with an external bp 
depends on backport 0057913RR24Q4.1 closed Bimla_vm [COUPONS] - N applications per customer coupons cannot be used with an external bp 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2025-01-15 13:31sofidossantNew Issue
2025-01-15 13:31sofidossantAssigned To => Retail
2025-01-15 13:31sofidossantOBNetwork customer => Gold
2025-01-15 13:31sofidossantSupport ticket => 118354
2025-01-15 13:31sofidossantTriggers an Emergency Pack => No
2025-01-17 09:02guilleaerDescription Updatedbug_revision_view_page.php?rev_id=29066#r29066
2025-01-18 10:08Bimla_vmAssigned ToRetail => Bimla_vm
2025-01-18 10:08Bimla_vmStatusnew => scheduled
2025-01-21 15:40hgbotMerge Request Status => open
2025-01-21 15:40hgbotNote Added: 0174474
2025-02-06 20:42hgbotMerge Request Statusopen => approved
2025-02-06 20:42hgbotResolutionopen => fixed
2025-02-06 20:42hgbotStatusscheduled => closed
2025-02-06 20:42hgbotNote Added: 0175239
2025-02-06 20:42hgbotNote Added: 0175240
2025-02-07 11:31Bimla_vmStatusclosed => new
2025-02-07 11:31Bimla_vmResolutionfixed => open
2025-02-07 11:32Bimla_vmStatusnew => scheduled
2025-02-07 11:32Bimla_vmStatusscheduled => resolved
2025-02-07 11:32Bimla_vmResolutionopen => fixed
2025-02-07 11:33Bimla_vmStatusresolved => closed

Notes
(0174474)
hgbot   
2025-01-21 15:40   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/78 [^]
(0175239)
hgbot   
2025-02-06 20:42   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons [^]
Changeset: 6c4752ff53ced4cf16de964d38474af6c3e177b2
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 29-01-2025 18:16:52
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/commit/6c4752ff53ced4cf16de964d38474af6c3e177b2 [^]

Fixed ISSUE-57650: Allow external bp to use N uses per customer coupon

---
M src/org/openbravo/retail/discounts/coupons/DISCPUtils.java
---
(0175240)
hgbot   
2025-02-06 20:42   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.retail.discounts.coupons/-/merge_requests/78 [^]