0057631: InitCashup action should not load a cashup from backoffice if the existing cashup in the state is newer

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0057631

Retail Modules

Cash up

public

2025-01-13 16:47

2025-01-15 13:41

Reporter

aaroncalero

Assigned To

migueldejuana

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR25Q2

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0057631: InitCashup action should not load a cashup from backoffice if the existing cashup in the state is newer

Description

When a cashup is completed in POS, a new cashup is added to the state and the closed cashup is sent to backoffice for processing. However, the closed cashup is not marked as "processed" until its import entry is processed.

If the POS performs a login before that import entry is processed, the Global.initCashup action (in one of its actionPreparations[*]) calls the backoffice and retrieves the last non-processed cashup.

In this situation, the POS finishes the login process with a cashup that is going to be processed in the server as soon as the import entry is triggered. After performing any action involving that cashup (the Open Till process, a ticket, etc), if the import entry has finished processing, an Error While Importing record will be generated for the related document.

[*] https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js#L215 [^]

Steps To Reproduce

In a development environment, set a breakpoint inside the saveRecord method of ProcessCashClose.java.

Log in POS or POS2.
Check the Cashup id in the state: OB.App.State.getState().Cashup.id
Navigate to the cashup window and complete the process. The POS will automatically log out. At the same time, the server code will be stopped on the breakpoint; leave the code paused for now.
Check the cashup id again. Verify that the id is new.
In POS, log in again.
Check the cashup id for the third time. Note that the id is the first id again.
Let the server code continue and process the cashup.
Try to complete a ticket. Verify that a record has been created in the Errors While Importing POS Data window

Proposed Solution

The code that was added as part of previous mitigations should not try to reload the non-processed cashup from backoffice if it is detected that the creationDate of the backoffice cashup is older that the current new cashup in the state.

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0056263		closed	ranjith_qualiantech_com	Mitigation https://issues.openbravo.com/view.php?id=52070 [^] should not create a new cashup in POS
depends on	backport	0057632	RR25Q1	closed	migueldejuana	InitCashup action should not load a cashup from backoffice if the existing cashup in the state is newer
depends on	backport	0057633	RR24Q4.1	closed	migueldejuana	InitCashup action should not load a cashup from backoffice if the existing cashup in the state is newer