Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057562POS2POSpublic2025-01-03 09:512025-02-10 04:59
Reporterjfvaringot 
Assigned Toinaki_luque 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057562: POS 2 - Ticket is not closed and printed when closing the drawer
DescriptionTEST DONE ON MY DEV ENVIRONMENT (=MASTER, WITH OUR OWN DATA)

When my ticket is fully paid, using cash, the ticket view is not closed and the receipt is not printed when I manually close my drawer
Steps To ReproduceOn back-office, for payment method cash, at Touchpoint type level:
- Setting : Drawer Opening Behavior : set to 'Open Draxer after Adding the payment, before closing order'
- Setting : 'Print Receipt At Drawer Closure' set to TRUE

On POS :
- When I do a sale, and select payment method 'Cash', the drawer opens.
-I complete the payment
- I close the drawer manually

-> The ticket view should close, and the receipt should be printed.
Proposed SolutionWhen I close the drawer, the ticket should be printed and the ticket closed.
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005762825Q1 closed inaki_luque POS 2 - Ticket is not closed and printed when closing the drawer 
Attached Filesdiff draft-tip-whatToFix-57562.diff (1,206) 2025-01-07 16:26
https://issues.openbravo.com/file_download.php?file_id=20714&type=bug
Issue History
Date ModifiedUsernameFieldChange
2025-01-03 09:51jfvaringotNew Issue
2025-01-03 09:51jfvaringotAssigned To => Retail
2025-01-03 09:51jfvaringotTriggers an Emergency Pack => No
2025-01-03 14:21fofarrilAssigned ToRetail => fofarril
2025-01-03 14:21fofarrilStatusnew => acknowledged
2025-01-07 10:55jfvaringotNote Added: 0173862
2025-01-07 10:58jfvaringotNote Edited: 0173862bug_revision_view_page.php?bugnote_id=0173862#r28998
2025-01-07 11:16gorka_gilOBNetwork customer => No
2025-01-07 11:16gorka_gilNote Added: 0173864
2025-01-07 11:16gorka_gilTypedefect => feature request
2025-01-07 15:46jfvaringotNote Added: 0173871
2025-01-07 16:02gorka_gilTypefeature request => defect
2025-01-07 16:25gorka_gilNote Added: 0173874
2025-01-07 16:26gorka_gilFile Added: draft-tip-whatToFix-57562.diff
2025-01-07 16:28gorka_gilNote Edited: 0173874bug_revision_view_page.php?bugnote_id=0173874#r29002
2025-01-13 14:50fofarrilStatusacknowledged => scheduled
2025-01-13 21:53hgbotMerge Request Status => open
2025-01-13 21:53hgbotNote Added: 0174087
2025-01-23 14:50jorgewederagoAssigned Tofofarril => inaki_luque
2025-02-07 06:38hgbotMerge Request Statusopen => approved
2025-02-10 04:59hgbotResolutionopen => fixed
2025-02-10 04:59hgbotStatusscheduled => closed
2025-02-10 04:59hgbotNote Added: 0175347
2025-02-10 04:59hgbotFixed in Version => 25Q2
2025-02-10 04:59hgbotNote Added: 0175348

Notes
(0173862)
jfvaringot   
2025-01-07 10:55   
(edited on: 2025-01-07 10:58)
EDIT :
When the drawer is closed, the ticket view should be closed, and according to the parameter on back-office :
- the 'Document Delivery Methods' should be displayed (if set to TRUE in the Touchpoint point)
- if not set to TRUE, the ticket should be automatically printed

as described in https://openbravo.atlassian.net/browse/RM-16485 [^]
(0173864)
gorka_gil   
2025-01-07 11:16   
This is not implemented in pos2, so it is not a defect but a feature request.

Before resolve this issue, the developer in charge to fix it, needs to talk with PrM to review and plan for an sprint.
(0173871)
jfvaringot   
2025-01-07 15:46   
So, https://openbravo.atlassian.net/browse/RM-16485, [^] cannot be in 'Done' status, as it was the main point of the RM.
(0173874)
gorka_gil   
2025-01-07 16:25   
(edited on: 2025-01-07 16:28)
True, sorry for the confusion, the development was already done for pos2 in:
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3036 [^]

and maybe it was broken by this project: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3212 [^]

I have take a quick look and I have attached a tip of what to check for solve it, just a tip of what to check for fix it, not a solution.
(0174087)
hgbot   
2025-01-13 21:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3348 [^]
(0175347)
hgbot   
2025-02-10 04:59   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3348 [^]
(0175348)
hgbot   
2025-02-10 04:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f206c7c68740f9600a80896a6fbb5108ef2494f2
Author: Francisco Javier Deler O'Farril <francisco.ofarril@doceleguas.com>
Date: 10-02-2025 03:59:33
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/pmods/org.openbravo.pos2/-/commit/f206c7c68740f9600a80896a6fbb5108ef2494f2 [^]

Fixes ISSUE-57562: Ticket is not closed and printed when closing the drawer.

---
M web-jspack/org.openbravo.pos2/src/components/Drawer/DrawerStatus.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddPayment.js
---