Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057540POS2Corepublic2024-12-27 14:582025-01-20 15:39
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version24Q4.1Fixed in Version24Q4.1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057540: Sometimes it is possible to double click a button, execute an action twice in parallel
DescriptionWhen a button associated with a user action is clicked, a scrim is rendered in the screen while the action is executed, to prevent executing an action twice in parallel.

Sometimes this mechanism does not work, and the user is able to click on a button twice before the scrim is rendered.

An additional mechanism should be added to prevent the double execution of actions when the scrim is not render in time
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0057538 closed AugustoMauch Sometimes it is possible to double click a button, execute an action twice in parallel 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-12-30 10:31AugustoMauchTypedefect => backport
2024-12-30 10:31AugustoMauchTarget Version => 24Q4.1
2025-01-20 13:09hgbotNote Added: 0174400
2025-01-20 13:10hgbotNote Added: 0174401
2025-01-20 13:58hgbotNote Added: 0174407
2025-01-20 13:58hgbotNote Added: 0174408
2025-01-20 15:39hgbotNote Added: 0174413
2025-01-20 15:39hgbotNote Added: 0174414
2025-01-20 15:39hgbotNote Added: 0174415
2025-01-20 15:39hgbotResolutionopen => fixed
2025-01-20 15:39hgbotStatusscheduled => closed
2025-01-20 15:39hgbotFixed in Version => 24Q4.1
2025-01-20 15:39hgbotNote Added: 0174416
2025-01-20 15:39hgbotNote Added: 0174417
2025-01-20 15:39hgbotNote Added: 0174418
2025-01-20 15:39hgbotNote Added: 0174419
2025-01-20 15:39hgbotNote Added: 0174420

Notes
(0174400)
hgbot   
2025-01-20 13:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1726 [^]
(0174401)
hgbot   
2025-01-20 13:10   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3383 [^]
(0174407)
hgbot   
2025-01-20 13:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/21 [^]
(0174408)
hgbot   
2025-01-20 13:58   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/417 [^]
(0174413)
hgbot   
2025-01-20 15:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1726 [^]
(0174414)
hgbot   
2025-01-20 15:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2a4ee301630ceeb9800c04e7b620883ff0bac309
Author: Augusto Mauch <amauch@orisha.com>
Date: 20-01-2025 15:38:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2a4ee301630ceeb9800c04e7b620883ff0bac309 [^]

Related to ISSUE-57540: Includes button id when executing action, updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierButton/__test__/ProductModifierButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Service/ServiceTicketLineButton/__test__/ServiceTicketLineButton.test.jsx
---
(0174415)
hgbot   
2025-01-20 15:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3383 [^]
(0174416)
hgbot   
2025-01-20 15:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: c3c330a95c39b794c80f0777534428dee15ca95d
Author: Augusto Mauch <a.mauch@orisha.com>
Date: 20-01-2025 15:37:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c3c330a95c39b794c80f0777534428dee15ca95d [^]

Fixes ISSUE-57540: Adds an id to BaseButton, prevents two concurrent user actions of button

It prevents two concurrent user actions for the same button.

---
M web-jspack/org.openbravo.core2/src/components/BaseButton/BaseButton.jsx
M web-jspack/org.openbravo.core2/src/components/BaseDialog/__test__/BaseDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/BaseKeypad/BaseKeypad.jsx
M web-jspack/org.openbravo.core2/src/components/BasePopover/__test__/BasePopover.test.jsx
M web-jspack/org.openbravo.core2/src/components/CompanyLogo/CompanyLogo.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/__test__/UserActionScrim.test.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/stories/UserActionScrim.stories.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/UserActionEvents.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UseUserActionInProgress.test.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
M web-jspack/org.openbravo.core2/src/core/user-action/getUserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/useUserActionInProgress.js
M web-jspack/org.openbravo.core2/src/hooks/useLockableStackOrder/__test__/useLockableStackOrder.test.jsx
M web-jspack/org.openbravo.core2/src/model/user-interface/__test__/UserActionInProgressStack.test.js
M web-jspack/org.openbravo.core2/src/model/user-interface/actions/UserActionInProgressStack.js
---
(0174417)
hgbot   
2025-01-20 15:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary [^]
Changeset: 0c1fe34fc5f3d192dbfd47e9e8035dec6252a1e6
Author: Augusto Mauch <amauch@orisha.com>
Date: 20-01-2025 15:39:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/commit/0c1fe34fc5f3d192dbfd47e9e8035dec6252a1e6 [^]

Related to ISSUE-57540: Updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.retail.complementary/src/components/ComplementaryTicketLineButton/__test__/ComplementaryTicketLineButton.test.jsx
---
(0174418)
hgbot   
2025-01-20 15:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/21 [^]
(0174419)
hgbot   
2025-01-20 15:39   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: d2ab024bf04a595deeadd06112422c8fd3edc288
Author: Augusto Mauch <amauch@orisha.com>
Date: 20-01-2025 15:38:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/d2ab024bf04a595deeadd06112422c8fd3edc288 [^]

Related to ISSUE-57540: Updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/__test__/GiftCardPaymentProvider.test.js
---
(0174420)
hgbot   
2025-01-20 15:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/417 [^]