Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057539POS2Corepublic2024-12-27 14:582025-01-23 18:07
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version25Q1Fixed in Version25Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057539: Sometimes it is possible to double click a button, execute an action twice in parallel
DescriptionWhen a button associated with a user action is clicked, a scrim is rendered in the screen while the action is executed, to prevent executing an action twice in parallel.

Sometimes this mechanism does not work, and the user is able to click on a button twice before the scrim is rendered.

An additional mechanism should be added to prevent the double execution of actions when the scrim is not render in time
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0057538 closed AugustoMauch Sometimes it is possible to double click a button, execute an action twice in parallel 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-12-30 10:31AugustoMauchTypedefect => backport
2024-12-30 10:31AugustoMauchTarget Version => 25Q1
2025-01-23 17:57hgbotNote Added: 0174619
2025-01-23 17:59hgbotNote Added: 0174620
2025-01-23 18:00hgbotNote Added: 0174621
2025-01-23 18:01hgbotNote Added: 0174622
2025-01-23 18:07hgbotNote Added: 0174623
2025-01-23 18:07hgbotNote Added: 0174624
2025-01-23 18:07hgbotResolutionopen => fixed
2025-01-23 18:07hgbotStatusscheduled => closed
2025-01-23 18:07hgbotNote Added: 0174625
2025-01-23 18:07hgbotFixed in Version => 25Q1
2025-01-23 18:07hgbotNote Added: 0174626
2025-01-23 18:07hgbotNote Added: 0174627
2025-01-23 18:07hgbotNote Added: 0174628
2025-01-23 18:07hgbotNote Added: 0174629
2025-01-23 18:07hgbotNote Added: 0174630

Notes
(0174619)
hgbot   
2025-01-23 17:57   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1732 [^]
(0174620)
hgbot   
2025-01-23 17:59   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3407 [^]
(0174621)
hgbot   
2025-01-23 18:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/22 [^]
(0174622)
hgbot   
2025-01-23 18:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/418 [^]
(0174623)
hgbot   
2025-01-23 18:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1732 [^]
(0174624)
hgbot   
2025-01-23 18:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3407 [^]
(0174625)
hgbot   
2025-01-23 18:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 428bd59f8495470a42a29ea8bfa042612c50fe16
Author: Augusto Mauch <amauch@orisha.com>
Date: 23-01-2025 17:58:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/428bd59f8495470a42a29ea8bfa042612c50fe16 [^]

Related to ISSUE-57539: Includes button id when executing action, updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierButton/__test__/ProductModifierButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Service/ServiceTicketLineButton/__test__/ServiceTicketLineButton.test.jsx
---
(0174626)
hgbot   
2025-01-23 18:07   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: c41779298320c7a4c2331a8900019860416e5af2
Author: Augusto Mauch <a.mauch@orisha.com>
Date: 23-01-2025 17:57:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c41779298320c7a4c2331a8900019860416e5af2 [^]

Fixes ISSUE-57539: Adds an id to BaseButton, prevents two concurrent user actions of button

It prevents two concurrent user actions for the same button.

---
M web-jspack/org.openbravo.core2/src/components/BaseButton/BaseButton.jsx
M web-jspack/org.openbravo.core2/src/components/BaseDialog/__test__/BaseDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/BaseKeypad/BaseKeypad.jsx
M web-jspack/org.openbravo.core2/src/components/BasePopover/__test__/BasePopover.test.jsx
M web-jspack/org.openbravo.core2/src/components/CompanyLogo/CompanyLogo.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/__test__/UserActionScrim.test.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/stories/UserActionScrim.stories.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/UserActionEvents.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UseUserActionInProgress.test.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
M web-jspack/org.openbravo.core2/src/core/user-action/getUserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/useUserActionInProgress.js
M web-jspack/org.openbravo.core2/src/hooks/useLockableStackOrder/__test__/useLockableStackOrder.test.jsx
M web-jspack/org.openbravo.core2/src/model/user-interface/__test__/UserActionInProgressStack.test.js
M web-jspack/org.openbravo.core2/src/model/user-interface/actions/UserActionInProgressStack.js
---
(0174627)
hgbot   
2025-01-23 18:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary [^]
Changeset: fa483f760f4385e5f861a20ed737e9f22e2bdbf3
Author: Augusto Mauch <amauch@orisha.com>
Date: 23-01-2025 17:59:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/commit/fa483f760f4385e5f861a20ed737e9f22e2bdbf3 [^]

Related to ISSUE-57539: Updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.retail.complementary/src/components/ComplementaryTicketLineButton/__test__/ComplementaryTicketLineButton.test.jsx
---
(0174628)
hgbot   
2025-01-23 18:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/418 [^]
(0174629)
hgbot   
2025-01-23 18:07   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/22 [^]
(0174630)
hgbot   
2025-01-23 18:07   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 93c7793cb9b25d0cfafb57514f8bb9a417040c44
Author: Augusto Mauch <amauch@orisha.com>
Date: 23-01-2025 18:01:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/93c7793cb9b25d0cfafb57514f8bb9a417040c44 [^]

Related to ISSUE-57539: Updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/__test__/GiftCardPaymentProvider.test.js
---