Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057538POS2Corepublic2024-12-27 14:582025-01-15 17:48
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057538: Sometimes it is possible to double click a button, execute an action twice in parallel
DescriptionWhen a button associated with a user action is clicked, a scrim is rendered in the screen while the action is executed, to prevent executing an action twice in parallel.

Sometimes this mechanism does not work, and the user is able to click on a button twice before the scrim is rendered.

An additional mechanism should be added to prevent the double execution of actions when the scrim is not render in time
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005753925Q1 closed AugustoMauch Sometimes it is possible to double click a button, execute an action twice in parallel 
depends on backport 005754024Q4.1 closed AugustoMauch Sometimes it is possible to double click a button, execute an action twice in parallel 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-12-27 14:58AugustoMauchNew Issue
2024-12-27 14:58AugustoMauchAssigned To => Triage Platform Base
2024-12-27 14:58AugustoMauchTriggers an Emergency Pack => No
2024-12-29 20:21hgbotNote Added: 0173721
2024-12-30 10:31AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2024-12-30 10:31AugustoMauchStatusnew => scheduled
2024-12-30 17:48hgbotNote Added: 0173741
2025-01-15 12:37hgbotNote Added: 0174189
2025-01-15 17:37hgbotNote Added: 0174199
2025-01-15 17:48hgbotNote Added: 0174200
2025-01-15 17:48hgbotNote Added: 0174201
2025-01-15 17:48hgbotResolutionopen => fixed
2025-01-15 17:48hgbotStatusscheduled => closed
2025-01-15 17:48hgbotFixed in Version => 25Q2
2025-01-15 17:48hgbotNote Added: 0174202
2025-01-15 17:48hgbotNote Added: 0174203
2025-01-15 17:48hgbotNote Added: 0174204
2025-01-15 17:48hgbotNote Added: 0174205
2025-01-15 17:48hgbotNote Added: 0174206
2025-01-15 17:48hgbotNote Added: 0174207

Notes
(0173721)
hgbot   
2024-12-29 20:21   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1706 [^]
(0173741)
hgbot   
2024-12-30 17:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3297 [^]
(0174189)
hgbot   
2025-01-15 12:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/413 [^]
(0174199)
hgbot   
2025-01-15 17:37   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/20 [^]
(0174200)
hgbot   
2025-01-15 17:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1706 [^]
(0174201)
hgbot   
2025-01-15 17:48   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary [^]
Changeset: f16e7c3d8152f85fe1a1808723b5be103032fb6c
Author: Augusto Mauch <amauch@orisha.com>
Date: 15-01-2025 17:36:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/commit/f16e7c3d8152f85fe1a1808723b5be103032fb6c [^]

Related to ISSUE-57538: Updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.retail.complementary/src/components/ComplementaryTicketLineButton/__test__/ComplementaryTicketLineButton.test.jsx
---
(0174202)
hgbot   
2025-01-15 17:48   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: bd9a157aace1ccb6ebbc1db3b8f95018cc825b5e
Author: Augusto Mauch <a.mauch@orisha.com>
Date: 15-01-2025 16:48:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/bd9a157aace1ccb6ebbc1db3b8f95018cc825b5e [^]

Fixes ISSUE-57538: Adds an id to BaseButton, prevents two concurrent user actions of button

It prevents two concurrent user actions for the same button.

---
M web-jspack/org.openbravo.core2/src/components/BaseButton/BaseButton.jsx
M web-jspack/org.openbravo.core2/src/components/BaseDialog/__test__/BaseDialog.test.jsx
M web-jspack/org.openbravo.core2/src/components/BaseKeypad/BaseKeypad.jsx
M web-jspack/org.openbravo.core2/src/components/BasePopover/__test__/BasePopover.test.jsx
M web-jspack/org.openbravo.core2/src/components/CompanyLogo/CompanyLogo.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/__test__/UserActionScrim.test.jsx
M web-jspack/org.openbravo.core2/src/components/Scrim/UserActionScrim/stories/UserActionScrim.stories.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/UserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/UserActionEvents.js
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UseUserActionInProgress.test.jsx
M web-jspack/org.openbravo.core2/src/core/user-action/__test__/UserAction.test.js
M web-jspack/org.openbravo.core2/src/core/user-action/getUserAction.js
M web-jspack/org.openbravo.core2/src/core/user-action/useUserActionInProgress.js
M web-jspack/org.openbravo.core2/src/hooks/useLockableStackOrder/__test__/useLockableStackOrder.test.jsx
M web-jspack/org.openbravo.core2/src/model/user-interface/__test__/UserActionInProgressStack.test.js
M web-jspack/org.openbravo.core2/src/model/user-interface/actions/UserActionInProgressStack.js
---
(0174203)
hgbot   
2025-01-15 17:48   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 2d8f8890f7857abd29729fa9a1424748a160c213
Author: Augusto Mauch <amauch@orisha.com>
Date: 15-01-2025 12:37:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/2d8f8890f7857abd29729fa9a1424748a160c213 [^]

Related to ISSUE-57538: Updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/__test__/GiftCardPaymentProvider.test.js
---
(0174204)
hgbot   
2025-01-15 17:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.complementary/-/merge_requests/20 [^]
(0174205)
hgbot   
2025-01-15 17:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/413 [^]
(0174206)
hgbot   
2025-01-15 17:48   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e9c02da908d2f9cadde78181d59df9977f16a997
Author: Augusto Mauch <amauch@orisha.com>
Date: 15-01-2025 16:48:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e9c02da908d2f9cadde78181d59df9977f16a997 [^]

Related to ISSUE-57538: Includes button id when executing action, updates test to support launch API that accepts two properties

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierButton/__test__/ProductModifierButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Service/ServiceTicketLineButton/__test__/ServiceTicketLineButton.test.jsx
---
(0174207)
hgbot   
2025-01-15 17:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3297 [^]