0057526: Variable OTF Coupon can be created and applied with zero/negative/greater than 100% Discount value

Openbravo Issue Tracking System - POS2
View Issue Details

ID	Project	Category	View Status	Date Submitted	Last Update
0057526	POS2	POS	public	2024-12-20 17:58	2024-12-20 17:59

Reporter	Daria_Sh
Assigned To	Retail
Priority	normal	Severity	major	Reproducibility	always
Status	new	Resolution	open
Platform		OS	5	OS Version
Product Version
Target Version		Fixed in Version
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency Pack	No

Summary	0057526: Variable OTF Coupon can be created and applied with zero/negative/greater than 100% Discount value
Description	When zero/negative/greater than 100% values are entered as the 'Discount%' in the OTF Rule in the Backoffice, the rule is saved, and the OTF Coupon can still be generated and applied in the POS. In the Backoffice: 1. Go to 'Discounts and Promotions' window 2. Create a new discount with 'Variable Amount Coupons' promotion type 3. Fulfill the required fields 4. Tick 'Uses coupon codes' and 'Is OTF Coupon' flags 5. Activate the Promotion/Discount by clicking 'Activate the selected records' 6. Go to 'OTF Coupons Generation Rules' window 7. Create new Rule → Fulfill the following fields: - Applicant, Search Key, Description and Starting Date - Issuance Time: At Paid Time - Promotion/Discount: the one created above - Amount Rule: Percentage - Discount %: 0\|-5\|1000% - Number of Uses: N Uses - Number of Uses Limit - Active: ✔ 8. Proceed to 'Print' tab → Fulfill the required fields 9. Launch the HW manager
Steps To Reproduce	1. Login to POS (livebuilds:vallblanca/openbravo) 2. Add product to the Order 3. Complete the Order (Click 'Pay', select 'Cash' and click 'Done') 4. Select 'Print' delivery option 5. Verify the printed Coupon in the HW manager Actual Result: The Coupon is printed and saved in the BO (Discount Coupon window) with with the 'Amount' matching % of the Order Total per OTF Rule 6. Add product to the Order 7. Scan or redeem Coupon Code Actual Result: The coupon is applied
Proposed Solution	The validation should be set for 'Discount%' field preventing to save OTF rule with zero/negative/greater than 100% value
Additional Information
Tags	No tags attached.
Relationships
Attached Files	Screenshot_69.png (147,965) 2024-12-20 17:58 https://issues.openbravo.com/file_download.php?file_id=20670&type=bug Screenshot_70.png (87,001) 2024-12-20 17:59 https://issues.openbravo.com/file_download.php?file_id=20671&type=bug

Issue History
Date Modified	Username	Field	Change
2024-12-20 17:58	Daria_Sh	New Issue
2024-12-20 17:58	Daria_Sh	Assigned To	=> Retail
2024-12-20 17:58	Daria_Sh	File Added: Screenshot_69.png
2024-12-20 17:58	Daria_Sh	Triggers an Emergency Pack	=> No
2024-12-20 17:59	Daria_Sh	File Added: Screenshot_70.png
2024-12-20 17:59	Daria_Sh	Description Updated	bug_revision_view_page.php?rev_id=28951#r28951

There are no notes attached to this issue.