Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057517POS2POSpublic2024-12-20 10:412025-01-16 11:59
Reporterkchoperena 
Assigned Toradhakrishnan 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionunable to reproduce 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057517: JS error when clicking on DONE with prepayments enabled in a fully paid order
DescriptionHaving prepayments enabled, if we reopen the order, navigate to the payment section and click on DONE, a JS error appears

The error happens in the CashupUtils.js line 290:

prepaymentsAmount =
          OB.DEC.sub(ticket.obposPrepaymentamt, deliveredGrossAmount) <= 0
            ? ticket.obposPrepaymentamt
            : OB.DEC.sub(ticket.obposPrepaymentamt, deliveredGrossAmount);
Steps To ReproduceVIDEO: https://drive.google.com/file/d/1dLcqXZN6cBNE2LceT7rtlzZJQL8NINsM/view?usp=sharing [^]
PRE-REQUIREMENTS:
- Have enabled prepayments

STEPS:
1.- Log into the POS2
2.- Add a pick up in store product line to the ticket
3.- Pay completely the ticket and complete it
4.- Reopen the ticket
5.- Go to payment section and click in DONE


RESULT:
An error will happen and the delivery will not be performed
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2024-12-23 11-18-54.png (187,883) 2024-12-23 11:30
https://issues.openbravo.com/file_download.php?file_id=20677&type=bug
png

png Screenshot from 2024-12-23 11-18-59.png (203,579) 2024-12-23 11:31
https://issues.openbravo.com/file_download.php?file_id=20678&type=bug
png

png Screenshot from 2024-12-23 11-30-25.png (544,659) 2024-12-23 11:31
https://issues.openbravo.com/file_download.php?file_id=20679&type=bug
Issue History
Date ModifiedUsernameFieldChange
2024-12-20 10:41kchoperenaNew Issue
2024-12-20 10:41kchoperenaAssigned To => Retail
2024-12-20 10:41kchoperenaTriggers an Emergency Pack => No
2024-12-20 12:09guillermogilAssigned ToRetail => Triage Omni WMS
2024-12-20 13:17kchoperenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28949#r28949
2024-12-23 10:23mtaalNote Added: 0173610
2024-12-23 10:23mtaalStatusnew => feedback
2024-12-23 11:30kchoperenaFile Added: Screenshot from 2024-12-23 11-18-54.png
2024-12-23 11:31kchoperenaFile Added: Screenshot from 2024-12-23 11-18-59.png
2024-12-23 11:31kchoperenaFile Added: Screenshot from 2024-12-23 11-30-25.png
2024-12-23 11:44kchoperenaNote Added: 0173622
2024-12-23 12:32kchoperenaAssigned ToTriage Omni WMS => Retail
2024-12-23 12:32kchoperenaStatusfeedback => new
2024-12-23 12:33kchoperenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28961#r28961
2024-12-23 16:14guillermogilAssigned ToRetail => guillermogil
2024-12-23 16:14guillermogilAssigned Toguillermogil => Triage Omni OMS
2024-12-23 16:17kchoperenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28962#r28962
2024-12-23 16:44kchoperenaSummaryThe functionality that delivers an order that has lines prepared ready to deliver and is paid completely is broken => JS error when clicking on DONE with prepayments enabled in a fully paid order
2024-12-23 16:44kchoperenaDescription Updatedbug_revision_view_page.php?rev_id=28964#r28964
2024-12-23 16:44kchoperenaSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28965#r28965
2024-12-23 16:47kchoperenaDescription Updatedbug_revision_view_page.php?rev_id=28966#r28966
2024-12-30 13:54aferrazAssigned ToTriage Omni OMS => radhakrishnan
2024-12-30 13:54aferrazNote Added: 0173732
2025-01-16 11:59kchoperenaNote Added: 0174223
2025-01-16 11:59kchoperenaStatusnew => closed
2025-01-16 11:59kchoperenaResolutionopen => unable to reproduce

Notes
(0173610)
mtaal   
2024-12-23 10:23   
Some questions:
- Can you provide the error message and also the error from the log?
- In which environment does this happen?
- Can it be reproduced in live builds?
(0173622)
kchoperena   
2024-12-23 11:44   
I noticed that the issue is not related to the delivery functionality. It is a general bug in the POS when you reopen a ticket fully paid and click again in DONE button to synchronize it

VIDEO with easier steps to reproduce: https://drive.google.com/file/d/1dLcqXZN6cBNE2LceT7rtlzZJQL8NINsM/view?usp=sharing [^]

Probably it makes sense to involve someone from the POS team or directly assign them the issue
(0173732)
aferraz   
2024-12-30 13:54   
Jira: https://openbravo.atlassian.net/browse/RM-20130 [^]
(0174223)
kchoperena   
2025-01-16 11:59   
Not reproduced anymore