Openbravo Issue Tracking System - POS2
View Issue Details
0057405POS2Corepublic2024-12-10 10:082025-01-24 14:16
aaroncalero 
AugustoMauch 
normalmajoralways
closedfixed 
5
 
25Q2 
No
0057405: MultiOptionDialog does not support the dialogType prop
When 0056122 was implemented, BaseDialog components were given the capability to receive a dialogType as a prop (error', 'warning', 'info' or 'success') to apply special css styles in these cases.
As part of that change, the base StandardDialog and ConfirmationDialog (used via askConfirmation api) were also extended to support the dialogType prop (as they are extensions of BaseDialog)

The MultiOptionDialog component (another extension of BaseDialog, that works as a ConfirmationDialog with extensible buttons), however, however, was not included in 0056122 and therefore it is not possible to pass the dialogType prop to these components
Check the component files for BaseDialog, ConfirmationDialog or StandardDialog and verify that dialogType can be passed as a prop.

Check MultiOptionDialog and verify that it does not support dialogType
No tags attached.
Issue History
2024-12-10 10:08aaroncaleroNew Issue
2024-12-10 10:08aaroncaleroAssigned To => Triage Platform Base
2024-12-10 10:08aaroncaleroTriggers an Emergency Pack => No
2025-01-16 13:21AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2025-01-16 13:21AugustoMauchStatusnew => scheduled
2025-01-23 17:53hgbotNote Added: 0174617
2025-01-24 14:15hgbotNote Added: 0174678
2025-01-24 14:16hgbotResolutionopen => fixed
2025-01-24 14:16hgbotStatusscheduled => closed
2025-01-24 14:16hgbotFixed in Version => 25Q2
2025-01-24 14:16hgbotNote Added: 0174679

Notes
(0174617)
hgbot   
2025-01-23 17:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1731 [^]
(0174678)
hgbot   
2025-01-24 14:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1731 [^]
(0174679)
hgbot   
2025-01-24 14:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 012eb80f6ce93c946afedab5b8a410f072fc7754
Author: Augusto Mauch <amauch@orisha.com>
Date: 24-01-2025 13:15:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/012eb80f6ce93c946afedab5b8a410f072fc7754 [^]

Fixes ISSUE-57405: dialogType can be passed to MultiOptionalDialog, will be forwarded to BaseDialog

---
M web-jspack/org.openbravo.core2/src/components/MultiButtonStandardDialog/MultiButtonStandardDialog.jsx
M web-jspack/org.openbravo.core2/src/components/MultiOptionDialog/MultiOptionDialog.jsx
---