Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057397POS2POSpublic2024-12-09 17:392024-12-30 07:36
Reporterdorian_robillard 
Assigned ToBimla_vm 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057397: VIP price : Product planned in the future is considered as promotion missing
DescriptionI have a promotion active price adjustment, price adjustment scope "Set a specific price adjustment for each product" and POS configuration configures with all the flags to display discount

In product tab I have a product with dates in the future

When I add the product to the basket I see that the promotion is missing. It should not as the promotion can be applied in the future
Steps To ReproduceConfigure the promotion in the backoffice

Add the product to the basket
Proposed SolutionThis product should not be considered as applicable
Additional Information
TagsNo tags attached.
Relationships
related to defect 0056692 closed Bimla_vm VIP price : ‘display discount in order line when not apply’ is not working in POS 
Attached Filespng Capture d’écran 2024-12-09 173208.png (187,901) 2024-12-09 17:39
https://issues.openbravo.com/file_download.php?file_id=20618&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-12-09 17:39dorian_robillardNew Issue
2024-12-09 17:39dorian_robillardAssigned To => Triage Platform Base
2024-12-09 17:39dorian_robillardFile Added: Capture d’écran 2024-12-09 173208.png
2024-12-09 17:39dorian_robillardTriggers an Emergency Pack => No
2024-12-13 14:41victor_perezAssigned ToTriage Platform Base => Retail
2024-12-18 15:13guillermogilAssigned ToRetail => migueldejuana
2024-12-18 15:13guillermogilStatusnew => acknowledged
2024-12-18 15:13guillermogilCategoryCore => POS
2024-12-18 15:15guillermogilRelationship addedrelated to 0056692
2024-12-20 08:22migueldejuanaAssigned Tomigueldejuana => jorgewederago
2024-12-20 09:24Bimla_vmAssigned Tojorgewederago => Bimla_vm
2024-12-20 09:25Bimla_vmStatusacknowledged => scheduled
2024-12-20 11:51gorka_gilNote Added: 0173556
2024-12-27 09:51hgbotNote Added: 0173690
2024-12-30 07:36hgbotResolutionopen => fixed
2024-12-30 07:36hgbotStatusscheduled => closed
2024-12-30 07:36hgbotFixed in Version => RR25Q1
2024-12-30 07:36hgbotNote Added: 0173723
2024-12-30 07:36hgbotNote Added: 0173724

Notes
(0173556)
gorka_gil   
2024-12-20 11:51   
It is a valid issue, for vip prices it should take into account product related filters and dates.

so this should be taken into account, if my memory didn't fail, it was already taken into account, maybe stops working at some moment...
(0173690)
hgbot   
2024-12-27 09:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/161 [^]
(0173723)
hgbot   
2024-12-30 07:36   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 5e82799d2da06e12e3ba0ecd3501e136d909522f
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 26-12-2024 10:36:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5e82799d2da06e12e3ba0ecd3501e136d909522f [^]

Fixed ISSUE-57397: Validated discount visibility for specific product's dateCheck

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-visibility.js
---
(0173724)
hgbot   
2024-12-30 07:36   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/161 [^]