Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057343Retail ModulesRT-Printerpublic2024-12-02 11:452024-12-30 12:49
Reportervictor_perez 
Assigned Tonjimenez 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product VersionRR24Q3.2 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerOBPS
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057343: Log warning during fiscalization and the property cfrtpSingleusevouchers
DescriptionIn the Footkorner production logs, we have this log message:

2024-11-27 12:09:09,818 [Import Entry - 1] WARN org.openbravo.events.fiscalization.hooks.FiscalData - Cannot find field "cfrtpSingleusevouchers" in Order to store the value "[]"
2024-11-27 12:09:09,818 [Import Entry - 1] WARN org.openbravo.events.fiscalization.hooks.FiscalData - Cannot find field "cfrtpSingleusevouchers" in Invoice to store the value "[]"

This field is present in this module: org.openbravo.events.fiscalization
Steps To ReproduceAs it is related with the fiscalization and RT Printer, I don't know to check/reproduce it.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0054230 closed njimenez Addapt single gift cards to rt printer 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-12-02 11:45victor_perezNew Issue
2024-12-02 11:45victor_perezAssigned To => Triage Platform Conn
2024-12-02 11:45victor_perezOBNetwork customer => OBPS
2024-12-02 11:45victor_perezTriggers an Emergency Pack => No
2024-12-02 11:49adrianromeroNote Added: 0172871
2024-12-09 11:05adrianromeroNote Added: 0173056
2024-12-09 11:05adrianromeroAssigned ToTriage Platform Conn => njimenez
2024-12-09 11:06adrianromeroStatusnew => scheduled
2024-12-28 13:47njimenezRelationship addedcaused by 0054230
2024-12-28 13:48hgbotMerge Request Status => open
2024-12-28 13:48hgbotNote Added: 0173713
2024-12-28 13:52hgbotNote Added: 0173714
2024-12-30 12:46hgbotMerge Request Statusopen => approved
2024-12-30 12:49hgbotNote Added: 0173730
2024-12-30 12:49hgbotResolutionopen => fixed
2024-12-30 12:49hgbotStatusscheduled => closed
2024-12-30 12:49hgbotNote Added: 0173731

Notes
(0172871)
adrianromero   
2024-12-02 11:49   
The problem is that the field *cfrtpSingleusevouchers* is returned for storing in order and invoice table:

https://gitlab.com/openbravo/product/pmods/org.openbravo.events.fiscalrtprinter/-/blob/master/web/org.openbravo.events.fiscalrtprinter/source/model/requests/fiscalReceipt.js?ref_type=heads#L48 [^]

But the column is not defined at database level.
(0173056)
adrianromero   
2024-12-09 11:05   
Issue has been introduced in change https://gitlab.com/openbravo/product/pmods/org.openbravo.events.fiscalrtprinter/-/commit/31d7d83ca6ef9be4c5b0dde93d4bc162d418d424#1004f719ea24c535966aaba59b02c04f6093df6b_46_48 [^]
(0173713)
hgbot   
2024-12-28 13:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.fiscalrtprinter/-/merge_requests/25 [^]
(0173714)
hgbot   
2024-12-28 13:52   
Repository: https://gitlab.com/openbravo/ci/context_definitions [^]
Changeset: cec0de28d2c26777090424256346c3c8da37dc58
Author: Natalia Jiménez <n.jimenez@orisha.com>
Date: 28-12-2024 13:51:44
URL: https://gitlab.com/openbravo/ci/context_definitions/-/commit/cec0de28d2c26777090424256346c3c8da37dc58 [^]

Related to ISSUE-57343: Added custom context definition for platform connectors node

---
A platform/platform-conn-nji.json
---
(0173730)
hgbot   
2024-12-30 12:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.fiscalrtprinter/-/merge_requests/25 [^]
(0173731)
hgbot   
2024-12-30 12:49   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.fiscalrtprinter [^]
Changeset: 791d804e136de797e6c4fe93b3464660f58989cd
Author: Natalia Jiménez <n.jimenez@orisha.com>
Date: 28-12-2024 13:41:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.fiscalrtprinter/-/commit/791d804e136de797e6c4fe93b3464660f58989cd [^]

Fixed ISSUE-57343: Removed single use vouchers from information values to avoid saving it in a custom database field

---
M web-test/RTPrinterFiscalization.test.js
M web-test/model/requests/fiscalReceipt.test.js
M web-test/model/utils/processedGiftCardPayment.test.js
M web/org.openbravo.events.fiscalrtprinter/source/RTPrinterFiscalization.js
M web/org.openbravo.events.fiscalrtprinter/source/model/requests/fiscalReceipt.js
M web/org.openbravo.events.fiscalrtprinter/source/model/utils/processedGiftCardPayment.js
---