Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057334POS2POSpublic2024-10-02 12:292024-11-30 08:57
Reporterfermin_ostivar 
Assigned ToRajesh_18 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Versionpi 
Target Version24Q3.3Fixed in Version24Q3.3 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelProduction - QA Approved
Regression date2024-08-14
Regression introduced in releasemain
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/111409aa501e50d733b8b0c375a2bcbd071ad192 [^]
Triggers an Emergency PackNo
Summary0057334: Sales Representative removed when a product is added
DescriptionThe Sales Representative selected is removed when a product is added to the order.
Steps To Reproduce[BOS]
At TouchPoint Type level:
Sales Representative in New Orders * -> Keep it blank
Sales Representative is Mandatory -> False

[POS]
Login
Select a "Sales Representative"
Add a Product

The sales representative is removed from the order
Proposed SolutionDo not remove the sales representative from the order
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0056621 closed Rajesh_18 Sales Representative removed when a product is added 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-11-29 12:51marvintmTypedefect => backport
2024-11-29 12:51marvintmTarget Version => 24Q3.3
2024-11-30 07:12hgbotNote Added: 0172792
2024-11-30 07:13hgbotNote Added: 0172793
2024-11-30 08:57hgbotNote Added: 0172803
2024-11-30 08:57hgbotNote Added: 0172804
2024-11-30 08:57hgbotResolutionopen => fixed
2024-11-30 08:57hgbotStatusscheduled => closed
2024-11-30 08:57hgbotFixed in Version => 24Q3.3
2024-11-30 08:57hgbotNote Added: 0172805
2024-11-30 08:57hgbotNote Added: 0172806

Notes
(0172792)
hgbot   
2024-11-30 07:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3177 [^]
(0172793)
hgbot   
2024-11-30 07:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/82 [^]
(0172803)
hgbot   
2024-11-30 08:57   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns [^]
Changeset: 1051397bdab2cd1af52585d27e669bf9420d7b0e
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 30-11-2024 11:38:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/commit/1051397bdab2cd1af52585d27e669bf9420d7b0e [^]

Related to ISSUE-57334: Sales Representative is set based on the configuration

---
M web/org.openbravo.retail.returns/app/model/business-object/ticket/actions/ReturnVerifiedTicket.js
---
(0172804)
hgbot   
2024-11-30 08:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.returns/-/merge_requests/82 [^]
(0172805)
hgbot   
2024-11-30 08:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3177 [^]
(0172806)
hgbot   
2024-11-30 08:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ab0f2d115e9e8e9521f71926beda159b43436deb
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 30-11-2024 11:38:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ab0f2d115e9e8e9521f71926beda159b43436deb [^]

Fixed ISSUE-57334: Sales Representative is set based on the configuration

---
A web-jspack/org.openbravo.pos2/src/model/ticket/actions/setTicketHeaderAndLineWithSalesRepresentative.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProductActionPreparation.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetDefaultSalesRepresentative.js
R web-jspack/org.openbravo.pos2/src/model/ticket/actions/ReturnVerifiedTicketHooks.js
R web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/ReturnVerifiedTicketHooks.test.js
---