0057253: Not possible to login to the POS with the offline mode

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0057253

POS2

POS

public

2024-11-22 09:19

2024-11-28 15:18

Reporter

victor_perez

Assigned To

sreehari

Priority

urgent

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

25Q1

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Support ticket

Regression level

Production - Confirmed Stable

Regression date

2024-07-19

Regression introduced in release

Regression introduced by commit

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3b98aafeeaa3a836d09bf8f5bc66c5be4879afeb [^]

Triggers an Emergency Pack

Summary

0057253: Not possible to login to the POS with the offline mode

Description

When you have a till loaded, if you activate the offline mode, you will not be able to login again.

The error is thrown from the funtion "loginInitActions", then the line of code "await initializeDocumentSequence();" and finally in the "doFetch" from the screenshot.

You can reproduce it in livebuilds.

Steps To Reproduce

1. Login a till with the online mode activated. IT MUST BE A TILL THAT HAS NOT DONE ANY ORDER (thus the "sequence" value of the main orders document type must have value "0")
2. Once the till is fully loaded, log out
3. Activate the offline mode using Chrome tools
4. Log in to the till
5. An error will appear with the message "This action is not allowed in offline mode"

Proposed Solution

The problem seems to be in this line:

https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3b98aafeeaa3a836d09bf8f5bc66c5be4879afeb#f4d041f0b1c18efe7cf1078a093ace355ae7efb7_141_145 [^]

The problem is that if sequenceNumber is 0, then the expression

if (!DocumentSequence?.lastassignednum?.sequenceNumber) {

I suppose we can instead check if sequenceNumber is undefined, and only then try to load the terminal. In any case, I think most probably still we need to surround that part with a try/catch, although most probably in the case it is undefined we are already screwed and even if we attempt to login offline, we will probably fail so this part must also be checked.

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0057287	24Q4	closed	sreehari	Not possible to login to the POS with the offline mode
depends on	backport	0057288	24Q3.3	closed	sreehari	Not possible to login to the POS with the offline mode
depends on	backport	0057289	24Q2.5	closed	sreehari	Not possible to login to the POS with the offline mode
caused by	defect	0056070		closed	sreehari	When sequenceNumber is undefined we get it from terminal and we get DocumentNo duplicated