Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057222Retail ModulesCopy Retail Storepublic2024-11-21 11:492024-12-11 07:31
Reporterwilliam_vermersch 
Assigned Tokousalya_r 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionOpenbravo Appliance 14.04
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket114629
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057222: Copy Store + Deposit Invoice not copying the value from the Deposit Invoice Document Type
DescriptionHello,

Firstly I couldn't find the Deposit Invoice in the mantis module list, so I couldn't set it (sorry if this isn't the good module to report the issue).

When you're creating a new Document Type for the Deposit Invoice, it is not copied when you're doing a Copy Store process.
Steps To Reproduce1. Create Deposit Invoice Document type
2. Set it as the Deposit Invoice Document Type in the Document Type screen of the classical Order Document type
3. Use Copy Store process
4. Check that the Deposit Invoice Document Type has not been cloned, nor set in the cloned classical Order Document Type

In my example I cloned from Orange org to WVE org, at the end the TEST WVE Document Type (name doesn't matter) has not been created on WVE Org, nor set in the Order Document Type of the org WVE
Proposed SolutionThere are probably some handler missing org.openbravo.retail.copystore.process.PropertyHandler or a complementary module should be created (copytstore.depositinvoices) since the Deposit Invoice can work independently from the Copy Store module (add on module)
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng cloned_configuration.png (77,783) 2024-11-21 11:49
https://issues.openbravo.com/file_download.php?file_id=20531&type=bug
png

png created_configuration.png (78,718) 2024-11-21 11:50
https://issues.openbravo.com/file_download.php?file_id=20532&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-11-21 11:49william_vermerschNew Issue
2024-11-21 11:49william_vermerschAssigned To => Retail
2024-11-21 11:49william_vermerschFile Added: cloned_configuration.png
2024-11-21 11:49william_vermerschOBNetwork customer => Gold
2024-11-21 11:49william_vermerschSupport ticket => 114629
2024-11-21 11:49william_vermerschTriggers an Emergency Pack => No
2024-11-21 11:50william_vermerschFile Added: created_configuration.png
2024-11-21 11:51william_vermerschSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=28811#r28811
2024-11-21 12:04guillermogilAssigned ToRetail => Triage Omni OMS
2024-11-22 10:02javietxeIssue Monitored: javietxe
2024-11-28 06:37jonaeNote Added: 0172658
2024-11-28 06:37jonaeAssigned ToTriage Omni OMS => kousalya_r
2024-12-05 09:56hgbotMerge Request Status => open
2024-12-05 09:56hgbotNote Added: 0173009
2024-12-10 09:02william_vermerschNote Added: 0173113
2024-12-10 09:06william_vermerschNote Added: 0173114
2024-12-11 07:31hgbotMerge Request Statusopen => approved
2024-12-11 07:31hgbotResolutionopen => fixed
2024-12-11 07:31hgbotStatusnew => closed
2024-12-11 07:31hgbotNote Added: 0173155
2024-12-11 07:31hgbotNote Added: 0173156

Notes
(0172658)
jonae   
2024-11-28 06:37   
Jira - https://openbravo.atlassian.net/browse/RM-19481 [^]
(0173009)
hgbot   
2024-12-05 09:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.copystore/-/merge_requests/8 [^]
(0173113)
william_vermersch   
2024-12-10 09:02   
Hi,

I saw that you pushed a merge request, it seems strange that the fix is directly in the copystore module, since it would make the copystore dependent of deposit invoice module.

Wouldn't be easier to have an extension module for that ?

Also our issue is also happening in 20Q3 (Weldom version), could we get a backport of the solution (I suppose that an extension module would work for any version though).

Regards,
William
(0173114)
william_vermersch   
2024-12-10 09:06   
For that comment:

"I saw that you pushed a merge request, it seems strange that the fix is directly in the copystore module, since it would make the copystore dependent of deposit invoice module.

Wouldn't be easier to have an extension module for that ?"

I suppose that deposit invoice is now integrated by default in POS version (no complementary module right ?), so forget about it.

Regards,
William
(0173155)
hgbot   
2024-12-11 07:31   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.copystore [^]
Changeset: 61686f2b3722c8fe1c2e61ec3607d404b7bd24de
Author: Kousalya Ramasamy <k.ramasamy@external.orisha.com>
Date: 05-12-2024 14:24:58
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.copystore/-/commit/61686f2b3722c8fe1c2e61ec3607d404b7bd24de [^]

Fixed ISSUE-57222: Added deposit invoice copy in copy store process

---
M src/org/openbravo/pos2/copystore/DefaultPos2PropertiesHandler.java
---
(0173156)
hgbot   
2024-12-11 07:31   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.copystore/-/merge_requests/8 [^]