0057216: Check constraint renaming broken custom AD_MESSAGE associated to it

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0057216

Retail Modules

Retail Configuration

public

2024-11-20 18:01

2024-11-21 12:14

Reporter

shuehner

Assigned To

shuehner

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR25Q1

Merge Request Status

approved

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0057216: Check constraint renaming broken custom AD_MESSAGE associated to it

Description

Back in 2019 the check-constraint
EM_OBRETCO_AVAILABLECROSSS_CHK
was renamed to be
EM_OBRETCO_AVAILABLECROSS

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/caf5670d148cc660f507214f45c3c4c929159023#232157b5d7a7d690e3aa00678be197d1a23a0e3b_8_8 [^]

But we missed hidden api of having an AD_MESSAGE with VALUE matching name of the check constraint.
So since then the custom error message for it is no longer shown
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/blob/master/src-db/database/sourcedata/AD_MESSAGE.xml?ref_type=heads#L44 [^]

Steps To Reproduce

Search for EM_OBRETCO_AVAILABLECROSSS_CHK and do not find any usage for it
Find the check constraint rename linked in description noticing it missed to rename the message also

functional case for reproducer:
- as system admin role
- Go to window Inventory status
- Insert a new row
with Available=N

Error message in UI is:
Saving failed. There is a constraint defined that was not satisfied. Please check the data entered

and openbravo.log shows technical error to be:
ERROR: new row for relation "m_inventorystatus" violates check constraint "em_obretco_availablecross"

When message should be:
Saving failed. Inventory Status can't be Available for Cross Store if it is not Available

Proposed Solution

Rename the ad_message.value to match the new check constraint.

Additional Information