Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057097POS2Corepublic2024-11-14 10:502024-11-20 12:39
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057097: Menus are not properly styled in dark mode
DescriptionBaseMenu is not properly styled and appears blank if in dark mode, probably also works incorrectly on other stylings apart from the base light mode.

A screenshot has been attached.
Steps To Reproduce1. Login in POS2
2. Click on the three dots at the bottom left, over the Pay button at the bottom of the ticket

Check that the styling is correct in Light Mode

3. Switch to Dark mode by clicking on the Settings(icon/button) at the top right and then Dark Mode.
4. Check the three dots menu again, it is now shown incorrectly, all blank.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
caused by feature request 0056799 closed cberner Upgrade to React 18.x 
Attached Filespng fail-menu.png (149,665) 2024-11-14 10:50
https://issues.openbravo.com/file_download.php?file_id=20470&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-11-14 10:50cbernerNew Issue
2024-11-14 10:50cbernerAssigned To => Triage Platform Base
2024-11-14 10:50cbernerFile Added: fail-menu.png
2024-11-14 10:50cbernerTriggers an Emergency Pack => No
2024-11-14 10:51cbernerAssigned ToTriage Platform Base => cberner
2024-11-14 10:51cbernerStatusnew => acknowledged
2024-11-14 10:51cbernerRelationship addedcaused by 0056799
2024-11-14 13:23hgbotNote Added: 0171978
2024-11-20 12:39hgbotResolutionopen => fixed
2024-11-20 12:39hgbotStatusacknowledged => closed
2024-11-20 12:39hgbotFixed in Version => 25Q1
2024-11-20 12:39hgbotNote Added: 0172346
2024-11-20 12:39hgbotNote Added: 0172347

Notes
(0171978)
hgbot   
2024-11-14 13:23   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1640 [^]
(0172346)
hgbot   
2024-11-20 12:39   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: b765d1011d47160a5148c585ce7acf5fa8351b72
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 20-11-2024 12:05:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/b765d1011d47160a5148c585ce7acf5fa8351b72 [^]

Fixes ISSUE-57097: Menus are not properly styled in dark mode

Due to the upgrade of MUI 4 to MUI 5 and the upgrade to React 18,
mui/styles was deprecated and is not supported in React 18. As such, the
alternative is to use the proper scss styling on MUI components or styled
function.

In this case, the scss has been changed to account for the proper
styling and theming.

---
M web-jspack/org.openbravo.core2/src/components/BaseMenu/BaseMenu.jsx
M web-jspack/org.openbravo.core2/src/components/BaseMenu/BaseMenu.scss
---
(0172347)
hgbot   
2024-11-20 12:39   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1640 [^]