Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057034Retail ModulesRetail Configurationpublic2024-11-07 11:082024-11-11 12:22
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR25Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057034: Retail config: Remove modulescript InitializeAvailableCrossStore (not needed)
DescriptionThis modulescript was added in 2019 with the comment:
* Initialize Available for Cross Store value for existing Inventory Status with the same value than
 * Available, only in the install.source. For update.database we use EM_OBRETCO_AvailableCrossStore
 * onCreateDefault.

indicating that the onCreateDefault used to populate EM_OBRETCO_AvailableCrossStore with value of other column Available did not work during install.source.

Testing this now that is working fine so the modulescript is not needed and should be removed.
Steps To ReproduceCreate workspace consisting of
- backoffice
- org.openbravo.retail.config
module

run install.source

Verify that value of EM_OBRETCO_AvailableCrossStore is same as value of Available column for all rows in table m_inventorystatus.
Proposed SolutionRemove the modulescript as obsolete
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0057210 closed shuehner Openbravo ERP Move content of org.openbravo.retail.config module to backoffice/core repo 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-11-07 11:08shuehnerNew Issue
2024-11-07 11:08shuehnerAssigned To => shuehner
2024-11-07 11:08shuehnerOBNetwork customer => No
2024-11-07 11:08shuehnerTriggers an Emergency Pack => No
2024-11-07 11:13hgbotMerge Request Status => open
2024-11-07 11:13hgbotNote Added: 0171618
2024-11-11 12:22hgbotMerge Request Statusopen => approved
2024-11-11 12:22hgbotResolutionopen => fixed
2024-11-11 12:22hgbotStatusnew => closed
2024-11-11 12:22hgbotNote Added: 0171762
2024-11-11 12:22hgbotFixed in Version => RR25Q1
2024-11-11 12:22hgbotNote Added: 0171763
2024-11-20 16:09shuehnerRelationship addedblocks 0057210

Notes
(0171618)
hgbot   
2024-11-07 11:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/32 [^]
(0171762)
hgbot   
2024-11-11 12:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/32 [^]
(0171763)
hgbot   
2024-11-11 12:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config [^]
Changeset: e2ca9f34c010764cfce3f27bd65f3a3bf319e164
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 08-11-2024 10:51:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/e2ca9f34c010764cfce3f27bd65f3a3bf319e164 [^]

Fixed ISSUE-57034: Remove modulescript InitializeAvailableCrossStore

This modulescript was used to fill value of EM_OBRETCO_AvailableCrossStore
based on value of Available column in same table m_inventorystatus.

Comment in the script claims this didn't work using the normal
onCreateDefault logic when module was added during install.source
directly.

Retesting this behavior now that is working out of the box.
Remove the modulescript as it is not needed anymore.

---
R build/classes/org/openbravo/retail/config/modulescript/InitializeAvailableCrossStore.class
R build/classes/org/openbravo/retail/config/modulescript/InitializeAvailableCrossStoreData.class
R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeAvailableCrossStore.java
R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeAvailableCrossStore_Data.xsql
---