Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057027Retail ModulesRetail Configurationpublic2024-11-06 18:402024-11-07 13:55
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR25Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057027: Retail config: Remove 2 old no longer needed Modulescripts InitializeProductListProductCategory / InitializeStoreProductListAndP
DescriptionThe 2 modulescripts:
- InitializeProductListProductCategory
- InitializeStoreProductListAndPriceList

both are configured to run on
a.) install.source
b.) update.database when updating from a version of retail.pack <19Q3

Reviewing status with AMO both are no longer needed

Removing them both reduces amount of code in modulescripts but also reduces amount of code to move in upcoming merging of this module into backoffice repo
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0057210 new Triage Platform Base Openbravo ERP Move content of org.openbravo.retail.config module to backoffice/core repo 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-11-06 18:40shuehnerNew Issue
2024-11-06 18:40shuehnerAssigned To => Retail
2024-11-06 18:40shuehnerTriggers an Emergency Pack => No
2024-11-06 18:48hgbotNote Added: 0171587
2024-11-07 06:08guillermogilAssigned ToRetail => guillermogil
2024-11-07 06:08guillermogilStatusnew => scheduled
2024-11-07 06:09hgbotNote Added: 0171596
2024-11-07 06:15hgbotNote Added: 0171597
2024-11-07 06:16guillermogilAssigned Toguillermogil => shuehner
2024-11-07 06:16guillermogilProposed Solution updated
2024-11-07 13:45hgbotNote Added: 0171637
2024-11-07 13:55shuehnerNote Added: 0171642
2024-11-07 13:55shuehnerStatusscheduled => resolved
2024-11-07 13:55shuehnerResolutionopen => fixed
2024-11-07 13:55shuehnerStatusresolved => closed
2024-11-07 13:55shuehnerFixed in Version => RR25Q1
2024-11-20 16:09shuehnerRelationship addedblocks 0057210

Notes
(0171587)
hgbot   
2024-11-06 18:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/30 [^]
(0171596)
hgbot   
2024-11-07 06:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/31 [^]
(0171597)
hgbot   
2024-11-07 06:15   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/31 [^]
(0171637)
hgbot   
2024-11-07 13:45   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/30 [^]
(0171642)
shuehner   
2024-11-07 13:55   
Adding note manually as commit has wrong issue reference.

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config [^] [^]
Changeset: 497da148424bc964d83203e06107f877b0d8a768
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 06-11-2024 18:42:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/497da148424bc964d83203e06107f877b0d8a768 [^] [^]

Fixes ISSUE-57026: Remove 2 old modulescripts

Those are 2 very old modulescipts which on run on:
- Updates from <19Q3
- install.source
  But sampledata consistency check in try-retail covering the main
  sampledata doesn't show any uncomitted change for them.

After review with AMO both are no longer needed to be kept.

---
R build/classes/org/openbravo/retail/config/modulescript/InitializeProductListProductCategory.class
R build/classes/org/openbravo/retail/config/modulescript/InitializeProductListProductCategoryData.class
R build/classes/org/openbravo/retail/config/modulescript/InitializeStoreProductListAndPriceList.class
R build/classes/org/openbravo/retail/config/modulescript/InitializeStoreProductListAndPriceListData.class
R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeProductListProductCategory.java
R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeProductListProductCategory_Data.xsql
R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeStoreProductListAndPriceList.java
R src-util/modulescript/src/org/openbravo/retail/config/modulescript/InitializeStoreProductListAndPriceList_Data.xsql