Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0057026Retail ModulesRetail Configurationpublic2024-11-06 17:192024-11-07 13:47
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR25Q1 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0057026: Retail config: old Auxiliarinput OBRETCO_RemoteProduct is no longer used and should be removed
DescriptionIssue 30553 from 2015 added an Auxiliarinput in retail config module OBRETCO_RemoteProduct which back then was used in display logic of the product category tab.

Another commit in issue 41006 in 2019 as part of Cross Store Assortment removed the usage of this auxiliarinput
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/6cfbe785a9c742ad90fa832d356958eea039451e [^]
"[CrossStoreAssortment] Remove Filter Product Categories tab display logic"

But it did not remove the auxinput itself back then.

The auxinput should be removed because:
- it is no longer used
- no other reference in published OBX or product repos could be found
- If does access posterminal preference which is not in dependencies of retail.config module
Steps To ReproduceLook at definition of auxiliarinput OBRETCO_RemoteProduct / F94E1C2071A54A7CB8F4AFEA71974D43
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks feature request 0057210 new Triage Platform Base Openbravo ERP Move content of org.openbravo.retail.config module to backoffice/core repo 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-11-06 17:19shuehnerNew Issue
2024-11-06 17:19shuehnerAssigned To => shuehner
2024-11-06 17:19shuehnerTriggers an Emergency Pack => No
2024-11-06 17:29hgbotNote Added: 0171585
2024-11-06 17:33hgbotNote Added: 0171586
2024-11-07 13:45hgbotResolutionopen => fixed
2024-11-07 13:45hgbotStatusnew => closed
2024-11-07 13:45hgbotFixed in Version => RR25Q1
2024-11-07 13:45hgbotNote Added: 0171636
2024-11-07 13:47hgbotNote Added: 0171638
2024-11-07 13:47hgbotNote Added: 0171639
2024-11-07 13:47hgbotNote Added: 0171640
2024-11-07 13:47hgbotNote Added: 0171641
2024-11-07 13:55shuehnerNote Deleted: 0171636
2024-11-20 16:09shuehnerRelationship addedblocks 0057210

Notes
(0171585)
hgbot   
2024-11-06 17:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/29 [^]
(0171586)
hgbot   
2024-11-06 17:33   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/31 [^]
(0171638)
hgbot   
2024-11-07 13:47   
Repository: https://gitlab.com/openbravo/ci/mobile-api [^]
Changeset: ee1c96eef693efe2e6df54d6fc9cdc0796c299b9
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 06-11-2024 17:32:56
URL: https://gitlab.com/openbravo/ci/mobile-api/-/commit/ee1c96eef693efe2e6df54d6fc9cdc0796c299b9 [^]

ISSUE-57026: Accept API change

---
M model/modules/org.openbravo.retail.config/src-db/database/sourcedata/AD_AUXILIARINPUT.xml
---
(0171639)
hgbot   
2024-11-07 13:47   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-api/-/merge_requests/31 [^]
(0171640)
hgbot   
2024-11-07 13:47   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config [^]
Changeset: d434f1e432147a4c4d033547601931c41ea4f2ba
Author: Stefan Huehner <s.huehner@orisha.com>
Date: 07-11-2024 12:45:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/commit/d434f1e432147a4c4d033547601931c41ea4f2ba [^]

Fixes ISSUE-57026: Remove unused Auxiliarinput OBRETCO_RemoteProduct

This Auxinput was added in issue 30553 and used in Displaylogic of
product category tab.
However later commit from issue 41006 removed it's only usage.

Additionally this auxinput is defined here in org.openbravo.retail.config
module but it's SQL query refences the OBPOS_remote.product preference
from posterminal module. That's not following declared dependencies of
retail.config module.

---
M src-db/database/sourcedata/AD_AUXILIARINPUT.xml
---
(0171641)
hgbot   
2024-11-07 13:47   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.config/-/merge_requests/29 [^]