Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0057008Openbravo ERPZ. Otherspublic2024-11-06 10:512025-02-11 15:43
inaki_azkonobieta 
AugustoMauch 
highminoralways
closedfixed 
5
main 
PR25Q2 
approved
OBPS
Core
No
0057008: Wrong insert happening in some environments
Every 5 minutes we have the following error in the log:
2024-11-06 10:02:07,008 [DefaultQuartzScheduler_Worker-3] ERROR org.openbravo.scheduling.ProcessRunData - SQL error in query: INSERT INTO AD_Process_Run (AD_Org_ID, AD_Client_ID, Isactive, Created, Createdby, Updated, UpdatedBy, AD_Process_Run_ID, Status, Start_Time, Runtime, Log, AD_Process_Request_ID, Scheduler_Instance) VALUES (?, ?, 'Y', NOW(), ?, NOW(), ?, ?, ?, NOW(), ?, ?, ?, ?) :org.postgresql.util.PSQLException: ERROR: insert or update on table "ad_process_run" violates foreign key constraint "ad_process_run_ad_client"
  Detail: Key (ad_client_id)=(4028E6C72959682B01295A070852010D) is not present in table "ad_client".
2024-11-06 10:02:07,008 [DefaultQuartzScheduler_Worker-3] ERROR org.openbravo.scheduling.ProcessMonitor - @CODE=0@ERROR: insert or update on table "ad_process_run" violates foreign key constraint "ad_process_run_ad_client"
  Detail: Key (ad_client_id)=(4028E6C72959682B01295A070852010D) is not present in table "ad_client".
javax.servlet.ServletException: @CODE=0@ERROR: insert or update on table "ad_process_run" violates foreign key constraint "ad_process_run_ad_client"
  Detail: Key (ad_client_id)=(4028E6C72959682B01295A070852010D) is not present in table "ad_client".
    at org.openbravo.scheduling.ProcessRunData.insert(ProcessRunData.java:112) ~[classes/:?]
    at org.openbravo.scheduling.ProcessMonitor.jobToBeExecuted(ProcessMonitor.java:139) [classes/:?]
    at org.quartz.core.QuartzScheduler.notifyJobListenersToBeExecuted(QuartzScheduler.java:1927) [quartz-2.3.2.jar:?]
    at org.quartz.core.JobRunShell.notifyListenersBeginning(JobRunShell.java:324) [quartz-2.3.2.jar:?]
    at org.quartz.core.JobRunShell.run(JobRunShell.java:173) [quartz-2.3.2.jar:?]
    at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573) [quartz-2.3.2.jar:?]
2024-11-06 10:02:07,008 [DefaultQuartzScheduler_Worker-3] ERROR org.openbravo.scheduling.DefaultJob - Error executing process org.openbravo.erpCommon.ad_process.AcctServerProcess
java.lang.NullPointerException: null
2024-11-06 10:02:07,008 [DefaultQuartzScheduler_Worker-3] INFO org.quartz.core.JobRunShell - Job OB_QUARTZ_GROUP.3CD8A7A68DFE4FDAAD20D2570D78DE3B threw a JobExecutionException:
org.quartz.JobExecutionException: java.lang.NullPointerException
    at org.openbravo.scheduling.DefaultJob.execute(DefaultJob.java:72) ~[classes/:?]
    at org.quartz.core.JobRunShell.run(JobRunShell.java:202) [quartz-2.3.2.jar:?]
    at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573) [quartz-2.3.2.jar:?]
Caused by: java.lang.NullPointerException
2024-11-06 10:02:07,013 [DefaultQuartzScheduler_Worker-3] ERROR org.openbravo.dal.core.OBContext - The query 'select r from ADRole r where r.id=:roleId' returned 0 results while only 1 result was expected
2024-11-06 10:02:07,013 [DefaultQuartzScheduler_Worker-3] ERROR org.openbravo.scheduling.ProcessMonitor - null
java.lang.NullPointerException: null


SOlutions tried that didn't work:
 - Redeployed the instance for checking that there is not a problem of the context
- No records in the ad_process_request has this ad_client_id in his record
- No records in the ad_process_request have this ad_client_id in the context
select * from ad_process_request where ob_context like '%4028E6C72959682B01295A070852010D%';

The client is related to the QA Testing and the process launched is org.openbravo.erpCommon.ad_process.AcctServerProcess
Automatically after deleting the client
No tags attached.
related to defect 0057981 closed AugustoMauch Avoid logs of wrong insert happening in some environments 
Issue History
2024-11-06 10:51inaki_azkonobietaNew Issue
2024-11-06 10:51inaki_azkonobietaAssigned To => Triage Omni OMS
2024-11-06 10:51inaki_azkonobietaOBNetwork customer => OBPS
2024-11-06 10:51inaki_azkonobietaModules => Core
2024-11-06 10:51inaki_azkonobietaTriggers an Emergency Pack => No
2024-11-06 10:51inaki_azkonobietaAssigned ToTriage Omni OMS => Triage Platform Base
2024-11-06 10:52javietxeIssue Monitored: javietxe
2024-11-10 22:55AugustoMauchNote Added: 0171732
2024-11-10 22:55AugustoMauchStatusnew => feedback
2024-11-28 13:59alostaleNote Added: 0172721
2024-11-28 13:59alostaleSeveritymajor => minor
2025-02-04 10:03javietxeNote Added: 0175088
2025-02-04 10:04javietxeStatusfeedback => new
2025-02-04 10:40javietxeRelationship addedhas duplicate 0057611
2025-02-04 10:41javietxeRelationship deletedhas duplicate 0057611
2025-02-06 23:16AugustoMauchAssigned ToTriage Platform Base => AugustoMauch
2025-02-06 23:16AugustoMauchStatusnew => scheduled
2025-02-06 23:20hgbotMerge Request Status => open
2025-02-06 23:20hgbotNote Added: 0175243
2025-02-11 15:42hgbotMerge Request Statusopen => approved
2025-02-11 15:43hgbotResolutionopen => fixed
2025-02-11 15:43hgbotStatusscheduled => closed
2025-02-11 15:43hgbotFixed in Version => PR25Q2
2025-02-11 15:43hgbotNote Added: 0175484
2025-02-11 15:43hgbotNote Added: 0175485
2025-02-13 13:06javietxeRelationship addedrelated to 0057981

Notes
(0171732)
AugustoMauch   
2024-11-10 22:55   
IƱaki, can you elaborate the steps to reproduce, please?
(0172721)
alostale   
2024-11-28 13:59   
Lowering severity to minor as it doesn't have other known impact than error messages in logs.
(0175088)
javietxe   
2025-02-04 10:03   
The only steps to reproduce that we have is:

Do an install sources
Create a new client
Delete clients installed in the sampledata


By now it's happening at least in 4 clients
(0175243)
hgbot   
2025-02-06 23:20   
Merge Request created: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/merge_requests/1525 [^]
(0175484)
hgbot   
2025-02-11 15:43   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo [^]
Changeset: c93cc699d16fda9d9a4e4e07fd1bd0d39fbb7850
Author: Augusto Mauch <a.mauch@orisha.com>
Date: 11-02-2025 14:43:04
URL: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/commit/c93cc699d16fda9d9a4e4e07fd1bd0d39fbb7850 [^]

Fixes ISSUE-57008: Wrong insert happening in some environments

The problem was that when a client was deleted, the process scheduled for that client were not unscheduled and deleted. As a
consequence, when it was time to run those scheduled jobs, an entry would be created in AD_PROCESS_RUN, resulting in an error
because the client entry would no longer exist

---
M src/org/openbravo/service/system/SystemService.java
---
(0175485)
hgbot   
2025-02-11 15:43   
Merge request merged: https://gitlab.com/orisha-group/bu-commerce/openbravo/product/openbravo/-/merge_requests/1525 [^]