Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056932Retail ModulesWeb POSpublic2024-10-29 16:592024-11-16 09:59
Reportermalsasua 
Assigned ToRajesh_18 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR25Q1 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056932: Overpayment is not checked before to add the payment
Descriptionif you configure a payment method with overpayment limit, the payment is added although the overpayment limit is reached
Steps To ReproduceBO:
. Touchpoint Type: Credit Card:
  - Payment provider: Legacy Payment Provider
  - Overpayment / Change Limit: 0

POS
. add Adhesive body warmers: total ticket 3.60
. click in total button -> payment tab opened
. Card: 5 -> enter button -> Payment using card was added with 5 -> Overpayment not available message is displayed, but the payment was added
Proposed Solution. the payment should not be added informing the overpayment is not available similar as works with Group Provider payment methods
. Attached a video with the expected behavior (CreditCard payment with Group Provider)
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0056967RR24Q4 closed Rajesh_18 Overpayment is not checked before to add the payment 
Attached Filespng overpayment.png (117,588) 2024-10-29 16:59
https://issues.openbravo.com/file_download.php?file_id=20398&type=bug
png

? Screencast from 04-11-24 15:59:44.webm (4,130,057) 2024-11-04 18:20
https://issues.openbravo.com/file_download.php?file_id=20416&type=bug
Issue History
Date ModifiedUsernameFieldChange
2024-10-29 16:59malsasuaNew Issue
2024-10-29 16:59malsasuaAssigned To => Retail
2024-10-29 16:59malsasuaFile Added: overpayment.png
2024-10-29 16:59malsasuaOBNetwork customer => No
2024-10-29 16:59malsasuaTriggers an Emergency Pack => No
2024-11-04 16:05migueldejuanaStatusnew => scheduled
2024-11-04 16:05migueldejuanaAssigned ToRetail => Rajesh_18
2024-11-04 18:20malsasuaProposed Solution updated
2024-11-04 18:20malsasuaFile Added: Screencast from 04-11-24 15:59:44.webm
2024-11-09 06:09hgbotMerge Request Status => open
2024-11-09 06:09hgbotNote Added: 0171719
2024-11-09 06:09hgbotNote Added: 0171720
2024-11-16 09:59hgbotMerge Request Statusopen => approved
2024-11-16 09:59hgbotResolutionopen => fixed
2024-11-16 09:59hgbotStatusscheduled => closed
2024-11-16 09:59hgbotFixed in Version => RR25Q1
2024-11-16 09:59hgbotNote Added: 0172107
2024-11-16 09:59hgbotNote Added: 0172108
2024-11-16 09:59hgbotNote Added: 0172109
2024-11-16 09:59hgbotNote Added: 0172110

Notes
(0171719)
hgbot   
2024-11-09 06:09   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1770 [^]
(0171720)
hgbot   
2024-11-09 06:09   
Merge Request created: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/437 [^]
(0172107)
hgbot   
2024-11-16 09:59   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 49cc39afd762c6dd8dca98593ea0276812d1da91
Author: Rajesh Senthilkumar <r.senthilkumar@external.orisha.com>
Date: 16-11-2024 08:59:18
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/49cc39afd762c6dd8dca98593ea0276812d1da91 [^]

Fixed ISSUE-56932: Overpayment should be checked before adding the payment
Added a function to check overpayment limit

---
M web/org.openbravo.retail.posterminal/js/components/modalprovidergroup.js
M web/org.openbravo.retail.posterminal/js/components/paymentvalidation.js
---
(0172108)
hgbot   
2024-11-16 09:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1770 [^]
(0172109)
hgbot   
2024-11-16 09:59   
Repository: https://gitlab.com/openbravo/ci/mobile-test [^]
Changeset: 4e470373107cfda8036bbe3b51b374689941da3c
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 12-11-2024 12:46:30
URL: https://gitlab.com/openbravo/ci/mobile-test/-/commit/4e470373107cfda8036bbe3b51b374689941da3c [^]

Related to ISSUE-56932: Refactored overpayment tests

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/payment/I39726_VerifyNoErrorWithAndWithoutOverpayments.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/payment/I39974_VerifyOverpaymentWith2DifferentPaymentMethods.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31791_CheckingErrorMsgInOverpayment.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36977_VerifyOverpaymentEvaluation.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I36994_OverpaymentLimitWithDecimalSeparatorDoesNotWork.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31842_VerifyOverpaymentByLimit.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32826_VerifyOverpaymentByCashCard.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I32826_VerifyOverpaymentByCashCardII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33324_VerifyOverpaymentByCash.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I36974_VerifyOverpaymentByLimitAfterRefresh.java
---
(0172110)
hgbot   
2024-11-16 09:59   
Merge request merged: https://gitlab.com/openbravo/ci/mobile-test/-/merge_requests/437 [^]