Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0056868Openbravo ERPA. Platformpublic2024-10-23 11:022024-10-23 14:22
cberner 
cberner 
normalmajorhave not tried
closedfixed 
5
 
 
Core
No
0056868: [API change] Removal of Register module field, button, columns and related code
Register module is no longer useful, because the endpoint has been removed/disabled in Central Repository, now it is meant to be done through forge.openbravo.com.

As such, part of the API has changed:
Database changes:
 * Removed columns:
   - AD_MODULE.ISREGISTERED
   - AD_MODULE_INSTALL.ISREGISTERED

 * Removed several rows:
   - AD_COLUMN (Register Module) - ID: 59D47C703D99BCCFE040007F0100439B
   - AD_COLUMN (Register Module) - ID: 682633A6E6A49D31E040007F010061E4
   - AD_DATASET_COLUMN - ID: 086A405EA5D811DD88C3001B388C61A4
   - AD_ELEMENT (Register Module) - ID: 59D46A26C1FABF9FE040007F010054FA
   - AD_FIELD (Register Module) - ID: 59D388C6AF9CDD4EE040007F010043D6
   - OBUIAPP_PARAMETER (user field) - ID: 3F1CCFDE0AE14887AAA68AB1D6A1283F
   - OBUIAPP_PARAMETER (password field) - ID: D0B5AAAA264049D18FD799D9062A11A1
   - OBUIAPP_PROCESS (login register module process) - ID: EBC24A55293F4E4BAF56EF8DFA43D578


Java API changes:
 - Removed class org.openbravo.client.application.businesslogic.RegisterModuleActionHandler
 - Removed field org.openbravo.model.ad.module.Module.PROPERTY_REGISTERMODULE
 - Removed field org.openbravo.model.ad.module.ModuleInstall.PROPERTY_REGISTERMODULE
 - Removed method org.openbravo.model.ad.module.Module.isRegisterModule()
 - Removed method org.openbravo.model.ad.module.Module.setRegisterModule(java.lang.Boolean)
 - Removed method org.openbravo.model.ad.module.ModuleInstall.isRegisterModule()
 - Removed method org.openbravo.model.ad.module.ModuleInstall.setRegisterModule(java.lang.Boolean)
 - Removed field org.openbravo.service.centralrepository.CentralRepository.Service.REGISTER_MODULE
-
Approved
Issue History
2024-10-23 11:02cbernerNew Issue
2024-10-23 11:02cbernerAssigned To => cberner
2024-10-23 11:02cbernerModules => Core
2024-10-23 11:02cbernerTriggers an Emergency Pack => No
2024-10-23 11:04cbernerAssigned Tocberner => alostale
2024-10-23 11:05cbernerDescription Updatedbug_revision_view_page.php?rev_id=28653#r28653
2024-10-23 11:05cbernerDescription Updatedbug_revision_view_page.php?rev_id=28654#r28654
2024-10-23 12:06alostaleTag Attached: Approved
2024-10-23 12:06alostaleAssigned Toalostale => cberner
2024-10-23 12:52hgbotNote Added: 0170824
2024-10-23 14:22hgbotResolutionopen => fixed
2024-10-23 14:22hgbotStatusnew => closed
2024-10-23 14:22hgbotNote Added: 0170830
2024-10-23 14:22hgbotNote Added: 0170831

Notes
(0170824)
hgbot   
2024-10-23 12:52   
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/79 [^]
(0170830)
hgbot   
2024-10-23 14:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: a009f58f32b449e8c1b305f08284ce92f1eea1ac
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 23-10-2024 12:53:04
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/a009f58f32b449e8c1b305f08284ce92f1eea1ac [^]

Fixes ISSUE-56868: Removal of Register module field, button, columns and related code

Database changes:
 * Removed columns:
   - AD_MODULE.ISREGISTERED
   - AD_MODULE_INSTALL.ISREGISTERED

 * Removed several rows:
   - AD_COLUMN (Register Module) - ID: 59D47C703D99BCCFE040007F0100439B
   - AD_COLUMN (Register Module) - ID: 682633A6E6A49D31E040007F010061E4
   - AD_DATASET_COLUMN - ID: 086A405EA5D811DD88C3001B388C61A4
   - AD_ELEMENT (Register Module) - ID: 59D46A26C1FABF9FE040007F010054FA
   - AD_FIELD (Register Module) - ID: 59D388C6AF9CDD4EE040007F010043D6
   - OBUIAPP_PARAMETER (user field) - ID: 3F1CCFDE0AE14887AAA68AB1D6A1283F
   - OBUIAPP_PARAMETER (password field) - ID: D0B5AAAA264049D18FD799D9062A11A1
   - OBUIAPP_PROCESS (login register module process) - ID: EBC24A55293F4E4BAF56EF8DFA43D578

Java API changes:
 - Removed class org.openbravo.client.application.businesslogic.RegisterModuleActionHandler
 - Removed field org.openbravo.model.ad.module.Module.PROPERTY_REGISTERMODULE
 - Removed field org.openbravo.model.ad.module.ModuleInstall.PROPERTY_REGISTERMODULE
 - Removed method org.openbravo.model.ad.module.Module.isRegisterModule()
 - Removed method org.openbravo.model.ad.module.Module.setRegisterModule(java.lang.Boolean)
 - Removed method org.openbravo.model.ad.module.ModuleInstall.isRegisterModule()
 - Removed method org.openbravo.model.ad.module.ModuleInstall.setRegisterModule(java.lang.Boolean)
 - Removed field org.openbravo.service.centralrepository.CentralRepository.Service.REGISTER_MODULE

---
M java/reference/java.japi.gz
M model/modules/org.openbravo.client.application/src-db/database/sourcedata/OBUIAPP_PARAMETER.xml
M model/modules/org.openbravo.client.application/src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M model/src-db/database/model/tables/AD_MODULE.xml
M model/src-db/database/model/tables/AD_MODULE_INSTALL.xml
M model/src-db/database/model/triggers/AD_MODULE_DBPREFIX_TRG.xml
M model/src-db/database/model/triggers/AD_MODULE_TRG.xml
M model/src-db/database/model/triggers/AD_MODULE_TRG2.xml
M model/src-db/database/model/triggers/AD_SYSTEM_INFO_TRG2.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_DATASET_COLUMN.xml
M model/src-db/database/sourcedata/AD_ELEMENT.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0170831)
hgbot   
2024-10-23 14:22   
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/79 [^]