Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056845POS2POSpublic2024-10-21 12:112025-01-15 10:56
Reporterasier_perez 
Assigned ToRajesh_18 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Togorka_gil
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056845: [24Q4] Activating the SelectAttachedSafeboxToCount user action allows to attach a safe box to more than one terminal
DescriptionWith the SelectAttachedSafeboxToCount user action activated, it is possible to attach a safe box to more than one terminal. The user action should affect only to Count Safe Box, not to the safe box attachment.
Steps To ReproduceConfiguration
1) Log in backoffice
2) Go to Safe Box window
3) Create a new record with the following values
  - Organization: Vall Blanca Store
  - Commercial Name: Vall Blanca Safe Box 01
  - Search Key: VBSB01
  - User for Safe Box: empty
  - Active: checked
4) Go to Financial Account window
5) Create a new record with the following values
  - Organization: Vall Blanca Store
  - Name: Cash - Vallblanca Safe Box 01
  - Currency: EUR
  - Type: Cash
6) Return to Safe Box window and go to the Payment Method subtab of the record created in step 3
7) Create a new record with the following values
  - Financial Account: Cash - Vallblanca Safe Box 01 - EUR
  - Payment Method: Cash
  - Cash: checked
  - Count Cash: checked
8) Go to Channel - Touchpoint Type
9) Open POS2SD VBS POS2 Terminal Type
10) Activate the following checkboxes and save
  - Use Safe Box
  - Safe Box mandatory
11) In the Payment Method subtab, open the Cash record and activate this checkbox: Defined in Safebox, then save
12) Go to Role window
13) Select VallBlancaUser and go to the User Action Access subtab
14) Create a new record with the following values:
  - User Action: SelectAttachedSafeboxToCount
  - Active: checked
  - Approval: Can Use

Reproducing the issue
1) Log in VBS-2 using vallblanca
2) Select the VBSB01 safe box
3) Without closing till, open another browser window and log in VBS-3 using vallblanca
4) Select the VBSB01 safe box => The safe box is attached to VBS-3 when it is already attached to VBS-2

Note: The same happens if the user action is defined with Approval Required. Furthermore, if you do step 1, then 3, then 2, and then 4, the approval dialog is skipped.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-10-21 12:11asier_perezNew Issue
2024-10-21 12:11asier_perezAssigned To => migueldejuana
2024-10-21 12:11asier_perezTriggers an Emergency Pack => No
2024-10-21 12:50migueldejuanaStatusnew => scheduled
2024-10-21 12:50migueldejuanaAssigned Tomigueldejuana => Rajesh_18
2024-10-24 06:25hgbotNote Added: 0170854
2024-12-19 15:57hgbotResolutionopen => fixed
2024-12-19 15:57hgbotStatusscheduled => closed
2024-12-19 15:57hgbotFixed in Version => 25Q1
2024-12-19 15:57hgbotNote Added: 0173529
2024-12-19 15:57hgbotNote Added: 0173530
2024-12-19 15:57hgbotNote Added: 0173531
2024-12-19 15:57hgbotNote Added: 0173532
2024-12-19 15:57hgbotNote Added: 0173533
2024-12-20 13:02hgbotNote Added: 0173558
2024-12-20 13:02hgbotNote Added: 0173559
2024-12-20 13:02hgbotNote Added: 0173560
2024-12-20 13:02hgbotNote Added: 0173561
2024-12-20 13:53gorka_gilNote Added: 0173566
2025-01-15 10:28jinigoNote Added: 0174185
2025-01-15 10:28jinigoStatusclosed => new
2025-01-15 10:28jinigoResolutionfixed => open
2025-01-15 10:28jinigoFixed in Version25Q1 =>
2025-01-15 10:56gorka_gilReview Assigned To => gorka_gil
2025-01-15 10:56gorka_gilNote Added: 0174187
2025-01-15 10:56gorka_gilStatusnew => closed
2025-01-15 10:56gorka_gilResolutionopen => no change required

Notes
(0170854)
hgbot   
2024-10-24 06:25   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3023 [^]
(0173529)
hgbot   
2024-12-19 15:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ad8f94a1ccb86cde3463b7e44a8fa43e1ec64334
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 19-12-2024 14:56:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ad8f94a1ccb86cde3463b7e44a8fa43e1ec64334 [^]

Fixed ISSUE-56845: If safe box is attached then it cannot be selected until its free

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/SelectDrawerStepMock.config.json
M web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/__test__/SafeboxHistory.test.jsx
M web-jspack/org.openbravo.pos2/src/components/SafeboxInitialCount/__test__/SafeboxInitialCount.test.jsx
---
(0173530)
hgbot   
2024-12-19 15:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3023 [^]
(0173531)
hgbot   
2024-12-19 15:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6c589ce609ffac2b82541300f2020fadec1fd3bf
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 19-12-2024 14:56:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6c589ce609ffac2b82541300f2020fadec1fd3bf [^]

Fixed ISSUE-56845: Confirmation pop up is shown to user when attached safebox is selected for initial count

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
---
(0173532)
hgbot   
2024-12-19 15:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 914eea8082c75f137e80e4cbbc3541b91dbe3ba5
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 19-12-2024 14:56:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/914eea8082c75f137e80e4cbbc3541b91dbe3ba5 [^]

Fixed ISSUE-56845: During safebox initial count attached safebox cannot be selected

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/SelectSafeboxToCount.js
---
(0173533)
hgbot   
2024-12-19 15:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1716aabe6d5e94e5ec7554030deda78ebb238d4b
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 19-12-2024 14:56:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1716aabe6d5e94e5ec7554030deda78ebb238d4b [^]

Fixed ISSUE-56845: Added extra validation for safebox selection and fixed jest test

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/__test__/SelectDrawerStep.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/SelectSafeboxToCount.js
---
(0173558)
hgbot   
2024-12-20 13:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9b572feaec29a5b248562a039b1e2fc25efd62b7
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 20-12-2024 17:29:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9b572feaec29a5b248562a039b1e2fc25efd62b7 [^]

Revert "Fixed ISSUE-56845: Added extra validation for safebox selection and fixed jest test"

This reverts commit 1716aabe6d5e94e5ec7554030deda78ebb238d4b.

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/__test__/SelectDrawerStep.test.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/SelectSafeboxToCount.js
---
(0173559)
hgbot   
2024-12-20 13:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d1d7bf043b0ca25ce69978304a76fad5870ba973
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 20-12-2024 17:30:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d1d7bf043b0ca25ce69978304a76fad5870ba973 [^]

Revert "Fixed ISSUE-56845: During safebox initial count attached safebox cannot be selected"

This reverts commit 914eea8082c75f137e80e4cbbc3541b91dbe3ba5.

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/SelectSafeboxToCount.js
---
(0173560)
hgbot   
2024-12-20 13:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 94fe8f621d8d70cefb9e6dc9e3d5bdee297d9d76
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 20-12-2024 17:30:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/94fe8f621d8d70cefb9e6dc9e3d5bdee297d9d76 [^]

Revert "Fixed ISSUE-56845: Confirmation pop up is shown to user when attached safebox is selected for initial count"

This reverts commit 6c589ce609ffac2b82541300f2020fadec1fd3bf.

---
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
---
(0173561)
hgbot   
2024-12-20 13:02   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c7aef61283ebd6d4ba3a162655a2498196dbbc6a
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 20-12-2024 17:31:35
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c7aef61283ebd6d4ba3a162655a2498196dbbc6a [^]

Revert "Fixed ISSUE-56845: If safe box is attached then it cannot be selected until its free"

This reverts commit ad8f94a1ccb86cde3463b7e44a8fa43e1ec64334.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/SelectDrawerStep.jsx
M web-jspack/org.openbravo.pos2/src/components/Cashup/mock/SelectDrawerStepMock.config.json
M web-jspack/org.openbravo.pos2/src/components/SafeboxHistory/__test__/SafeboxHistory.test.jsx
M web-jspack/org.openbravo.pos2/src/components/SafeboxInitialCount/__test__/SafeboxInitialCount.test.jsx
---
(0173566)
gorka_gil   
2024-12-20 13:53   
Reverted the fixes, because that appear an aproval and allow to select an attached safe box is correct.

The case that in a terminal is selected a safe box, that is in process of initial count in other terminal that is a problem.

And we will see how to fix it.
(0174185)
jinigo   
2025-01-15 10:28   
Changed to new as the fixing commits were reverted
(0174187)
gorka_gil   
2025-01-15 10:56   
From this development https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3180 [^]

Now there are two user actions, :
- 'Select Attached Safebox during Initial Count'
- 'Select Attached Safebox on Count Safebox Window'

So now can be adjust the permisions differently from the intial count and count.

Note: still a safebox can be attached to more than one terminal, it is intended for solve problems in the store, in the case that was a problem in the internet of a till or somthing similar, to allow the cashir that have the safe box with himself to attach to another till and overwritte that check, so the cashier can continue selling with his safe box. For that should be needed the store manager or similar that will have the permission to attach an already attached safe box.