Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056795Retail ModulesRetail APIpublic2024-10-15 16:532024-11-20 09:06
Reporterkchoperena 
Assigned Toguillermogil 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056795: Promotion API: Add the "Display Discount" fields in the POST and GET API
DescriptionWe should add the following fields (Window Discount and Promotions) to the API Promotion (POST/GET):

- Display Discount in Product Card
- Display Discount in Product Search and Browse
- Display Discount in Order Line When Not Applied
- Display Discount in Order Total When Not Applied
- Display Discount in Order Total
- Display Discount in Printed Product Label
Steps To ReproduceCheck in the swagger the schema for IMPORT/EXPORT of Promotion entity:
https://livebuilds.openbravo.com/context/retail_modules_pgsql_pi/api#/Promotion/Import_Promotion [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng image-20241004-125107.png (18,061) 2024-10-15 16:53
https://issues.openbravo.com/file_download.php?file_id=20322&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-10-15 16:53kchoperenaNew Issue
2024-10-15 16:53kchoperenaAssigned To => Retail
2024-10-15 16:53kchoperenaFile Added: image-20241004-125107.png
2024-10-15 16:53kchoperenaTriggers an Emergency Pack => No
2024-10-22 10:38jorgewederagoNote Added: 0170740
2024-11-12 16:12hgbotNote Added: 0171827
2024-11-12 16:17hgbotNote Added: 0171828
2024-11-13 05:43guillermogilAssigned ToRetail => guillermogil
2024-11-13 05:44guillermogilStatusnew => scheduled
2024-11-16 07:33hgbotNote Added: 0172070
2024-11-16 07:33hgbotNote Added: 0172071
2024-11-16 07:33hgbotResolutionopen => fixed
2024-11-16 07:33hgbotStatusscheduled => closed
2024-11-16 07:33hgbotNote Added: 0172072
2024-11-16 07:33hgbotNote Added: 0172073
2024-11-20 09:06hgbotNote Added: 0172298

Notes
(0170740)
jorgewederago   
2024-10-22 10:38   
Kepa, this should be reported as a Jira. Any FR should go through the standard process
(0171827)
hgbot   
2024-11-12 16:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.api/-/merge_requests/32 [^]
(0171828)
hgbot   
2024-11-12 16:17   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/merge_requests/9 [^]
(0172070)
hgbot   
2024-11-16 07:33   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api [^]
Changeset: dbcdfccb0178a3c0d04dd4756c1c556f5438cfa9
Author: Kepa Choperena <kepa.choperena@openbravo.com>
Date: 16-11-2024 06:33:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/commit/dbcdfccb0178a3c0d04dd4756c1c556f5438cfa9 [^]

Related to ISSUE-56795: Added the discount visibility option on Promotion mapping
* Display Discount in Printed Product Label: displayInPrintedProductLabel

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0172071)
hgbot   
2024-11-16 07:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.product.label.printing.api/-/merge_requests/9 [^]
(0172072)
hgbot   
2024-11-16 07:33   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.api [^]
Changeset: 64a2088339864d088ed8f111f1acac9412e6eca7
Author: Kepa Choperena <kepa.choperena@openbravo.com>
Date: 16-11-2024 06:33:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.api/-/commit/64a2088339864d088ed8f111f1acac9412e6eca7 [^]

Fixes ISSUE-56795: Added the discount visibility option on Promotion mapping
* Display Discount in Product Card: displayInProductCard
* Display Discount in Product Search and Browse: displayInSearchAndBrowse
* Display Discount in Order Line When Not Applied: displayInTicketLine
* Display Discount in Order Total When Not Applied: displayInTicketTotal
* Display Discount in Order Total: displayInTicketTotalApplied

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0172073)
hgbot   
2024-11-16 07:33   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.api/-/merge_requests/32 [^]
(0172298)
hgbot   
2024-11-20 09:06   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.api [^]
Changeset: 2cb29fd8ae163cb8b14b89ec18ef62c677beedab
Author: Guillermo Gil <g.gil@orisha.com>
Date: 20-11-2024 09:06:02
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.api/-/commit/2cb29fd8ae163cb8b14b89ec18ef62c677beedab [^]

Related to ISSUE-56795: Fixed DBCons

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---