Openbravo Issue Tracking System - Retail Modules |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0056788 | Retail Modules | Web POS | public | 2024-10-15 14:04 | 2024-12-09 15:48 |
|
| Reporter | malsasua | |
| Assigned To | meriem_azaf | |
| Priority | normal | Severity | major | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | approved |
| Review Assigned To | |
| OBNetwork customer | Gold |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0056788: Performance problem on KernelUtils.getModulesOrderedByDependency |
| Description | the function getModulesOrderedByDependency in KernelUtils is not efficient:
https://gitlab.com/openbravo/product/openbravo/-/blob/release/24Q4/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils.java?ref_type=heads#L275 [^]
This function is executed for each login, and when a lot of logins are done simultaneously after restart tomcat, it could cause a performance issue |
| Steps To Reproduce | restart tomcat and do multiple logins simultaneously |
| Proposed Solution | similar fix to
https://issues.openbravo.com/view.php?id=49546 [^] |
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2024-10-15 14:04 | malsasua | New Issue | |
| 2024-10-15 14:04 | malsasua | Assigned To | => Retail |
| 2024-10-15 14:04 | malsasua | OBNetwork customer | => Gold |
| 2024-10-15 14:04 | malsasua | Triggers an Emergency Pack | => No |
| 2024-10-15 17:07 | malsasua | Description Updated | bug_revision_view_page.php?rev_id=28593#r28593 |
| 2024-10-15 17:07 | malsasua | Steps to Reproduce Updated | bug_revision_view_page.php?rev_id=28595#r28595 |
| 2024-10-17 06:45 | guillermogil | Assigned To | Retail => Triage Platform Base |
| 2024-10-17 11:18 | AugustoMauch | Assigned To | Triage Platform Base => malsasua |
| 2024-10-17 11:19 | AugustoMauch | Note Added: 0170525 | |
| 2024-10-17 11:20 | AugustoMauch | Status | new => feedback |
| 2024-10-30 08:50 | malsasua | Note Added: 0171136 | |
| 2024-10-30 08:50 | malsasua | Note Deleted: 0171136 | |
| 2024-10-30 08:50 | malsasua | Note Added: 0171137 | |
| 2024-10-30 08:50 | malsasua | Status | feedback => new |
| 2024-11-18 12:04 | guillermogil | Assigned To | malsasua => Triage Platform Base |
| 2024-11-21 09:06 | malsasua | Note Added: 0172380 | |
| 2024-11-29 12:23 | AugustoMauch | Status | new => scheduled |
| 2024-11-29 12:23 | AugustoMauch | Assigned To | Triage Platform Base => meriem_azaf |
| 2024-11-29 15:35 | hgbot | Merge Request Status | => open |
| 2024-11-29 15:35 | hgbot | Note Added: 0172780 | |
| 2024-12-09 15:48 | hgbot | Merge Request Status | open => approved |
| 2024-12-09 15:48 | hgbot | Resolution | open => fixed |
| 2024-12-09 15:48 | hgbot | Status | scheduled => closed |
| 2024-12-09 15:48 | hgbot | Note Added: 0173077 | |
| 2024-12-09 15:48 | hgbot | Fixed in Version | => PR25Q1 |
| 2024-12-09 15:48 | hgbot | Note Added: 0173078 | |
|
Notes |
|
|
|
|
|
|
|
In the jstack, we saw dozens of threads halted during the process.
The issue occurred because Tomcat was restarted while the stores were open. As a result, when Tomcat started, a large number of login requests came in simultaneously. |
|
|
|
|
Checked with platform team: The KernelUtils.getModulesOrderedByDependency function is cached during the first login.
Possible root cause: If the function takes a few minutes to execute and a significant number of login requests arrive simultaneously after a Tomcat restart, it could result in all threads waiting at this point.
Possible fix: Cache the result of the function when Tomcat starts. While this might slow down the Tomcat startup process, it could prevent thread blockage during login bursts. |
|
|
|
(0172780)
|
|
hgbot
|
|
2024-11-29 15:35
|
|
|
|
|
(0173078)
|
|
hgbot
|
|
2024-12-09 15:48
|
|
Directly closing issue as related merge request is already approved.
Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: ef184b1dd931f9c2d4db10b49ea30b9d6216eef5
Author: meriem azaf <m.azaf@orisha.com>
Date: 09-12-2024 14:18:33
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/ef184b1dd931f9c2d4db10b49ea30b9d6216eef5 [^]
Fixes ISSUE-56788: Performance problem on KernelUtils.getModulesOrderedByDependency
The function getModulesOrderedByDependency in KernelUtils is not efficient,this function is executed for each login, and when a lot of logins are done simultaneously after restart tomcat, it could cause a performance issue.
To fix it, we change this function to be synchronized.
---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/KernelUtils.java
---
|
|
|
|
(0173077)
|
|
hgbot
|
|
2024-12-09 15:48
|
|
|