Openbravo Issue Tracking System - POS2
View Issue Details
0056775POS2POSpublic2024-10-14 10:382024-11-06 11:54
asier_perez 
Rajesh_18 
normalmajoralways
closedfixed 
5
pi 
24Q4 
QA functional test
2024-09-06
pi
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/ddc98f120e985f71306eb39fa5053f467ee8112e#66c9bed9c67f36a91669040765f05251d78e2f68 [^]
No
0056775: [24Q4] Closed gift cards still appear in POS and can be selected to pay a ticket
When a gift card is completely consumed, its state changes to 'closed', but now in POS they still appear, with a balance of 0, when searching for gift cards to pay a ticket. If a gift card is closed, it should not appear there anymore.

This does not happen in 24Q3 or previous releases.
1) Log in POS
2) Search for Gift Card 50€ product and select it
3) Type GC/001 in the identifier field and save
4) Complete the payment with Cash
5) Add Avalanche Transceiver to the ticket
6) Click Pay
7) Select Gift Cards/Certificates as payment method
8) Search for GC/001 and select
9) Click Done to complete the payment
10) Now that the gift card is consumed and closed, repeat steps 5-8 => The closed gift card still appears and can be selected
No tags attached.
blocks defect 0056765 closed Rajesh_18 [24Q4] Closed gift cards still appear in POS and can be selected to pay a ticket 
Issue History
2024-10-14 15:45guilleaerTypedefect => backport
2024-10-14 15:45guilleaerTarget Version => 24Q4
2024-10-14 15:46guilleaerRelationship addedduplicate of 0056774
2024-10-14 16:02guilleaerRelationship deleted0056774
2024-11-06 08:34hgbotNote Added: 0171474
2024-11-06 11:54hgbotNote Added: 0171522
2024-11-06 11:54hgbotResolutionopen => fixed
2024-11-06 11:54hgbotStatusscheduled => closed
2024-11-06 11:54hgbotNote Added: 0171523

Notes
(0171474)
hgbot   
2024-11-06 08:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/395 [^]
(0171522)
hgbot   
2024-11-06 11:54   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/395 [^]
(0171523)
hgbot   
2024-11-06 11:54   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 550d98f990867f05333021b80dc78f37b2fbcabc
Author: Rajesh Senthilkumar <rajesh@qualiantech.com>
Date: 06-11-2024 13:03:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/550d98f990867f05333021b80dc78f37b2fbcabc [^]

Fixed ISSUE-56775: Do not show closed gift cards during payment flow

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/GiftCardUtils.js
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/__test__/GiftCardUtils.test.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.retail.giftcards/src/services/scan/handlers/GiftCardScanEventHandler.js
---