Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056751POS2POSpublic2024-10-11 16:432024-10-25 10:14
ReportereliezerSotomayor 
Assigned ToeliezerSotomayor 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056751: OTF coupons generation should be configurable (Fully paid or Issue)[React]
DescriptionCurrent situation :
In case of activating prepayment feature :
OTF coupons are printed just after paying the deposit.
When paying the balance, the OTF coupon is not printed.


Global request :
Norauto would like to print the OTF coupon just after paying the balance, so the coupon should NOT be printed at the deposit step.

Please check the business requirement here for more information :
https://docs.google.com/document/d/169l2B5tHFpft2LgW3fLRwadVQEkUlGXMbbTXPfvIDYE/edit [^]
Steps To ReproduceSee description.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
causes defect 0057071 closed sreehari While adding a discount coupon to a ticket with an identified client, the transaction is blocked by an error. 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-10-11 16:43eliezerSotomayorNew Issue
2024-10-11 16:43eliezerSotomayorAssigned To => eliezerSotomayor
2024-10-11 16:43eliezerSotomayorOBNetwork customer => No
2024-10-11 16:43eliezerSotomayorTriggers an Emergency Pack => No
2024-10-11 16:44eliezerSotomayorStatusnew => scheduled
2024-10-11 16:55hgbotMerge Request Status => open
2024-10-11 16:55hgbotNote Added: 0170307
2024-10-25 09:58hgbotNote Added: 0170944
2024-10-25 10:08hgbotMerge Request Statusopen => approved
2024-10-25 10:14hgbotResolutionopen => fixed
2024-10-25 10:14hgbotStatusscheduled => closed
2024-10-25 10:14hgbotNote Added: 0170946
2024-10-25 10:14hgbotNote Added: 0170947
2024-10-25 10:14hgbotNote Added: 0170948
2024-10-25 10:14hgbotNote Added: 0170949
2024-11-13 10:44sreehariRelationship addedcauses 0057071

Notes
(0170307)
hgbot   
2024-10-11 16:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/63 [^]
(0170944)
hgbot   
2024-10-25 09:58   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/172 [^]
(0170946)
hgbot   
2024-10-25 10:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: 352468b17a4e59f7dc4b2c39176645a674a43f37
Author: Eliezer Sotomayor <e.sotomayor@orisha.com>
Date: 25-10-2024 08:14:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/352468b17a4e59f7dc4b2c39176645a674a43f37 [^]

Fixed ISSUE-56751: [RM-15933] Add configuration to OTF coupons generation (Fully paid or Issue)

---
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/CouponsOTFIssueTicketActionPreparation.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/CouponsOTFIssueTicketPostHook.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/CouponsOTFIssueTicketPreHook.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/__test__/CouponsOTFCompleteTicketActionPreparation.test.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/__test__/CouponsOTFCompleteTicketPostHook.test.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/__test__/CouponsOTFCompleteTicketPreHook.test.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/__test__/CouponsOTFIssueTicketActionPreparation.test.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/__test__/CouponsOTFIssueTicketPostHook.test.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/__test__/CouponsOTFIssueTicketPreHook.test.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/AddCouponsPrintMessagesToState.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/AddCreatedCouponsToPayload.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/UpdateTicketWithOTFCoupons.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/__test__/AddCouponsPrintMessagesToState.test.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/__test__/AddCreatedCouponsToPayload.test.js
A web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/utils/__test__/UpdateTicketWithOTFCoupons.test.js
M src-db/database/model/tables/OBCPOTF_COUPONRULES.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/discounts/coupons/otf/master/CouponrulesProperties.java
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/GlobalExtension.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/CouponsOTFCompleteTicketActionPreparation.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/CouponsOTFCompleteTicketPostHook.js
M web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/actions/CouponsOTFCompleteTicketPreHook.js
R web-jspack/org.openbravo.retail.discounts.coupons.otf/src/model/global/__test__/CouponsOTFCompleteTicketActionPreparation.test.js
---
(0170947)
hgbot   
2024-10-25 10:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/63 [^]
(0170948)
hgbot   
2024-10-25 10:14   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^]
Changeset: 1eec4af3410f749a1e6f3375694c10f52f38b01b
Author: Eliezer Sotomayor <e.sotomayor@orisha.com>
Date: 25-10-2024 08:14:33
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/1eec4af3410f749a1e6f3375694c10f52f38b01b [^]

Related to ISSUE-56751: [RM-15933] Add Issuance Time to sampledata

---
M referencedata/sampledata/The_White_Valley_Group/OBCPOTF_COUPONRULES.xml
---
(0170949)
hgbot   
2024-10-25 10:14   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/merge_requests/172 [^]