Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0005674Openbravo ERPA. Platformpublic2008-10-27 12:282009-04-21 11:09
pnuding 
shuehner 
highmajorhave not tried
closedfixed 
5all
pi 
2.50 
Core
No
0005674: Audit for missing to_number in XSQL for Postgresql from v8.3 and excessive to_number in ID fields
Since version 8.3 Postgresql does not automatically convert strings to numeric values anymore, but requires the call of to_number for this.
There are many places where we currently miss this call, meaning the affected numeric filters etc. only work on Oracle but not on Postgres
In addition some old to_number calls are in place for ID fields which are now no longer appropriate as the IDs are alphanumeric.

A code inspection is needed and agreed by Paolo Juvara to proactively find and resolve all of these issues:
Go trough all manual code (.xsql files in src-wad, src-trl and src).
For each
- check each parameter whether it its target (column) is numeric and add to_number
- look at existing occurences of to_number - if these point to an id-field remove it

Please trigger the necessary steps (I understand some of this is already ongoing) and derive sub-issues as you see it as appropriate
Attached is a list of excessive to_number occurrences for ID fields kindly provided by Stefan Hühner. He can also be contacted for further questions
UUID project
related to feature request 0006698 closed shuehner Partial list of broken/not useful xsql methods which are currently not used 
related to defect 0006630 closed shuehner OrderLine Selector filter fields: business partner & product are broken when selector is opened with salesOrders only filter 
related to defect 0006631 closed shuehner Invoice selector: Filter field Order does not work with non numeric-only input 
related to defect 0006634 closed shuehner Financial Management || Receivables & Payables || Analysis Tools || Cash Report || Cash Report > Cashbook filter is broken 
related to defect 0006643 closed shuehner Create AP Expense Invoices process does not work correctly when run with newly created user (having non-numeric user_id) 
related to defect 0006644 closed shuehner Remittance cancellation & Remittance return processes do not work 
related to defect 0006653 closed shuehner Payment Tracker; Filter fiels Amount From & Amount to do not work on postgresql 8.3 
related to defect 0006656 closed shuehner Payment Report: Filter fiels Amount From & Amount to do not work on postgresql 8.3 
related to defect 0006660 closed shuehner General Ledger Report, Filter field: From Amount does not work on postgresql 8.3 
related to defect 0006662 closed shuehner Order Line selector: Field field "Total Amount From" does not work on postgresql 8.3 
related to defect 0006664 closed shuehner Order selector: Field field "Total Amount From" does not work on postgresql 8.3 
related to defect 0006688 closed AinhoaPagola Shipment in -> Create From Multiple Popup -> OK, error reporting does not work 
related to defect 0006690 closed shuehner Warehouse Management || Transactions || Incoming Shipment || Shipment in ->Create From Multiple Popup does not work on pgsql 8.3 
related to defect 0006693 closed rafaroda CreateFromMultipleShipment_data.xsql - method insert does not work with uuid 
txt list.txt (1,911) 2008-10-27 12:28
https://issues.openbravo.com/file_download.php?file_id=357&type=bug
Issue History
2008-10-27 12:28pnudingNew Issue
2008-10-27 12:28pnudingAssigned To => cromero
2008-10-27 12:28pnudingsf_bug_id0 => 2200509
2008-10-27 12:28pnudingFile Added: list.txt
2008-10-27 12:28pnudingRegression testing => No
2008-10-27 14:36shuehnerIssue Monitored: shuehner
2008-11-03 11:39rafarodaTarget Versiontrunk => 2.50
2008-11-03 11:39rafarodaTag Attached: UUID project
2008-11-03 11:43rafarodaStatusnew => scheduled
2008-11-03 11:43rafarodaAssigned Tocromero => shuehner
2008-11-03 11:43rafarodafix_in_branch => trunk
2008-12-03 19:03pjuvaraPrioritynormal => high
2008-12-19 16:33shuehnerRelationship addedrelated to 0006698
2008-12-19 16:33shuehnerRelationship addedrelated to 0006630
2008-12-19 16:33shuehnerRelationship addedrelated to 0006631
2008-12-19 16:33shuehnerRelationship addedrelated to 0006634
2008-12-19 16:33shuehnerRelationship addedrelated to 0006643
2008-12-19 16:33shuehnerRelationship addedrelated to 0006644
2008-12-19 16:33shuehnerRelationship addedrelated to 0006653
2008-12-19 16:34shuehnerRelationship addedrelated to 0006656
2008-12-19 16:34shuehnerRelationship addedrelated to 0006660
2008-12-19 16:34shuehnerRelationship addedrelated to 0006662
2008-12-19 16:34shuehnerRelationship addedrelated to 0006664
2008-12-19 16:34shuehnerRelationship addedrelated to 0006688
2008-12-19 16:34shuehnerRelationship addedrelated to 0006690
2008-12-19 16:34shuehnerRelationship addedrelated to 0006693
2008-12-19 16:38shuehnerStatusscheduled => resolved
2008-12-19 16:38shuehnersvn_revision => 11417
2008-12-19 16:38shuehnerResolutionopen => fixed
2008-12-19 16:38shuehnerNote Added: 0011611
2009-01-09 17:48shuehnerIssue End Monitor: shuehner
2009-04-21 11:09psarobeStatusresolved => closed

Notes
(0011611)
shuehner   
2008-12-19 16:38   
One review of all .xsql files has been done and a number of issues was identified and reported. All issues have been marked as related to this one so they can be tracked easily.