Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056733POS2POSpublic2024-08-29 07:292024-10-15 08:30
Reportersreehari 
Assigned Tosreehari 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version24Q3.2Fixed in Version24Q3.2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket56248
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056733: POS2 - While editing the customer form the save button is always enabled even without mandatory fields
DescriptionSave Button is enabled without filling the Mandatory fields
Steps To Reproduce1. In the POS 2 open the "Customers" screen.
2. Select a customer, for example VBS Customer.
3. Return to the "Sell" screen, click on the Customer -> View Info -> Edit.
4. Check the save button is enabled without mandatory fields.
5. Save and Close.
Proposed SolutionSave Button should be disabled first and enabled only after the mandatory fields are filled
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0056315 closed sreehari POS2 - While editing the customer form the save button is always enabled even without mandatory fields 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-10-10 13:03marvintmTypedefect => backport
2024-10-10 13:03marvintmTarget Version => 24Q3.2
2024-10-14 09:27hgbotNote Added: 0170330
2024-10-14 09:28hgbotNote Added: 0170335
2024-10-15 08:30hgbotNote Added: 0170394
2024-10-15 08:30hgbotNote Added: 0170395
2024-10-15 08:30hgbotResolutionopen => fixed
2024-10-15 08:30hgbotStatusscheduled => closed
2024-10-15 08:30hgbotFixed in Version => 24Q3.2
2024-10-15 08:30hgbotNote Added: 0170396
2024-10-15 08:30hgbotNote Added: 0170397

Notes
(0170330)
hgbot   
2024-10-14 09:27   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1612 [^]
(0170335)
hgbot   
2024-10-14 09:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2991 [^]
(0170394)
hgbot   
2024-10-15 08:30   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 07743f780a56a3648d6b0639627ec5823a061f4c
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 14-10-2024 12:29:06
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/07743f780a56a3648d6b0639627ec5823a061f4c [^]

Related ISSUE-56733: Added disabledLabel prop for StandardButton

---
M web-jspack/org.openbravo.core2/src/components/ResponsiveToolbar/ResponsiveToolbar.jsx
---
(0170395)
hgbot   
2024-10-15 08:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1612 [^]
(0170396)
hgbot   
2024-10-15 08:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b4d89371524efcbd9ab5c1f0aa0de59a1b543dc2
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 14-10-2024 12:56:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b4d89371524efcbd9ab5c1f0aa0de59a1b543dc2 [^]

Fixes ISSUE-56733: Disabled Save Button when Mandatory Fields are not filled

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/customerForm.int.spec.js
M web-jspack/org.openbravo.pos2/src/components/Customer/CustomerMultiTabDialog/CustomerMultiTabDialogForm/CustomerMultiTabDialogForm.jsx
---
(0170397)
hgbot   
2024-10-15 08:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2991 [^]