Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056719POS2POSpublic2024-10-09 21:332024-10-25 06:14
Reporterlmonreal 
Assigned ToSABARINATH P 
PriorityhighSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056719: Copy Store adding Organization name in payment methods financial accounts
DescriptionCopy Store adding Organization name in payment methods financial accounts


I have a template store that has for example the following name for a payment method financial account 002401- Cash and I launch copy store.

The store copied will have the following payment method financial account XXXXX- Cash - NAME OF NEW STORE

This NAME OF NEW STORE should not be there, copy store should just replace, not add.
Steps To Reproduce1. Have a Template store that has not Organization name in payment methods financial accounts(see screenshot)
2. Launch a copy store
3. See the Terminals of the new organization have the Organization name in the payment method financial accounts
Proposed SolutionCopy store should just replace. The organization name should not be in the payment methods financial accounts
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng VALLBOI.png (158,501) 2024-10-09 21:33
https://issues.openbravo.com/file_download.php?file_id=20265&type=bug
png

png VALLTEST.png (160,522) 2024-10-09 21:33
https://issues.openbravo.com/file_download.php?file_id=20266&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-10-09 21:33lmonrealNew Issue
2024-10-09 21:33lmonrealAssigned To => Retail
2024-10-09 21:33lmonrealFile Added: VALLBOI.png
2024-10-09 21:33lmonrealOBNetwork customer => Gold
2024-10-09 21:33lmonrealTriggers an Emergency Pack => No
2024-10-09 21:33lmonrealFile Added: VALLTEST.png
2024-10-17 12:25guillermogilSeveritymajor => minor
2024-10-18 08:08migueldejuanaAssigned ToRetail => SABARINATH P
2024-10-18 08:08migueldejuanaStatusnew => scheduled
2024-10-22 11:25SABARINATH PNote Added: 0170749
2024-10-22 11:25SABARINATH PStatusscheduled => feedback
2024-10-22 12:56lmonrealNote Added: 0170755
2024-10-22 14:46SABARINATH PStatusfeedback => scheduled
2024-10-23 11:20hgbotMerge Request Status => open
2024-10-23 11:20hgbotNote Added: 0170811
2024-10-25 06:14hgbotMerge Request Statusopen => approved
2024-10-25 06:14hgbotResolutionopen => fixed
2024-10-25 06:14hgbotStatusscheduled => closed
2024-10-25 06:14hgbotNote Added: 0170918
2024-10-25 06:14hgbotNote Added: 0170919

Notes
(0170749)
SABARINATH P   
2024-10-22 11:25   
I think this was not an issue, because the cloned organisation's financial account format will be same as parent organisation's financial account format. For example, if vallBoi organisation have financial account in the format of POS2SD Credit Card - Vall Boi - Vall Boí Store - EUR (payment method - organisation name - currency) then its cloned or copy store will also have same format. I think this was happening in this line.

https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/blob/master/src/org/openbravo/retail/copystore/process/CopyStoreProcess.java#L416 [^]
(0170755)
lmonreal   
2024-10-22 12:56   
Hello, see the Template organization does not have the organization name in the financial account.
See screenshot 1, FA: POS2 CREDIT CARD-EUR but for the store copied, the financial accounts are POS2 CREDIT CARD-NAME OF OR- EUR
(0170811)
hgbot   
2024-10-23 11:20   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/84 [^]
(0170918)
hgbot   
2024-10-25 06:14   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore [^]
Changeset: 8717658d0700374ee05f4c18fc025aa52573ec25
Author: Sabarinath <s.palanisamy@external.orisha.com>
Date: 24-10-2024 11:08:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/commit/8717658d0700374ee05f4c18fc025aa52573ec25 [^]

Fixed ISSUE-56719: Financial account cloned in similar way to the original store.

---
M src/org/openbravo/retail/copystore/process/CopyStoreProcess.java
M src/org/openbravo/retail/copystore/process/CopyTerminalProcess.java
---
(0170919)
hgbot   
2024-10-25 06:14   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.copystore/-/merge_requests/84 [^]