Openbravo Issue Tracking System - POS2
View Issue Details
0056692POS2POSpublic2024-10-08 14:172025-01-10 09:06
dorian_robillard 
Bimla_vm 
normalminoralways
closedfixed 
5
 
25Q2 
Pre packaging ( pi )
2025-01-09
pi
https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5ee26b1ddfe51fc5f8da2d8d4c23ab0410678d1c [^]
No
0056692: VIP price : ‘display discount in order line when not apply’ is not working in POS
When the ‘display discount in order line when not apply’ field is ticked in the BO, the ‘lack’ of promotion does not appear on the ticket line on the POS, unlike the ‘display discount in order total when not apply’ field, which is correctly applied on the POS
Create a promotion "Price adjustment"
set "price adjustment for all products"
Percentage 20%
Min 3
Boolean"‘display discount in order line when not apply’ selected
Boolean"‘display discount in order total when not apply’ selected

In pos Add one product --> the display is not done at line level
No tags attached.
related to defect 0056937 closed Retail POS2 Discounts Visibility some problems 
related to defect 0057397 closed Bimla_vm POS2 VIP price : Product planned in the future is considered as promotion missing 
depends on backport 005760325Q1 closed Bimla_vm POS2 VIP price : ‘display discount in order line when not apply’ is not working in POS 
caused by feature request 0055872 closed gaboflash Retail Modules Add a new API similar to the currently existing Discounts API to get the discounts visibility feature 
has duplicate defect 0057446 closed Retail POS2 Promotions not applied are not displayed in the POS lines 
png Capture d’écran 2024-10-08 141444.png (60,174) 2024-10-08 14:17
https://issues.openbravo.com/file_download.php?file_id=20254&type=bug
png

png Capture d’écran 2024-10-08 141828.png (33,663) 2024-10-08 14:18
https://issues.openbravo.com/file_download.php?file_id=20255&type=bug
png
Issue History
2024-10-08 14:17dorian_robillardNew Issue
2024-10-08 14:17dorian_robillardAssigned To => Retail
2024-10-08 14:17dorian_robillardFile Added: Capture d’écran 2024-10-08 141444.png
2024-10-08 14:17dorian_robillardTriggers an Emergency Pack => No
2024-10-08 14:18dorian_robillardFile Added: Capture d’écran 2024-10-08 141828.png
2024-11-08 08:38guilleaerAssigned ToRetail => guilleaer
2024-11-08 08:38guilleaerStatusnew => acknowledged
2024-11-08 09:38Bimla_vmAssigned Toguilleaer => Bimla_vm
2024-11-08 09:38Bimla_vmStatusacknowledged => scheduled
2024-11-11 09:56gorka_gilRelationship addedrelated to 0056937
2024-12-02 06:49hgbotNote Added: 0172850
2024-12-02 06:50hgbotNote Added: 0172851
2024-12-18 15:15guillermogilRelationship addedrelated to 0057397
2025-01-09 07:46Bimla_vmRegression level => Pre packaging ( pi )
2025-01-09 07:46Bimla_vmRegression date => 2025-01-09
2025-01-09 07:46Bimla_vmRegression introduced in release => pi
2025-01-09 07:46Bimla_vmRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5ee26b1ddfe51fc5f8da2d8d4c23ab0410678d1c [^]
2025-01-09 15:40hgbotNote Added: 0173951
2025-01-09 15:45guillermogilStatusscheduled => acknowledged
2025-01-09 15:46guillermogilStatusacknowledged => scheduled
2025-01-09 18:00hgbotResolutionopen => fixed
2025-01-09 18:00hgbotStatusscheduled => closed
2025-01-09 18:00hgbotFixed in Version => 25Q2
2025-01-09 18:00hgbotNote Added: 0173962
2025-01-09 18:00hgbotNote Added: 0173963
2025-01-10 09:06gorka_gilRelationship addedcaused by 0055872
2025-01-21 12:56gorka_gilRelationship addedhas duplicate 0057446

Notes
(0172850)
hgbot   
2024-12-02 06:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3185 [^]
(0172851)
hgbot   
2024-12-02 06:50   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/159 [^]
(0173951)
hgbot   
2025-01-09 15:40   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/159 [^]
(0173962)
hgbot   
2025-01-09 18:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: b4b26e3fd05f183bfc74c795d45cd31b6947407a
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 09-01-2025 17:00:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/b4b26e3fd05f183bfc74c795d45cd31b6947407a [^]

Fixed ISSUE-56692: fix discounts visibility

- ticket line: send productId instead id
- overwrite getDiscountValues and calculateShortLabel
since they called inside the main method, and needs the discount from cache,
instead the discount that returns the main method of discounts visibility
- use formatCurrency instead OB.I18N.formatCurrency, to have the currency symbol
- adapt tests

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDiscount/TicketLineDiscount.jsx
M web-jspack/org.openbravo.pos2/src/core/discount/__test__/registerDiscountVisibilityPosFunctions.test.js
M web-jspack/org.openbravo.pos2/src/core/discount/registerDiscountVisibilityPosFunctions.js
---
(0173963)
hgbot   
2025-01-09 18:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3185 [^]