Openbravo Issue Tracking System - POS2
View Issue Details
0056640POS2POSpublic2024-09-27 09:222024-10-07 12:56
javietxe 
Bimla_vm 
normalmajorhave not tried
closedfixed 
5
 
24Q424Q4 
No
0056640: Sales unit factor and decimals
We have detected some problems with the sales unit factor development and the usage of decimals
1- Wrong warning at ticket line level
Steps to reproduce

In the backoffice, go to the product tab and set a products Sales Unit Factor field to 0.3
Make all other configurations to make the product available at POS2 sale point
Log into a POS2 terminal
Add a unit of the product
Click on the order line
In the popover, use the + and - signs to set the quantity to 0.9
It displays the correct qty, but on the ticket line it displays a warning telling you that the sales factor multiple is not satisfied


2- Error when adding with + or - buttons

In the backoffice, go to the product tab and set a products Sales Unit Factor field to 0.3
Make all other configurations to make the product available at POS2 sale point
Log into a POS2 terminal
Add a unit of the product
Click on the order line
In the popover, use the + and - signs to set the quantity to 0.9
Then try to go back to 0.6, it doesn’t let you do it. (it is actually adjusting the qty by 1.1^-16, so the amount is really small)


3- Error when inserting a valid amount
Steps to reproduce

In the backoffice, go to the product tab and set a products Sales Unit Factor field to 5.55
Make all other configurations to make the product available at POS2 sale point
Log into a POS2 terminal
Add a unit of the product
Click on the order line
In the popover, Click on the Qty input
In the next keypad, insert 16.65 as the amount
Click on the OK button
The next dialog will ask you to use 16.65 or 22.2 as the closes multiples for the inserted number

Expected behaviour

It should not prompt the last dialog, as the inserted value is an actual multiple of the sales unit factor.
No tags attached.
related to defect 0057377 closed Bimla_vm [24Q4] Set Sales Unit Factor in a product induces that product can not be added to the ticket 
blocks defect 0056570 closed Bimla_vm Sales unit factor and decimals 
Issue History
2024-10-03 12:56marvintmTypedefect => backport
2024-10-03 12:56marvintmTarget Version => 24Q4
2024-10-07 12:51hgbotNote Added: 0170048
2024-10-07 12:56hgbotResolutionopen => fixed
2024-10-07 12:56hgbotStatusscheduled => closed
2024-10-07 12:56hgbotFixed in Version => 24Q4
2024-10-07 12:56hgbotNote Added: 0170049
2024-10-07 12:56hgbotNote Added: 0170050
2024-10-16 16:07javietxeRelationship addedrelated to 0056809
2024-10-16 16:29javietxeRelationship deletedrelated to 0056809
2024-12-05 18:28lorenzofidalgoRelationship addedrelated to 0057377

Notes
(0170048)
hgbot   
2024-10-07 12:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2972 [^]
(0170049)
hgbot   
2024-10-07 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8088f1c9bece0b67bd0c2063b35da6a79344e1d9
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 07-10-2024 16:14:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8088f1c9bece0b67bd0c2063b35da6a79344e1d9 [^]

Fixed ISSUE-56640: Handled decimal sales unit factor

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLineSalesUnitFactorQuantity/TicketLineSalesUnitFactorQuantityUtils.js
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLineSalesUnitFactorQuantity/__test__/TicketLineSalesUnitFactorQuantity.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSalesUnitFactorMessage.jsx
---
(0170050)
hgbot   
2024-10-07 12:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2972 [^]