Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056629POS2POSpublic2024-10-02 19:552024-10-28 22:30
Reportergaboflash 
Assigned Togaboflash 
PrioritynormalSeverityminorReproducibilityN/A
StatusscheduledResolutionopen 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056629: Enhance drawer opening behavior in POS2 by introducing new options based on payment method configuration
DescriptionCurrently, the drawer in POS2 opens by clicking the "OPEN" button on the payment screen if the checkbox "Open Drawer Before Closing Ticket" is set to TRUE on the payment method.

This functionality aims to automate this process by introducing a new combobox field in the "Touchpoint Type > Payment Method" section called "Drawer Opening Behavior" that will only be visible if the "Allow Open Drawer" option is enabled. Default value for this setting will be "Never Automatically Open Drawer". This allows cashiers more flexibility and improve checkout speed by eliminating the need to manually open the drawer in specific workflows.
Steps To ReproduceN/A
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-10-02 19:55gaboflashNew Issue
2024-10-02 19:55gaboflashAssigned To => gaboflash
2024-10-02 19:55gaboflashTriggers an Emergency Pack => No
2024-10-10 08:24hgbotNote Added: 0170227
2024-10-10 08:24hgbotNote Added: 0170228
2024-10-22 05:26hgbotNote Added: 0170733
2024-10-22 05:28hgbotNote Added: 0170734
2024-10-22 05:29hgbotNote Added: 0170735
2024-10-28 07:08hgbotResolutionopen => fixed
2024-10-28 07:08hgbotStatusnew => closed
2024-10-28 07:08hgbotFixed in Version => RR25Q1
2024-10-28 07:08hgbotNote Added: 0170979
2024-10-28 07:08hgbotNote Added: 0170980
2024-10-28 07:08hgbotNote Added: 0170981
2024-10-28 07:08hgbotNote Added: 0170982
2024-10-28 07:08hgbotNote Added: 0170983
2024-10-28 07:08hgbotFixed in VersionRR25Q1 => 25Q1
2024-10-28 07:08hgbotNote Added: 0170984
2024-10-28 07:08hgbotNote Added: 0170985
2024-10-28 07:08hgbotNote Added: 0170986
2024-10-28 07:08hgbotNote Added: 0170987
2024-10-28 07:08hgbotNote Added: 0170988
2024-10-28 07:08hgbotNote Added: 0170989
2024-10-28 07:08hgbotNote Added: 0170990
2024-10-28 07:08hgbotNote Added: 0170991
2024-10-28 07:08hgbotNote Added: 0170992
2024-10-28 07:08hgbotNote Added: 0170993
2024-10-28 07:54hgbotNote Added: 0170996
2024-10-28 07:55hgbotNote Added: 0170997
2024-10-28 07:56hgbotNote Added: 0170998
2024-10-28 07:56hgbotNote Added: 0170999
2024-10-28 07:57hgbotNote Added: 0171000
2024-10-28 07:59marvintmStatusclosed => new
2024-10-28 07:59marvintmResolutionfixed => open
2024-10-28 07:59marvintmFixed in Version25Q1 =>
2024-10-28 07:59marvintmStatusnew => scheduled
2024-10-28 08:16hgbotNote Added: 0171001
2024-10-28 21:31hgbotNote Added: 0171064
2024-10-28 21:32hgbotNote Added: 0171065
2024-10-28 21:35hgbotNote Added: 0171066
2024-10-28 22:29hgbotNote Added: 0171067
2024-10-28 22:30hgbotNote Added: 0171068

Notes
(0170227)
hgbot   
2024-10-10 08:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1707 [^]
(0170228)
hgbot   
2024-10-10 08:24   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2980 [^]
(0170733)
hgbot   
2024-10-22 05:26   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/104 [^]
(0170734)
hgbot   
2024-10-22 05:28   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/merge_requests/15 [^]
(0170735)
hgbot   
2024-10-22 05:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/121 [^]
(0170979)
hgbot   
2024-10-28 07:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: e835056fc4ffb328e03f74b2d2d3e6a5400f9b5a
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 28-10-2024 06:07:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/e835056fc4ffb328e03f74b2d2d3e6a5400f9b5a [^]

Fixes ISSUE-56629: Enhanced drawer opening behavior in POS2 by introducing new options based on payment method configuration

---
A build/classes/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior.class
A build/classes/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehaviorData.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior.java
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior_data.xsql
M src-db/database/model/tables/OBPOS_APP_PAYMENT_TYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src/org/openbravo/retail/posterminal/Invoices.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
M web-test/model/business-object/ticket/actions/AddPaymentRounding.test.js
M web-test/model/business-object/ticket/actions/ReversePayment-actionPreparation.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/AddPaymentUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteMultiTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0170980)
hgbot   
2024-10-28 07:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1707 [^]
(0170981)
hgbot   
2024-10-28 07:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 5289f3ece42f6fe520f210e43f7e466e2dd623e6
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 28-10-2024 06:07:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/5289f3ece42f6fe520f210e43f7e466e2dd623e6 [^]

Fixes ISSUE-56629: Fix module script and revert unnecessary changes

---
M build/classes/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior.class
M build/classes/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehaviorData.class
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior.java
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior_data.xsql
M src/org/openbravo/retail/posterminal/Invoices.java
M src/org/openbravo/retail/posterminal/PaidReceipts.java
---
(0170982)
hgbot   
2024-10-28 07:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: b823f96b00470121202e4233f17e8cec27db8d4e
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 28-10-2024 06:07:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/b823f96b00470121202e4233f17e8cec27db8d4e [^]

Fixes ISSUE-56629: Fix UX requirements

---
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
---
(0170983)
hgbot   
2024-10-28 07:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: ca7ab1624da22abf8b2a41fefa364fad2b19a7af
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 28-10-2024 06:07:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/ca7ab1624da22abf8b2a41fefa364fad2b19a7af [^]

Fixes ISSUE-56629: Fix drawer opening behavior based on payment method configuration

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0170984)
hgbot   
2024-10-28 07:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 65b831f2c58578c1886be8cafc1c64f012155489
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 25-10-2024 17:59:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/65b831f2c58578c1886be8cafc1c64f012155489 [^]

Fixes ISSUE-56629: Enhanced drawer opening behavior in POS2 by introducing new options based on payment method configuration

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/__test__/PaymentKeypad.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddPayment.js
---
(0170985)
hgbot   
2024-10-28 07:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 82f2b5cc2825197881d959482880e3fb9c85a7ef
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 25-10-2024 17:59:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/82f2b5cc2825197881d959482880e3fb9c85a7ef [^]

Fixes ISSUE-56629: Handled errors in OpenDrawer action and prevent AddPayment cancellation. Also updated Jest tests

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddPayment.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddPayment.js
---
(0170986)
hgbot   
2024-10-28 07:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2980 [^]
(0170987)
hgbot   
2024-10-28 07:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2b5f0b14d57a1e024636d07a7179cee0087221f6
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 25-10-2024 17:59:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2b5f0b14d57a1e024636d07a7179cee0087221f6 [^]

Fixes ISSUE-56629: Prevents automatically reopen drawer at the ticket completes

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
---
(0170989)
hgbot   
2024-10-28 07:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/104 [^]
(0170988)
hgbot   
2024-10-28 07:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^]
Changeset: 7462f4e3ea0453eaa6e3c5f9d3a3e036e9abc908
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 25-10-2024 17:58:55
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/7462f4e3ea0453eaa6e3c5f9d3a3e036e9abc908 [^]

Related to ISSUE-56629: Update payment method definitions

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---
(0170990)
hgbot   
2024-10-28 07:08   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata [^]
Changeset: 7b499146a21d522e5151cc1e39c3ad7701047c9d
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 22-10-2024 00:23:48
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/commit/7b499146a21d522e5151cc1e39c3ad7701047c9d [^]

Related to ISSUE-56629: Update payment method definitions

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---
(0170991)
hgbot   
2024-10-28 07:08   
Merge request merged: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/merge_requests/15 [^]
(0170992)
hgbot   
2024-10-28 07:08   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: e261fb41509353f20412af15f55f9ebfe0c7dd6a
Author: Gabriel Lopez <gabriel.lopez@doceleguas.com>
Date: 22-10-2024 00:23:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/e261fb41509353f20412af15f55f9ebfe0c7dd6a [^]

Related to ISSUE-56629: Update payment method definitions

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---
(0170993)
hgbot   
2024-10-28 07:08   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/121 [^]
(0170996)
hgbot   
2024-10-28 07:54   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 821a9ddeaf505fdb1fa54a4236973c954cb12f69
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 28-10-2024 07:53:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/821a9ddeaf505fdb1fa54a4236973c954cb12f69 [^]

Related to ISSUE-56629: Revert changes as they would affect integration

---
M src-db/database/model/tables/OBPOS_APP_PAYMENT_TYPE.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/AD_REF_LIST.xml
M web-test/model/business-object/ticket/actions/AddPaymentRounding.test.js
M web-test/model/business-object/ticket/actions/ReversePayment-actionPreparation.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/AddPaymentUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteMultiTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/CompleteTicketUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior.java
R src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior_data.xsql
---
(0170997)
hgbot   
2024-10-28 07:55   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: e242fa05c0cd19bd427411624cc00fa7e2cfe6bb
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 28-10-2024 07:55:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e242fa05c0cd19bd427411624cc00fa7e2cfe6bb [^]

Related to ISSUE-56629: Revert changes as they would affect integration

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/__test__/PaymentKeypad.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddPayment.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddPayment.js
---
(0170998)
hgbot   
2024-10-28 07:56   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^]
Changeset: 4c01e52eacc9b19de41e35f30c1e90842e2716d2
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 28-10-2024 07:56:09
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/4c01e52eacc9b19de41e35f30c1e90842e2716d2 [^]

Related to ISSUE-56629: Revert changes as they would affect integration

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---
(0170999)
hgbot   
2024-10-28 07:56   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata [^]
Changeset: 3faa50fdad11807aa39bce452513fe98259f9746
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 28-10-2024 07:56:49
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/commit/3faa50fdad11807aa39bce452513fe98259f9746 [^]

Related to ISSUE-56629: Revert changes as they would affect integration

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---
(0171000)
hgbot   
2024-10-28 07:57   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^]
Changeset: f322042a254b0904bcbf6217f4da60544f740dfb
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 28-10-2024 07:57:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/f322042a254b0904bcbf6217f4da60544f740dfb [^]

Related to ISSUE-56629: Revert changes as they would affect integration

---
M referencedata/sampledata/The_White_Valley_Group/OBPOS_APP_PAYMENT_TYPE.xml
---
(0171001)
hgbot   
2024-10-28 08:16   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 04dc977fc0dbfe2adac9fefc8ae15fbb5751c721
Author: Antonio Moreno <antonio.moreno@openbravo.com>
Date: 28-10-2024 08:16:36
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/04dc977fc0dbfe2adac9fefc8ae15fbb5751c721 [^]

Related to ISSUE-56629: Revert changes as they would affect integration

---
R build/classes/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehavior.class
R build/classes/org/openbravo/retail/posterminal/modulescript/UpdateOpenDrawerBehaviorData.class
---
(0171064)
hgbot   
2024-10-28 21:31   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3035 [^]
(0171065)
hgbot   
2024-10-28 21:32   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/109 [^]
(0171066)
hgbot   
2024-10-28 21:35   
Merge Request created: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.giftcards.pos2-sampledata/-/merge_requests/16 [^]
(0171067)
hgbot   
2024-10-28 22:29   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1742 [^]
(0171068)
hgbot   
2024-10-28 22:30   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/123 [^]