Openbravo Issue Tracking System - POS2
View Issue Details
0056570POS2POSpublic2024-09-27 09:222024-10-07 09:56
javietxe 
Bimla_vm 
normalmajorhave not tried
closedfixed 
5
 
25Q1 
No
0056570: Sales unit factor and decimals
We have detected some problems with the sales unit factor development and the usage of decimals
1- Wrong warning at ticket line level
Steps to reproduce

In the backoffice, go to the product tab and set a products Sales Unit Factor field to 0.3
Make all other configurations to make the product available at POS2 sale point
Log into a POS2 terminal
Add a unit of the product
Click on the order line
In the popover, use the + and - signs to set the quantity to 0.9
It displays the correct qty, but on the ticket line it displays a warning telling you that the sales factor multiple is not satisfied


2- Error when adding with + or - buttons

In the backoffice, go to the product tab and set a products Sales Unit Factor field to 0.3
Make all other configurations to make the product available at POS2 sale point
Log into a POS2 terminal
Add a unit of the product
Click on the order line
In the popover, use the + and - signs to set the quantity to 0.9
Then try to go back to 0.6, it doesn’t let you do it. (it is actually adjusting the qty by 1.1^-16, so the amount is really small)


3- Error when inserting a valid amount
Steps to reproduce

In the backoffice, go to the product tab and set a products Sales Unit Factor field to 5.55
Make all other configurations to make the product available at POS2 sale point
Log into a POS2 terminal
Add a unit of the product
Click on the order line
In the popover, Click on the Qty input
In the next keypad, insert 16.65 as the amount
Click on the OK button
The next dialog will ask you to use 16.65 or 22.2 as the closes multiples for the inserted number

Expected behaviour

It should not prompt the last dialog, as the inserted value is an actual multiple of the sales unit factor.
No tags attached.
depends on backport 005664024Q4 closed Bimla_vm Sales unit factor and decimals 
related to defect 0056809 closed Bimla_vm Sales factor unit with decimals 
Issue History
2024-09-27 09:22javietxeNew Issue
2024-09-27 09:22javietxeAssigned To => Retail
2024-09-27 09:22javietxeTriggers an Emergency Pack => No
2024-09-27 09:31marvintmProjectRetail Modules => POS2
2024-09-27 09:31marvintmCategoryWeb POS => POS
2024-09-27 09:40guillermogilStatusnew => acknowledged
2024-09-27 11:29Bimla_vmAssigned ToRetail => Bimla_vm
2024-09-27 11:30Bimla_vmStatusacknowledged => scheduled
2024-10-03 12:56marvintmStatusscheduled => acknowledged
2024-10-03 12:56marvintmStatusacknowledged => scheduled
2024-10-04 08:34hgbotNote Added: 0169981
2024-10-07 09:56hgbotResolutionopen => fixed
2024-10-07 09:56hgbotStatusscheduled => closed
2024-10-07 09:56hgbotFixed in Version => 25Q1
2024-10-07 09:56hgbotNote Added: 0170035
2024-10-07 09:56hgbotNote Added: 0170036
2024-10-16 16:29javietxeRelationship addedrelated to 0056809

Notes
(0169981)
hgbot   
2024-10-04 08:34   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2966 [^]
(0170035)
hgbot   
2024-10-07 09:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 43c77aa64127b6bb1b6cf36e5f44a930a0295505
Author: Bimla Mayavan <b.mayavan@external.orisha.com>
Date: 07-10-2024 04:56:10
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/43c77aa64127b6bb1b6cf36e5f44a930a0295505 [^]

Fixed ISSUE-56570: Handled decimal sales unit factor

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLineSalesUnitFactorQuantity/TicketLineSalesUnitFactorQuantityUtils.js
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLineSalesUnitFactorQuantity/__test__/TicketLineSalesUnitFactorQuantity.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSalesUnitFactorMessage.jsx
---
(0170036)
hgbot   
2024-10-07 09:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2966 [^]