Openbravo Issue Tracking System - POS2
View Issue Details
0056504POS2POSpublic2024-09-19 13:222024-11-14 11:15
fermin_ostivar 
cberner 
normalminoralways
closedfixed 
5
 
pi 
approved
No
No
0056504: Session expired never is closed
There are expired sessions that never are closed even when the session limit is near to be reached and the cleaning mechanism run.
1) Login in AWO with the following url:
https://livebuilds.openbravo.com/context/retail_translations_pgsql/web/org.openbravo.warehouse.advancedwarehouseoperations [^]

2) In the same tab type and go to the url:
https://livebuilds.openbravo.com/context/retail_translations_pgsql/security/Login [^] (the main part to reproduce the scenario is to add security/Login to the url)

If the system is near to reach the session limit the method to close the expired sessions run but not closed the previous one, throwing the error "not found in context"

The issue happens in a single instance environment
To close the session that have expired in all cases
No tags attached.
Issue History
2024-09-19 13:22fermin_ostivarNew Issue
2024-09-19 13:22fermin_ostivarAssigned To => Retail
2024-09-19 13:22fermin_ostivarOBNetwork customer => No
2024-09-19 13:22fermin_ostivarTriggers an Emergency Pack => No
2024-09-20 07:20guillermogilAssigned ToRetail => Triage Platform Base
2024-10-21 09:01AugustoMauchAssigned ToTriage Platform Base => cberner
2024-10-25 18:16axelmercadoIssue Monitored: axelmercado
2024-10-28 11:38hgbotMerge Request Status => open
2024-10-28 11:38hgbotNote Added: 0171031
2024-10-28 12:04AugustoMauchStatusnew => scheduled
2024-10-28 15:51PracticsIssue Monitored: Practics
2024-10-29 12:46hgbotMerge Request Statusopen => approved
2024-11-04 12:12hgbotResolutionopen => fixed
2024-11-04 12:12hgbotStatusscheduled => closed
2024-11-04 12:12hgbotFixed in Version => PR25Q1
2024-11-04 12:12hgbotNote Added: 0171284
2024-11-04 12:12hgbotNote Added: 0171285
2024-11-05 12:08hgbotNote Added: 0171406
2024-11-05 12:09cbernerNote Added: 0171407
2024-11-05 12:09cbernerStatusclosed => new
2024-11-05 12:09cbernerResolutionfixed => open
2024-11-05 12:09cbernerFixed in VersionPR25Q1 =>
2024-11-11 09:29hgbotNote Added: 0171743
2024-11-14 11:15hgbotResolutionopen => fixed
2024-11-14 11:15hgbotStatusnew => closed
2024-11-14 11:15hgbotFixed in Version => PR25Q1
2024-11-14 11:15hgbotNote Added: 0171972
2024-11-14 11:15hgbotNote Added: 0171973

Notes
(0171031)
hgbot   
2024-10-28 11:38   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1411 [^]
(0171284)
hgbot   
2024-11-04 12:12   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: b001fba0f9bd8c8d62ffffea125187b3d42015ec
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 04-11-2024 09:59:11
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/b001fba0f9bd8c8d62ffffea125187b3d42015ec [^]

Fixes ISSUE-56504: Expired session is never closed

When using AWO and then logging in into openbravo on the same
domain/url, the AWO session was left as inactive but still part of the
context list, however the context list was not actually being checked
for session destroyal. Now sessions are destroyed if the session is
present in the context but are no longer active, because that means
they're created on the same cluster node, and not on another node.

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/erpCommon/security/SessionListener.java
---
(0171285)
hgbot   
2024-11-04 12:12   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1411 [^]
(0171406)
hgbot   
2024-11-05 12:08   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: da4496f13915dff313c13b748a1d047043eb47b1
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 05-11-2024 12:07:30
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/da4496f13915dff313c13b748a1d047043eb47b1 [^]

Revert "Fixes ISSUE-56504: Expired session is never closed"

This reverts commit b001fba0f9bd8c8d62ffffea125187b3d42015ec.

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/erpCommon/security/SessionListener.java
---
(0171407)
cberner   
2024-11-05 12:09   
Reopened due to it being reverted.
(0171743)
hgbot   
2024-11-11 09:29   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1430 [^]
(0171972)
hgbot   
2024-11-14 11:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 48cce2a03b12f6d81f2a2aa534b492994812ea19
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 14-11-2024 10:05:18
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/48cce2a03b12f6d81f2a2aa534b492994812ea19 [^]

Fixes ISSUE-56504: Expired session is never closed

When using AWO and then logging in into openbravo on the same
domain/url, the AWO session was left as inactive but still part of the
context list, however the context list was not actually being checked
for session destroyal. Now sessions are destroyed if the session is
present in the context but are no longer active, because that means
they're created on the same cluster node, and not on another node.

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/erpCommon/security/SessionListener.java
---
(0171973)
hgbot   
2024-11-14 11:15   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/1430 [^]