Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056501POS2POSpublic2024-09-19 10:552025-01-17 12:59
Reportergorka_gil 
Assigned Tosreehari 
PrioritynormalSeveritymajorReproducibilityN/A
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version25Q2 
Merge Request Statusapproved
Review Assigned Togorka_gil
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056501: AddProduct user action should get an array of products instead of one product
DescriptionAddProduct state action already work with an array of products, but the user action only support one product.

This is wrong since if you need to add many products in one operation, breaks the transactionality having to do one by one.

An example of this problem can be seen in this issue: https://issues.openbravo.com/view.php?id=56415 [^] that should be fixed after.

It is needed to change the user action to work with an array of products instead one product, and fix all the prehooks, posthooks and calls to the user action
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0056415 closed OriolLeon Combos: warning using the DisplayUpselingMessage 
blocks feature request 0057164 new Retail Multiple addProduct: product configuration 
blocks feature request 0057165 new Retail Multiple addProduct: check stock 
blocks feature request 0057166 new Retail Multiple addProduct: product contribution 
blocks feature request 0057580 new Retail Multiple addProduct: multiple scan 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-09-19 10:55gorka_gilNew Issue
2024-09-19 10:55gorka_gilAssigned To => Retail
2024-09-19 10:55gorka_gilOBNetwork customer => No
2024-09-19 10:55gorka_gilTriggers an Emergency Pack => No
2024-09-19 10:56gorka_gilSummaryAddProduct user action should support an array of products => AddProduct user action should get an array of products instead of one product
2024-09-19 10:57gorka_gilDescription Updatedbug_revision_view_page.php?rev_id=28474#r28474
2024-09-19 13:39gorka_gilRelationship addedblocks 0056415
2024-09-19 15:20gorka_gilIssue Monitored: gorka_gil
2024-09-19 15:20gorka_gilIssue End Monitor: gorka_gil
2024-09-20 10:28gorka_gilAssigned ToRetail => sreehari
2024-09-26 13:21sreehariDescription Updatedbug_revision_view_page.php?rev_id=28508#r28508
2024-09-30 09:12sreehariStatusnew => scheduled
2024-10-19 08:00hgbotMerge Request Status => open
2024-10-19 08:00hgbotNote Added: 0170594
2024-10-19 08:02hgbotNote Added: 0170595
2024-10-19 08:03hgbotNote Added: 0170596
2024-10-19 08:03hgbotNote Added: 0170597
2024-10-19 08:04hgbotNote Added: 0170598
2024-11-15 21:12hgbotNote Added: 0172060
2024-11-18 18:10gorka_gilRelationship addedblocks 0057164
2024-11-18 18:27gorka_gilRelationship addedblocks 0057165
2024-11-18 18:52gorka_gilRelationship addedblocks 0057166
2024-12-18 15:16guilleaerReview Assigned To => guilleaer
2024-12-18 15:16guilleaerNote Added: 0173448
2024-12-18 15:16guilleaerStatusscheduled => closed
2024-12-18 15:16guilleaerResolutionopen => suspended
2024-12-18 15:16hgbotNote Added: 0173449
2024-12-18 16:06guilleaerStatusclosed => new
2024-12-18 16:06guilleaerResolutionsuspended => open
2024-12-18 16:06guilleaerStatusnew => scheduled
2024-12-18 17:53gorka_gilReview Assigned Toguilleaer => gorka_gil
2025-01-07 14:02hgbotNote Added: 0173867
2025-01-07 18:27gorka_gilRelationship addedblocks 0057580
2025-01-17 11:59hgbotMerge Request Statusopen => approved
2025-01-17 12:53hgbotResolutionopen => fixed
2025-01-17 12:53hgbotStatusscheduled => closed
2025-01-17 12:53hgbotFixed in Version => RR25Q2
2025-01-17 12:53hgbotNote Added: 0174280
2025-01-17 12:53hgbotNote Added: 0174281
2025-01-17 12:56hgbotFixed in VersionRR25Q2 => 25Q2
2025-01-17 12:56hgbotNote Added: 0174282
2025-01-17 12:56hgbotNote Added: 0174283
2025-01-17 12:56hgbotNote Added: 0174284
2025-01-17 12:56hgbotNote Added: 0174285
2025-01-17 12:56hgbotNote Added: 0174286
2025-01-17 12:56hgbotNote Added: 0174287
2025-01-17 12:56hgbotNote Added: 0174288
2025-01-17 12:56hgbotNote Added: 0174289
2025-01-17 12:56hgbotNote Added: 0174290
2025-01-17 12:56hgbotNote Added: 0174291
2025-01-17 12:56hgbotNote Added: 0174292
2025-01-17 12:56hgbotNote Added: 0174293
2025-01-17 12:56hgbotNote Added: 0174294
2025-01-17 12:56hgbotNote Added: 0174295
2025-01-17 12:56hgbotNote Added: 0174296
2025-01-17 12:56hgbotNote Added: 0174297
2025-01-17 12:56hgbotNote Added: 0174298
2025-01-17 12:56hgbotNote Added: 0174299
2025-01-17 12:57hgbotNote Added: 0174300
2025-01-17 12:57hgbotNote Added: 0174301
2025-01-17 12:57hgbotNote Added: 0174302
2025-01-17 12:57hgbotNote Added: 0174303
2025-01-17 12:57hgbotNote Added: 0174304
2025-01-17 12:57hgbotNote Added: 0174305
2025-01-17 12:59hgbotNote Added: 0174306
2025-01-17 12:59hgbotNote Added: 0174307
2025-01-17 12:59hgbotNote Added: 0174308
2025-01-17 12:59hgbotNote Added: 0174309
2025-01-17 12:59hgbotNote Added: 0174310
2025-01-17 12:59hgbotNote Added: 0174311
2025-01-17 12:59hgbotNote Added: 0174312
2025-01-17 12:59hgbotNote Added: 0174313

Notes
(0170594)
hgbot   
2024-10-19 08:00   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3012 [^]
(0170595)
hgbot   
2024-10-19 08:02   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/304 [^]
(0170596)
hgbot   
2024-10-19 08:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/390 [^]
(0170597)
hgbot   
2024-10-19 08:03   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/merge_requests/27 [^]
(0170598)
hgbot   
2024-10-19 08:04   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/66 [^]
(0172060)
hgbot   
2024-11-15 21:12   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1783 [^]
(0173448)
guilleaer   
2024-12-18 15:16   
this module is no longer supported
(0173449)
hgbot   
2024-12-18 15:16   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/304 [^]
(0173867)
hgbot   
2025-01-07 14:02   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.multiupc/-/merge_requests/27 [^]
(0174280)
hgbot   
2025-01-17 12:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: f054c866ebc4ebf18bef4de7bace12933adfd55b
Author: Gorka Gil <go.gil@orisha.com>
Date: 17-01-2025 17:16:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/f054c866ebc4ebf18bef4de7bace12933adfd55b [^]

Fixes ISSUE-56501: add ticketLineGroupConditionsExtension

* Allow to register conditions to meet for group lines,
so other modules properties can be taken into account

* As part of support multiple products for addProduct user action

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/TicketUtils.js
---
(0174281)
hgbot   
2025-01-17 12:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1783 [^]
(0174283)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 400d8c95441db2af5196f81e6e49be0304745cd0
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/400d8c95441db2af5196f81e6e49be0304745cd0 [^]

Fixes ISSUE-56501: Changed payload for AddProduct ScanEventHandler

---
M web-jspack/org.openbravo.pos2/src/services/scan/handlers/utils/addProduct.js
---
(0174284)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: fdfa7d683f6b394689fd7e0ac3087ac08801d79f
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/fdfa7d683f6b394689fd7e0ac3087ac08801d79f [^]

Fixes ISSUE-56501: Changed payload for CrossStore AddProduct action

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
---
(0174282)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8b1a354f60c58358cec6b4ac7d823ec493117724
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8b1a354f60c58358cec6b4ac7d823ec493117724 [^]

Fixes ISSUE-56501: Changed generatePayload structure for Product Button
*updated addProduct hooks to handle new payload structure
*handled case to show product card during addProduct

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButton.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/OpenProductPopover.js
---
(0174285)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2149051ccc6dce4a7ed2272b5f7ec15823bc9e53
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2149051ccc6dce4a7ed2272b5f7ec15823bc9e53 [^]

Fixes ISSUE-56501: Updated addServiceProductValidation for AddServiceProduct

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddServiceProduct.js
---
(0174286)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: cb43619e007cfb5b19e8f7212320529ca39fde04
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/cb43619e007cfb5b19e8f7212320529ca39fde04 [^]

Fixes ISSUE-56501: Fixed product card popup issue due to new payload
*during right click on product button
*during product scan with product card config

---
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/OpenProductPopover.js
M web-jspack/org.openbravo.pos2/src/services/scan/handlers/ProductScanEventHandler.js
---
(0174287)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3e33798a6b559e7cd51b1bd246976c4ab6e10bac
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3e33798a6b559e7cd51b1bd246976c4ab6e10bac [^]

Fixes ISSUE-56501: Fixed SetLineQuantity action
*updated checkForLineDeletion hook to throw error properly

---
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
---
(0174288)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7946075305465ec23efbc8b11eba94975802763d
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7946075305465ec23efbc8b11eba94975802763d [^]

Fixes ISSUE-56501: Fixing Jest Test Failures
*fixed TicketLinePopover.test
*fixed ProductButton.test
*fixed SetLineQuantityButton.test
*fixed AddProduct.test
*fixed AddProductHooks.test
*fixed OpenProductPopover.test
*fixed LinesCreatorInfrastructure.test

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/__test__/ProductButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/__test__/TicketLinePopover.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/SetLineQuantityButton.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/LinesCreatorInfrastructure.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/AddProductHooks.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/__test__/OpenProductPopover.test.js
---
(0174289)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 02d4bf0e46e6b2dc2e26602875709e69d5546db6
Author: Gorka Gil <go.gil@orisha.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/02d4bf0e46e6b2dc2e26602875709e69d5546db6 [^]

Fixes ISSUE-56501: Fix schema ticket line indicator action preparation

Don't force the createNewLine if the product is not in the ticket,
to avoid break the grouping when adding many products in one addProduct action

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
---
(0174290)
hgbot   
2025-01-17 12:56   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3012 [^]
(0174293)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 92347f8db6c999d2d550674941729db61367f716
Author: Gorka Gil <go.gil@orisha.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/92347f8db6c999d2d550674941729db61367f716 [^]

Fixes ISSUE-56501: adapt tests for the refactor of schema grouping

since the logic was moved to the general line grouping, it is no longer
required to use the createNewLine. Adapted the tests to this change

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProductActionPreparation.test.js
---
(0174292)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: c5b7ace1d99b60938550de1b457461bc4d82ec20
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/c5b7ace1d99b60938550de1b457461bc4d82ec20 [^]

Fixes ISSUE-56501: Removed Unnecessary changes-Code Review
*fixed test failures

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
---
(0174291)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 6e710b5aadbeb84c6213f0be8d981b40da02339a
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/6e710b5aadbeb84c6213f0be8d981b40da02339a [^]

Fixes ISSUE-56501: Added Code Review Changes Points

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/OpenProductPopover.js
---
(0174294)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 2781a30ceddd44ea1ef871d07f9988eac2be984d
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/2781a30ceddd44ea1ef871d07f9988eac2be984d [^]

Fixes ISSUE-56501: Fixed prepareAddProductPayload qty value and created test
*fixed test failure

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
---
(0174295)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 045c379583551def3de6d1402b35b2ce6c324347
Author: Gorka Gil <go.gil@orisha.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/045c379583551def3de6d1402b35b2ce6c324347 [^]

Fixes ISSUE-56501: added a comment for an exception

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
---
(0174296)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 22543ec1ec10da3eb321c92312bc98a1da8741ff
Author: Gorka Gil <go.gil@orisha.com>
Date: 17-01-2025 17:24:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/22543ec1ec10da3eb321c92312bc98a1da8741ff [^]

Fixes ISSUE-56501: fixes for kits

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js
---
(0174297)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9cb93f9563a9306e2eeaf39119fc8d74ca1bf70b
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9cb93f9563a9306e2eeaf39119fc8d74ca1bf70b [^]

Fixes ISSUE-56501: Updated Copyright (c) Year 2025

---
M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButton.jsx
M web-jspack/org.openbravo.pos2/src/components/ProductButton/__test__/ProductButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/TicketLinePopover.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/__test__/TicketLinePopover.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/__test__/SetLineQuantityButton.test.jsx
M web-jspack/org.openbravo.pos2/src/model/ticket/LinesCreatorInfrastructure.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProduct.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProductActionPreparation.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddServiceProduct.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/AddProductHooks.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/OpenProductPopover.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/__test__/OpenProductPopover.test.js
M web-jspack/org.openbravo.pos2/src/services/scan/handlers/utils/addProduct.js
---
(0174298)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7337e1adcea7dd7ad4bbe1d9c928687fe81d3eeb
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7337e1adcea7dd7ad4bbe1d9c928687fe81d3eeb [^]

Fixes ISSUE-56501: Refactored OTF products user action payload

---
M web-jspack/org.openbravo.pos2/src/model/productOTF/user-actions/CreateContextOTFProduct.js
M web-jspack/org.openbravo.pos2/src/model/productOTF/user-actions/CreateOTFProduct.js
---
(0174299)
hgbot   
2025-01-17 12:56   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7354abfdd0420551c1091fd8109e86756c33ee96
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 17:24:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7354abfdd0420551c1091fd8109e86756c33ee96 [^]

Fixes ISSUE-56501: Updated addServiceToNonEditableTicket

---
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddServiceProduct.js
---
(0174303)
hgbot   
2025-01-17 12:57   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 9a637b4ce1d215c66eb437ed287d35d6397026d5
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-01-2025 22:51:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/9a637b4ce1d215c66eb437ed287d35d6397026d5 [^]

Related ISSUE-56501: Updated Copyright (c) Year 2025

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/user-actions/RefundGiftCard.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/RefundGiftCard.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/__test__/RefundGiftCard.test.js
---
(0174304)
hgbot   
2025-01-17 12:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 07b0415db54f0077d9ad6f4266cc511da31ffac6
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-01-2025 10:03:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/07b0415db54f0077d9ad6f4266cc511da31ffac6 [^]

Fixes ISSUE-56501: Refactored Gift Card Negetive Line Redemption
*fixed test failure

---
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/GiftCardPaymentProvider.js
M web-jspack/org.openbravo.retail.giftcards/src/components/PaymentIntegration/__test__/GiftCardPaymentProvider.test.js
---
(0174302)
hgbot   
2025-01-17 12:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 322b754c60dd65356d30852fce3c65556d607009
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-01-2025 22:51:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/322b754c60dd65356d30852fce3c65556d607009 [^]

Fixes ISSUE-56501: Code Review Changes

---
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/AddProductPostHook.js
---
(0174301)
hgbot   
2025-01-17 12:57   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 62a0e6e1b326fc91c00f3e8f81e327fdf690b535
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-01-2025 22:51:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/62a0e6e1b326fc91c00f3e8f81e327fdf690b535 [^]

Related ISSUE-56501: Fixed Refund Gift Card Case
*fixed RefundGiftCard.test

---
M web-jspack/org.openbravo.retail.giftcards/src/model/giftcard/user-actions/RefundGiftCard.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/RefundGiftCard.js
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/__test__/RefundGiftCard.test.js
---
(0174300)
hgbot   
2025-01-17 12:57   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards [^]
Changeset: 04732595eb73bea6ecdc355c29d996d299461eba
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 16-01-2025 22:51:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/commit/04732595eb73bea6ecdc355c29d996d299461eba [^]

Related ISSUE-56501: Updated addProduct Hooks for handling new structure

---
M web-jspack/org.openbravo.retail.giftcards/src/model/ticket/actions/AddProductPostHook.js
---
(0174305)
hgbot   
2025-01-17 12:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.giftcards/-/merge_requests/390 [^]
(0174306)
hgbot   
2025-01-17 12:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: b4deed14c0fad5b4c8ef664a19a8f2f995a016db
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 08-01-2025 14:51:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/b4deed14c0fad5b4c8ef664a19a8f2f995a016db [^]

Related ISSUE-56501: Handled user action with array of products

---
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/ApplyCombo.js
---
(0174307)
hgbot   
2025-01-17 12:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: fbe3d09d34a2a251932610ec4565f24114be652d
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 08-01-2025 14:51:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/fbe3d09d34a2a251932610ec4565f24114be652d [^]

Related ISSUE-56501: Updated Combo product actions to handle Product Array
*reduced the productDetails to update the qty instead of duplicate product
*fixed AddProductToCombo.test
*fixed ComboProductButtonQty.test

---
M web-jspack/org.openbravo.retail.discounts.combo/src/components/ComboProductButtonQty/CombotProductButtonQty.jsx
M web-jspack/org.openbravo.retail.discounts.combo/src/components/__test__/ComboProductButtonQty.test.jsx
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/__test__/AddProductToCombo.test.js
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/AddProductToCombo.js
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/ApplyCombo.js
---
(0174308)
hgbot   
2025-01-17 12:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: e5d60cf0755862700a2266c15065c4ba59c76a91
Author: Gorka Gil <go.gil@orisha.com>
Date: 08-01-2025 14:51:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/e5d60cf0755862700a2266c15065c4ba59c76a91 [^]

Related ISSUE-56501: do not group the lines of the combo

* To allow the grouping lines logic to do it
* Also fix the name of configuration propertie of product

---
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/ApplyCombo.js
---
(0174309)
hgbot   
2025-01-17 12:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: a6696df3636da7d899cc7d9c6d101be67201d2dc
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 08-01-2025 14:51:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/a6696df3636da7d899cc7d9c6d101be67201d2dc [^]

Related ISSUE-56501: Added Code Review Changes Points

---
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/ApplyCombo.js
---
(0174310)
hgbot   
2025-01-17 12:59   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/66 [^]
(0174311)
hgbot   
2025-01-17 12:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: b4b959c76d094457e1e02558415ae373ec8f6e6f
Author: Gorka Gil <go.gil@orisha.com>
Date: 08-01-2025 14:51:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/b4b959c76d094457e1e02558415ae373ec8f6e6f [^]

Related ISSUE-56501: Fix configuration of products in a combo wizard

---
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/ApplyCombo.js
---
(0174312)
hgbot   
2025-01-17 12:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 2baebcdf01caee2756bf7dc8204274960cf90217
Author: Gorka Gil <go.gil@orisha.com>
Date: 08-01-2025 14:51:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/2baebcdf01caee2756bf7dc8204274960cf90217 [^]

Related ISSUE-56501: fix the abort product configuration inside a combo wizard

---
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/AbortProductConfiguration.js
---
(0174313)
hgbot   
2025-01-17 12:59   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 10ec7bc9514c072e8ad33536b059fd9967946261
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 08-01-2025 15:55:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/10ec7bc9514c072e8ad33536b059fd9967946261 [^]

Related ISSUE-56501: Updated Copyright (c) Year 2025

---
M web-jspack/org.openbravo.retail.discounts.combo/src/components/ComboProductButtonQty/CombotProductButtonQty.jsx
M web-jspack/org.openbravo.retail.discounts.combo/src/components/__test__/ComboProductButtonQty.test.jsx
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/__test__/AddProductToCombo.test.js
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/AbortProductConfiguration.js
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/AddProductToCombo.js
M web-jspack/org.openbravo.retail.discounts.combo/src/model/user-interface/user-actions/ApplyCombo.js
---