Openbravo Issue Tracking System - POS2
View Issue Details
0056401POS2POSpublic2024-06-12 13:162024-09-09 07:38
nicolasuriz 
sreehari 
highmajoralways
closedfixed 
5
 
24Q2.324Q2.3 
No
0056401: The sales representative is being automatically added to a Verified Return when it should be empty.
The sales representative is being automatically added to a Verified Return when it should be empty.

By configuration at touchpoint type level:
1. Sales Representative mandatory = No
2. Sales Representative in New Orders = Keep it blank
3. Sales Representative in Local Drafts when switching user = Keep both header and lines Sales Representative
1. Login POS
2. Add a product to the ticket and check that the Sales representative is empty.
3. Fully pay/deliver and synchronize the ticket.
4. Open the previous ticket and do a Verified Return.
5. The Sales Representative is added to the ticket and orderline and it is displayed in the orderline level in the screen.
It should remain empty as it is in the sales orders case with this configuration.

And as it is logical, the sales representative normally is thought to the sales orders, not the returns, so if the original sales order has the field Sales representative empty, it should happen the same with the returns.
No tags attached.
blocks defect 0055749 closed sreehari The sales representative is being automatically added to a Verified Return when it should be empty. 
Issue History
2024-09-06 12:19marvintmTypedefect => backport
2024-09-06 12:19marvintmTarget Version => 24Q2.3
2024-09-07 12:15hgbotNote Added: 0168887
2024-09-07 12:16hgbotNote Added: 0168888
2024-09-09 07:37hgbotNote Added: 0168899
2024-09-09 07:37hgbotNote Added: 0168900
2024-09-09 07:38hgbotResolutionopen => fixed
2024-09-09 07:38hgbotStatusscheduled => closed
2024-09-09 07:38hgbotNote Added: 0168901
2024-09-09 07:38hgbotFixed in Version => 24Q2.3
2024-09-09 07:38hgbotNote Added: 0168902

Notes
(0168887)
hgbot   
2024-09-07 12:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1664 [^]
(0168888)
hgbot   
2024-09-07 12:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2908 [^]
(0168899)
hgbot   
2024-09-09 07:37   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1664 [^]
(0168900)
hgbot   
2024-09-09 07:37   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d55a85c982c7e7c8fdeef12721d4088a8af509a2
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 07-09-2024 15:42:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d55a85c982c7e7c8fdeef12721d4088a8af509a2 [^]

Related ISSUE-56401: Added null checks before setting salesRepresentative

---
M src/org/openbravo/retail/posterminal/utility/InvoiceUtils.java
M src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java
---
(0168901)
hgbot   
2024-09-09 07:38   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2908 [^]
(0168902)
hgbot   
2024-09-09 07:38   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 26c984d0da6abf0e273eec7908a9e857786f4392
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 09-09-2024 05:37:16
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/26c984d0da6abf0e273eec7908a9e857786f4392 [^]

Fixes ISSUE-56401: Removed salesRep from Ticket and Lines

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetDefaultSalesRepresentative.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/SetDefaultSalesRepresentative.test.js
---