Openbravo Issue Tracking System - POS2
View Issue Details
0056400POS2POSpublic2024-06-12 13:162024-09-09 07:36
nicolasuriz 
sreehari 
highmajoralways
closedfixed 
5
 
24Q3.124Q3.1 
No
0056400: The sales representative is being automatically added to a Verified Return when it should be empty.
The sales representative is being automatically added to a Verified Return when it should be empty.

By configuration at touchpoint type level:
1. Sales Representative mandatory = No
2. Sales Representative in New Orders = Keep it blank
3. Sales Representative in Local Drafts when switching user = Keep both header and lines Sales Representative
1. Login POS
2. Add a product to the ticket and check that the Sales representative is empty.
3. Fully pay/deliver and synchronize the ticket.
4. Open the previous ticket and do a Verified Return.
5. The Sales Representative is added to the ticket and orderline and it is displayed in the orderline level in the screen.
It should remain empty as it is in the sales orders case with this configuration.

And as it is logical, the sales representative normally is thought to the sales orders, not the returns, so if the original sales order has the field Sales representative empty, it should happen the same with the returns.
No tags attached.
blocks defect 0055749 closed sreehari The sales representative is being automatically added to a Verified Return when it should be empty. 
Issue History
2024-09-06 12:19marvintmTypedefect => backport
2024-09-06 12:19marvintmTarget Version => 24Q3.1
2024-09-07 10:01hgbotNote Added: 0168885
2024-09-07 10:02hgbotNote Added: 0168886
2024-09-09 07:36hgbotResolutionopen => fixed
2024-09-09 07:36hgbotStatusscheduled => closed
2024-09-09 07:36hgbotFixed in Version => 24Q3.1
2024-09-09 07:36hgbotNote Added: 0168895
2024-09-09 07:36hgbotNote Added: 0168896
2024-09-09 07:36hgbotNote Added: 0168897
2024-09-09 07:36hgbotNote Added: 0168898

Notes
(0168885)
hgbot   
2024-09-07 10:01   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2907 [^]
(0168886)
hgbot   
2024-09-07 10:02   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1663 [^]
(0168895)
hgbot   
2024-09-09 07:36   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: a0ec2c2e1f4e3a182ea4f6628d15d132ab4b3a42
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 07-09-2024 12:07:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/a0ec2c2e1f4e3a182ea4f6628d15d132ab4b3a42 [^]

Fixes ISSUE-56400: Removed salesRep from Ticket and Lines

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/SetDefaultSalesRepresentative.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/__test__/SetDefaultSalesRepresentative.test.js
---
(0168896)
hgbot   
2024-09-09 07:36   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2907 [^]
(0168897)
hgbot   
2024-09-09 07:36   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 98a22f71565ab2e02980f4695e8a0c0f93f78dac
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 07-09-2024 12:08:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/98a22f71565ab2e02980f4695e8a0c0f93f78dac [^]

Related ISSUE-56400: Added null checks before setting salesRepresentative

---
M src/org/openbravo/retail/posterminal/utility/InvoiceUtils.java
M src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java
---
(0168898)
hgbot   
2024-09-09 07:36   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1663 [^]