Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056393POS2POSpublic2024-09-06 08:482024-09-09 07:46
Reporterjorgewederago 
Assigned Tosreehari 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version24Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e90bcd8437481fb6f341e920574df7f56364e741 [^]
Triggers an Emergency PackNo
Summary0056393: It is not possible to send OTF coupon by email
DescriptionSince the fix related to https://issues.openbravo.com/view.php?id=55626 [^] was merged, anytime a Coupon is going to be sent an error is generated as import entry which ends in the Coupon not being sent
Steps To Reproduce1.- Have a configuration for send email
2.- Create a Coupon OTF Rule
3.- In POS do a transaction that will trigger the OTF Rule
4.- In the ticket delivery choose send by email
5.- See that the email is not received and there is an Import Entry related to the email in error
Proposed SolutionDuring the fix for that issue now is mandatory to have the "ticket" object, however this is not true when other things that are not ticket are being sent by email.

It is needed to add code to avoid this kind of scenarios

Take into account that the fix has been backported to other versions so it is needed to do the same
Additional Information
TagsNo tags attached.
Relationships
depends on backport 005639524Q3.1 closed sreehari It is not possible to send OTF coupon by email 
depends on backport 005639624Q2.3 closed sreehari It is not possible to send OTF coupon by email 
caused by defect 0055626 closed fofarril Incorrect report filename while sending documents by mail 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-09-06 08:48jorgewederagoNew Issue
2024-09-06 08:48jorgewederagoAssigned To => Retail
2024-09-06 08:48jorgewederagoRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/e90bcd8437481fb6f341e920574df7f56364e741 [^]
2024-09-06 08:48jorgewederagoTriggers an Emergency Pack => No
2024-09-06 08:49jorgewederagoRelationship addedcaused by 0055626
2024-09-06 08:49jorgewederagoProposed Solution updated
2024-09-06 10:40sreehariAssigned ToRetail => sreehari
2024-09-06 10:40sreehariStatusnew => scheduled
2024-09-06 11:37martinsdanIssue Monitored: martinsdan
2024-09-06 16:56hgbotNote Added: 0168877
2024-09-09 07:46hgbotNote Added: 0168903
2024-09-09 07:46hgbotResolutionopen => fixed
2024-09-09 07:46hgbotStatusscheduled => closed
2024-09-09 07:46hgbotFixed in Version => 24Q4
2024-09-09 07:46hgbotNote Added: 0168904

Notes
(0168877)
hgbot   
2024-09-06 16:56   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2906 [^]
(0168903)
hgbot   
2024-09-09 07:46   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2906 [^]
(0168904)
hgbot   
2024-09-09 07:46   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 4ffc040e611262aa4dab04091ebe9b0d8d01d29e
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 09-09-2024 05:46:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4ffc040e611262aa4dab04091ebe9b0d8d01d29e [^]

Fixes ISSUE-56393: Error in Send email in case other files than tickets were sent
Added case to check ticket available in param, now when param doesn't have ticket file is directly added

---
M src/org/openbravo/pos2/mailing/SendEmailLoader.java
---