Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056386POS2POSpublic2024-09-05 17:072024-11-26 11:13
Reporterhbrasme 
Assigned Toradhakrishnan 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version24Q3 
Target VersionFixed in Version 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056386: Contribution Module - No contribution recalculation after a line split or deletion
DescriptionWhen a product with contribution is splitted, the contribution line is not recalculate
Steps To ReproduceUse a contribution (Product subtype) defined like as follow :

Checkbox Linkable To Product selected
Checkbox Forced in returns selected
Price Calculation > By Product multiplicator
Quantity Rule > As per product
Allocation Type > mandatory

---------
This contribution is assigned to a product

----

Select product with quantity of 3

When the line is splitted the contribution line is not recalculate


----

When 2 of the previous lines are deleted, the contribution is not recalculated for the only line present.

The result shlould be a contribution (Gestion APE) with an 6.02 € like amount







Proposed Solution1. Include property 'preventSplit' at line level for the main product line when adding a contribution to the ticket
2. Modify the conditional to check for contributions similar to how ticket.hasServices is used in https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3065/diffs?file=02be15b3fb317b5ce80c75e279ae19fd221914ca#02be15b3fb317b5ce80c75e279ae19fd221914ca_41_49 [^]

I think solution 1 is the better option.
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0054941 closed sreehari Services out of sync with related line if line is split and the quantity are deleted 
depends on backport 005727724Q4.1 closed radhakrishnan Contribution Module - No contribution recalculation after a line split or deletion 
depends on backport 005727824Q3.3 closed radhakrishnan Contribution Module - No contribution recalculation after a line split or deletion 
Attached Filespng image-20240809-081015.png (106,021) 2024-09-05 17:07
https://issues.openbravo.com/file_download.php?file_id=20139&type=bug
png

png image-20240809-081356.png (41,817) 2024-09-05 17:08
https://issues.openbravo.com/file_download.php?file_id=20140&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-09-05 17:07hbrasmeNew Issue
2024-09-05 17:07hbrasmeAssigned To => Retail
2024-09-05 17:07hbrasmeFile Added: image-20240809-081015.png
2024-09-05 17:07hbrasmeTriggers an Emergency Pack => No
2024-09-05 17:08hbrasmeFile Added: image-20240809-081356.png
2024-10-09 16:40javietxeOBNetwork customer => Gold
2024-10-09 17:07aferrazAssigned ToRetail => Triage Omni OMS
2024-10-09 17:14javietxeIssue Monitored: javietxe
2024-10-14 10:38frank_gonzalezRelationship addeddepends on 0054941
2024-10-16 07:34jonaeAssigned ToTriage Omni OMS => kousalya_r
2024-10-16 07:34jonaeNote Added: 0170467
2024-10-28 13:49aferrazAssigned Tokousalya_r => frank_gonzalez
2024-11-20 11:49frank_gonzalezProposed Solution updated
2024-11-22 12:22aferrazAssigned Tofrank_gonzalez => radhakrishnan
2024-11-22 12:28hgbotMerge Request Status => open
2024-11-22 12:28hgbotNote Added: 0172471
2024-11-25 11:53hgbotMerge Request Statusopen => approved
2024-11-25 11:53hgbotResolutionopen => fixed
2024-11-25 11:53hgbotStatusnew => closed
2024-11-25 11:53hgbotFixed in Version => 25Q1
2024-11-25 11:53hgbotNote Added: 0172533
2024-11-25 11:53hgbotNote Added: 0172534
2024-11-25 12:53hgbotNote Added: 0172542
2024-11-25 14:19hgbotNote Added: 0172551
2024-11-25 14:35hgbotNote Added: 0172554
2024-11-26 06:38hgbotNote Added: 0172568
2024-11-26 10:43jonaeStatusclosed => new
2024-11-26 10:43jonaeResolutionfixed => open
2024-11-26 10:43jonaeFixed in Version25Q1 =>
2024-11-26 10:44jonaeStatusnew => scheduled
2024-11-26 10:45jonaeStatusscheduled => resolved
2024-11-26 10:45jonaeResolutionopen => fixed
2024-11-26 10:45jonaeStatusresolved => closed
2024-11-26 11:03hgbotNote Added: 0172592
2024-11-26 11:13hgbotNote Added: 0172595

Notes
(0170467)
jonae   
2024-10-16 07:34   
Jira: https://openbravo.atlassian.net/browse/RM-18514 [^]
(0172471)
hgbot   
2024-11-22 12:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3141 [^]
(0172533)
hgbot   
2024-11-25 11:53   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ea9346aec54244f9fc15c325aa57456c066ac892
Author: Radhakrishnan Seeman <r.seeman@external.orisha.com>
Date: 25-11-2024 10:53:29
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ea9346aec54244f9fc15c325aa57456c066ac892 [^]

Fixed ISSUE-56386: Blocked split action of a line

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/ContributionHooks.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/ContributionHooks.js
---
(0172534)
hgbot   
2024-11-25 11:53   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3141 [^]
(0172542)
hgbot   
2024-11-25 12:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3146 [^]
(0172551)
hgbot   
2024-11-25 14:19   
Repository: https://gitlab.com/openbravo/ci/context_definitions [^]
Changeset: 87c22ddf207efacee8aedb0f24c6072be9155a9c
Author: Radhakrishnan Seeman <radhakrishnan.seeman.ext@openbravo.com>
Date: 25-11-2024 18:49:23
URL: https://gitlab.com/openbravo/ci/context_definitions/-/commit/87c22ddf207efacee8aedb0f24c6072be9155a9c [^]

Related to ISSUE-56386: Added json to test issue 56386

---
A retail/pos2-modules-24Q4-srk.json
---
(0172554)
hgbot   
2024-11-25 14:35   
Repository: https://gitlab.com/openbravo/ci/context_definitions [^]
Changeset: c9fd6121cb9fbaf3d8bf2f77d93a24c1e70d5025
Author: Radhakrishnan Seeman <radhakrishnan.seeman.ext@openbravo.com>
Date: 25-11-2024 19:05:12
URL: https://gitlab.com/openbravo/ci/context_definitions/-/commit/c9fd6121cb9fbaf3d8bf2f77d93a24c1e70d5025 [^]

Related to ISSUE-56386: Removed pos2-modules-24Q4-srk json

---
R retail/pos2-modules-24Q4-srk.json
---
(0172568)
hgbot   
2024-11-26 06:38   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3153 [^]
(0172592)
hgbot   
2024-11-26 11:03   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3146 [^]
(0172595)
hgbot   
2024-11-26 11:13   
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/3153 [^]