Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056366POS2POSpublic2024-09-03 07:432024-10-14 07:51
Reportermigueldejuana 
Assigned Tosreehari 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version24Q2.3Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056366: External Orders API: Missing OrderID (external id) when doing COMMIT action
DescriptionWhen doing COMMIT action we send only the id generated when creating the order in POS2, we should send also the OrderID provided by the External System when loading the Order.
Steps To Reproduce- Configure External Orders with ExternalOrdersSimulator
- Load any of the orders
- Process or Delete the order
- Check in the console the COMMIT message sent, the IrderID is missing
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0056344 closed migueldejuana External Orders API: Missing OrderID (external id) when doing COMMIT action 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-09-04 15:53migueldejuanaTypedefect => backport
2024-09-04 15:53migueldejuanaTarget Version => 24Q2.3
2024-09-06 17:51hgbotNote Added: 0168882
2024-09-16 10:19hgbotResolutionopen => fixed
2024-09-16 10:19hgbotStatusscheduled => closed
2024-09-16 10:19hgbotNote Added: 0169223
2024-09-16 10:19hgbotNote Added: 0169224
2024-10-10 19:09sreehariAssigned Tomigueldejuana => sreehari
2024-10-10 19:09sreehariNote Added: 0170272
2024-10-10 19:09sreehariStatusclosed => new
2024-10-10 19:09sreehariResolutionfixed => open
2024-10-10 19:10sreehariStatusnew => scheduled
2024-10-10 19:19hgbotNote Added: 0170274
2024-10-14 07:51hgbotNote Added: 0170318
2024-10-14 07:51hgbotResolutionopen => fixed
2024-10-14 07:51hgbotStatusscheduled => closed
2024-10-14 07:51hgbotNote Added: 0170319

Notes
(0168882)
hgbot   
2024-09-06 17:51   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/9 [^]
(0169223)
hgbot   
2024-09-16 10:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders [^]
Changeset: 23dfcb814f50b9573ebd2600172464c396010307
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 05-09-2024 23:14:13
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/commit/23dfcb814f50b9573ebd2600172464c396010307 [^]

Fixes ISSUE-56366: External Orders API: Missing OrderID (external id) when doing COMMIT action

---
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/CommitExternalOrderActionPreparation.js
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/RollbackExternalOrderCommitment.js
M web/org.openbravo.events.orders/app/model/business-object/simulator/ExternalOrdersSimulator.js
---
(0169224)
hgbot   
2024-09-16 10:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/9 [^]
(0170272)
sreehari   
2024-10-10 19:09   
Missed a commit to backport
(0170274)
hgbot   
2024-10-10 19:19   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/21 [^]
(0170318)
hgbot   
2024-10-14 07:51   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/21 [^]
(0170319)
hgbot   
2024-10-14 07:51   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders [^]
Changeset: 75eec98c6825361c95391c068d654799a6ecc2c7
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 10-10-2024 22:42:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/commit/75eec98c6825361c95391c068d654799a6ecc2c7 [^]

Fixes ISSUE-56366: Ensure that test verify new orderID parameter

---
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/CommitExternalOrderActionPreparation.js
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/RollbackExternalOrderCommitment.js
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/__test__/CommitExternalOrderActionPreparation.test.js
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/__test__/RollbackExternalOrderCommitment.test.js
---