Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056365POS2POSpublic2024-09-03 07:432024-10-14 07:50
Reportermigueldejuana 
Assigned Tosreehari 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version24Q3.1Fixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056365: External Orders API: Missing OrderID (external id) when doing COMMIT action
DescriptionWhen doing COMMIT action we send only the id generated when creating the order in POS2, we should send also the OrderID provided by the External System when loading the Order.
Steps To Reproduce- Configure External Orders with ExternalOrdersSimulator
- Load any of the orders
- Process or Delete the order
- Check in the console the COMMIT message sent, the IrderID is missing
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
blocks defect 0056344 closed migueldejuana External Orders API: Missing OrderID (external id) when doing COMMIT action 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-09-04 15:53migueldejuanaTypedefect => backport
2024-09-04 15:53migueldejuanaTarget Version => 24Q3.1
2024-09-06 17:52hgbotNote Added: 0168883
2024-09-16 10:18hgbotResolutionopen => fixed
2024-09-16 10:18hgbotStatusscheduled => closed
2024-09-16 10:18hgbotNote Added: 0169221
2024-09-16 10:18hgbotNote Added: 0169222
2024-10-10 19:09sreehariAssigned Tomigueldejuana => sreehari
2024-10-10 19:09sreehariNote Added: 0170271
2024-10-10 19:09sreehariStatusclosed => new
2024-10-10 19:09sreehariResolutionfixed => open
2024-10-10 19:10sreehariStatusnew => scheduled
2024-10-10 19:18hgbotNote Added: 0170273
2024-10-14 07:50hgbotResolutionopen => fixed
2024-10-14 07:50hgbotStatusscheduled => closed
2024-10-14 07:50hgbotNote Added: 0170316
2024-10-14 07:50hgbotNote Added: 0170317

Notes
(0168883)
hgbot   
2024-09-06 17:52   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/10 [^]
(0169221)
hgbot   
2024-09-16 10:18   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders [^]
Changeset: a84523fcaa4ba575582bd5859fa52dfd839964b3
Author: Sreehari Venkataraman <s.venkataraman@external.orisha.com>
Date: 05-09-2024 20:40:45
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/commit/a84523fcaa4ba575582bd5859fa52dfd839964b3 [^]

Fixes ISSUE-56365: External Orders API: Missing OrderID (external id) when doing COMMIT action

---
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/CommitExternalOrderActionPreparation.js
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/RollbackExternalOrderCommitment.js
M web/org.openbravo.events.orders/app/model/business-object/simulator/ExternalOrdersSimulator.js
---
(0169222)
hgbot   
2024-09-16 10:18   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/10 [^]
(0170271)
sreehari   
2024-10-10 19:09   
Missed a commit to backport
(0170273)
hgbot   
2024-10-10 19:18   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/20 [^]
(0170316)
hgbot   
2024-10-14 07:50   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders [^]
Changeset: d6303d880718705e655d7c9b47ae8c03ab892656
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 10-10-2024 22:46:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/commit/d6303d880718705e655d7c9b47ae8c03ab892656 [^]

Fixes ISSUE-56365: Ensure that test verify new orderID parameter

---
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/CommitExternalOrderActionPreparation.js
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/RollbackExternalOrderCommitment.js
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/__test__/CommitExternalOrderActionPreparation.test.js
M web-jspack/org.openbravo.events.orders/src/model/ticket/actions/__test__/RollbackExternalOrderCommitment.test.js
---
(0170317)
hgbot   
2024-10-14 07:50   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.orders/-/merge_requests/20 [^]