Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056330POS2POSpublic2024-08-30 11:442024-09-19 20:22
Reportercberner 
Assigned Tocberner 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056330: Customer data collection keyboard incorrect behaviour if tapping in SCO
DescriptionIn SCO, when entering the customer data collection screen, the virtual keyboard has an incorrect behaviour. When pressing keys, then switching to the next field, it will use the last key pressed from the previous field.

It also has some inconsistencies with focus and also when trying to change the caret/position in the input.
Steps To ReproduceCheck the JIRA for the full steps to reproduce: https://openbravo.atlassian.net/browse/RM-16552 [^]

In summary:
1. Enable Substitutive Invoice Configuration, and also fiscalization event payment provider
2. Go to SCO and do a sale, completing the payment
3. When prompted "Do you want an invoice?", select OK
4. Click on several keys of the keyboard
5. Click on next button, and then on any key, see that the value set is from the previous keyboard key

An informative video was published here: https://vimeo.com/1002678679/bca06d45bc [^]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0056585main acknowledged eugen_hamuraru Retail Modules Incorrect behaviour in the customer data collection keyboard for the Request String component 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-08-30 11:44cbernerNew Issue
2024-08-30 11:44cbernerAssigned To => Retail
2024-08-30 11:44cbernerTriggers an Emergency Pack => No
2024-08-30 11:44cbernerAssigned ToRetail => cberner
2024-08-30 11:44cbernerStatusnew => scheduled
2024-08-30 11:46hgbotNote Added: 0168585
2024-09-04 11:17midwifetroopNote Added: 0168721
2024-09-10 10:25shuehnerNote Deleted: 0168721
2024-09-17 17:46hgbotNote Added: 0169294
2024-09-19 17:49hgbotNote Added: 0169400
2024-09-19 17:49hgbotNote Added: 0169401
2024-09-19 20:22hgbotNote Added: 0169402
2024-09-19 20:22hgbotResolutionopen => fixed
2024-09-19 20:22hgbotStatusscheduled => closed
2024-09-19 20:22hgbotNote Added: 0169403
2024-09-30 12:12ignacio_deandresRelationship addedrelated to 0056585

Notes
(0168585)
hgbot   
2024-08-30 11:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/merge_requests/76 [^]
(0169294)
hgbot   
2024-09-17 17:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1596 [^]
(0169400)
hgbot   
2024-09-19 17:49   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: def449c84281cf98922c2abc728f3a5e5f1910b2
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 19-09-2024 15:48:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/def449c84281cf98922c2abc728f3a5e5f1910b2 [^]

Related to ISSUE-56330: Update simple-keyboard to version 3.8.0 to fix caret issue in chromium

Caret was jumping at the end second key press, and it seems it was a
regression introduced by chromium last updates. A fix was done in
version 3.8.0 of the simple-keyboard library.

---
M web-jspack/org.openbravo.core2/package-lock.json
M web-jspack/org.openbravo.core2/package.json
---
(0169401)
hgbot   
2024-09-19 17:49   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1596 [^]
(0169402)
hgbot   
2024-09-19 20:22   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/merge_requests/76 [^]
(0169403)
hgbot   
2024-09-19 20:22   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.selfcheckout [^]
Changeset: 1856d5cf71668aca064441d87f3faf96250c075b
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 16-09-2024 13:23:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.selfcheckout/-/commit/1856d5cf71668aca064441d87f3faf96250c075b [^]

Fixes ISSUE-56330: Customer data collection keyboard incorrect behaviour if tapping in SCO

The keyboard was failing to clear its state between one input and
another when dealing with multiple-inputs in RequestStringSCO.

To deal with this, the state is properly cleared between one input and
another, both when changing to the next or previous one with the next
and previous buttons on the keyboards and also when clicking on the
other inputs.

Additionally, the way input is updated when a keyboard key was pressed
was changed, previously it always tried to add the last letter in the
state(assuming the focus on the keyboard is always the last key, which
is not always true). Now it uses the proper keyboard key pressed on its
corresponding position, because the cursor can be set to different
positions, not only the end of the input.

---
M web-jspack/org.openbravo.pos2.selfcheckout/src/components/RequestStringSCO/RequestStringSCO.jsx
---