Openbravo Issue Tracking System - POS2
View Issue Details
0056288POS2Corepublic2024-08-21 16:042024-11-20 19:30
dorian_robillard 
Bimla_vm 
normalminoralways
closedfixed 
5
 
 
No
0056288: In BO, quantity field is not filled for manual promotion in Sales oder/line/ discount and promotion
We have an error on the BO when we apply a manual promotion. On the window “sales order” / “line” / “discount and promotion” we can see the promotion with all information but not the quantity. (see attachment)

When we apply an automatic promotion we have the quantity

We need the quantity here for all the promotions.

Step to reproduce :

On the POS :

select a product on the receipt

click en the line / Discount

select a % discount and apply

pay the receipt

On the BO :

Go to the sale order, check the window “line” / “discount and promotion”
A manual promotion always affect to all units of the line so quantity should be always the quantity of the line.

Same behavior of fixed discount in an automatic discount
In live builds
Create an order adding 3 units of "Bivu bag gore-tex"
Automatic discount is applied
Complete sale

In backoffice -> order -> lines -> discount you will see that quantity is 3.

Same should happen for manual discounts


Additional task to the fix:

Complete ad_element of quantity field with a proper help and description
No tags attached.
png 9f73152d-4e90-4038-ada1-64e04b6a4d95.png (73,485) 2024-08-21 16:04
https://issues.openbravo.com/file_download.php?file_id=20104&type=bug
png
Issue History
2024-08-21 16:04dorian_robillardNew Issue
2024-08-21 16:04dorian_robillardAssigned To => Triage Platform Base
2024-08-21 16:04dorian_robillardFile Added: 9f73152d-4e90-4038-ada1-64e04b6a4d95.png
2024-08-21 16:04dorian_robillardTriggers an Emergency Pack => No
2024-10-31 13:43victor_perezAssigned ToTriage Platform Base => Triage Omni OMS
2024-10-31 16:36aferrazAssigned ToTriage Omni OMS => Retail
2024-11-04 17:24guilleaerAssigned ToRetail => guilleaer
2024-11-04 17:24guilleaerStatusnew => acknowledged
2024-11-05 05:57Bimla_vmAssigned Toguilleaer => Bimla_vm
2024-11-05 05:57Bimla_vmStatusacknowledged => scheduled
2024-11-19 11:41guilleaerProposed Solution updated
2024-11-19 11:42guilleaerProposed Solution updated
2024-11-20 08:13hgbotNote Added: 0172264
2024-11-20 19:30hgbotResolutionopen => fixed
2024-11-20 19:30hgbotStatusscheduled => closed
2024-11-20 19:30hgbotFixed in Version => RR25Q1
2024-11-20 19:30hgbotNote Added: 0172370
2024-11-20 19:30hgbotNote Added: 0172371

Notes
(0172264)
hgbot   
2024-11-20 08:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/157 [^]
(0172370)
hgbot   
2024-11-20 19:30   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: ce382bc1ba6eaf5c90873a8bb9847653f702fe35
Author: Bimla V Mayavan <b.mayavan@external.orisha.com>
Date: 20-11-2024 18:30:27
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/ce382bc1ba6eaf5c90873a8bb9847653f702fe35 [^]

Fixed ISSUE-56288: Quantity for manual promotion discounts is based on the quantity of the line
- This happens because the manual discounts always apply to all items of the line

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-amount-promotions-discount.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/manual-percentage-promotions-discount.js
---
(0172371)
hgbot   
2024-11-20 19:30   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/157 [^]