Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056270POS2POSpublic2024-08-17 09:512024-08-19 11:15
Reportersreehari 
Assigned Tosreehari 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression levelPre packaging ( pi )
Regression date2024-08-16
Regression introduced in releasepi
Regression introduced by commithttps://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2732/diffs#d3700544a6538284c53af61d2572f89af485c63c_35_47 [^]
Triggers an Emergency PackNo
Summary0056270: The Sales Representation saved as null in shipment and invoice lines throws FK exception
DescriptionWhen completing a order with more than 1 line the Sales Representative for the lines are set as null as per the regression commit.

Which then causes the FK exception in m_inoutline & c_invoiceline for Salesrep_ID=null

Steps To Reproduce1.Complete a order with more than 1 lines
2.Error while importing is created
Proposed SolutionAdd null checks before setting the salesRep in m_inoutline & c_invoiceline
- since when we have no sales rep in general we wont be setting the sales rep and still the column value is null
- since we set the salesRep_id value to be null it is set as "null" which throws exception with Foreign Key mismatch
Additional Information
TagsNo tags attached.
Relationships
caused by defect 0055749 closed sreehari The sales representative is being automatically added to a Verified Return when it should be empty. 
Attached Filespng Screenshot 2024-08-17 at 1.21.16 PM.png (297,114) 2024-08-17 09:51
https://issues.openbravo.com/file_download.php?file_id=20096&type=bug
Issue History
Date ModifiedUsernameFieldChange
2024-08-17 09:51sreehariNew Issue
2024-08-17 09:51sreehariAssigned To => sreehari
2024-08-17 09:51sreehariFile Added: Screenshot 2024-08-17 at 1.21.16 PM.png
2024-08-17 09:51sreehariRegression level => Pre packaging ( pi )
2024-08-17 09:51sreehariRegression date => 2024-08-16
2024-08-17 09:51sreehariRegression introduced in release => pi
2024-08-17 09:51sreehariRegression introduced by commit => https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2732/diffs#d3700544a6538284c53af61d2572f89af485c63c_35_47 [^]
2024-08-17 09:51sreehariTriggers an Emergency Pack => No
2024-08-17 09:52sreehariRelationship addedcaused by 0055749
2024-08-17 09:52sreehariStatusnew => scheduled
2024-08-19 10:54hgbotNote Added: 0168207
2024-08-19 11:15hgbotResolutionopen => fixed
2024-08-19 11:15hgbotStatusscheduled => closed
2024-08-19 11:15hgbotFixed in Version => RR24Q4
2024-08-19 11:15hgbotNote Added: 0168208
2024-08-19 11:15hgbotNote Added: 0168209

Notes
(0168207)
hgbot   
2024-08-19 10:54   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1650 [^]
(0168208)
hgbot   
2024-08-19 11:15   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 058b916136baef7adde9662beeed1896dd4b95ef
Author: Sreehari Venkataraman <sreehari.venkataraman.ext@openbravo.com>
Date: 17-08-2024 13:23:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/058b916136baef7adde9662beeed1896dd4b95ef [^]

Fixes ISSUE-56270: Added null checks before setting salesRepresentative

---
M src/org/openbravo/retail/posterminal/utility/InvoiceUtils.java
M src/org/openbravo/retail/posterminal/utility/ShipmentUtils.java
---
(0168209)
hgbot   
2024-08-19 11:15   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1650 [^]