Openbravo Issue Tracking System - Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056207ModulesOpenbravo Business APIpublic2024-08-07 16:022024-09-20 07:52
Reporterwicherr 
Assigned Toalostale 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toadrianromero
Support ticket
OBNetwork customer
Regression introduced in release
Summary0056207: Pricelist API : The product price active flag is not updated
DescriptionWhen you populate the pricelist via API,
You create product prices with the flag isactive = true

If you try to update the price later on to remove the product from the terminal for instance pushing the flag at false, the flag is not updated.
Steps To Reproducecreate a price through the Pricelist API

push the same body with the Active flag of the product price at "false"

The flag stays at true instead of changing to false.

this flag in
"productPrices": [
   {
      "product": "1002370298",
      "unitPrice": "16.990",
      "listPrice": "16.990",
      "priceLimit": "9999.99",
      "cost": "0",
      "printPriceForTemplates": "UnitPrice",
      "printPriceForWebPos": "UnitPrice",
      "active": false
    }
]
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0055222 closed alostale Retail Modules Price API - importing price for deactivated product 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2024-08-07 16:02wicherrNew Issue
2024-08-07 16:02wicherrAssigned To => Triage Platform Conn
2024-08-08 13:38adrianromeroReview Assigned To => adrianromero
2024-08-08 13:38adrianromeroNote Added: 0167861
2024-08-08 13:38adrianromeroStatusnew => closed
2024-08-08 13:38adrianromeroResolutionopen => no change required
2024-09-09 11:39alostaleStatusclosed => new
2024-09-09 11:39alostaleResolutionno change required => open
2024-09-09 11:41alostaleNote Added: 0168924
2024-09-09 11:46hgbotNote Added: 0168933
2024-09-09 11:59adrianromeroAssigned ToTriage Platform Conn => alostale
2024-09-12 11:36alostaleRelationship addedrelated to 0055222
2024-09-20 07:52hgbotResolutionopen => fixed
2024-09-20 07:52hgbotStatusnew => closed
2024-09-20 07:52hgbotNote Added: 0169411
2024-09-20 07:52hgbotNote Added: 0169412

Notes
(0167861)
adrianromero   
2024-08-08 13:38   
This is the expected behaviour of the Openbravo API. It only queries active records for GET requests and it only updates active records for POST requests.
(0168924)
alostale   
2024-09-09 11:41   
The current behavior regarding whether it is possible or not to update entities from the PriceList import end point is:


PriceList - Yes

PriveListVersion - No -> missing active property in the mapping

ProductPrice - Yes
(0168933)
hgbot   
2024-09-09 11:46   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/328 [^]
(0169411)
hgbot   
2024-09-20 07:52   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^]
Changeset: cf9de2947c689bf3f62be71b2b8153d6a20ba468
Author: Asier Lostalé <a.lostale@orisha.com>
Date: 20-09-2024 05:52:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/cf9de2947c689bf3f62be71b2b8153d6a20ba468 [^]

fixes BUG-56207: can't deactivate price list version through API

Using PriceList import endpoint is was not possible to activate or deactivate
price list versions. It was possible though to activate/deactivate price lists
and product prices.

Adding missing active property to the API so it can be updated. It's been added
both to the export and import end points.

---
M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml
---
(0169412)
hgbot   
2024-09-20 07:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/328 [^]