Openbravo Issue Tracking System - POS2
View Issue Details
0056130POS2POSpublic2024-07-30 11:502024-08-14 09:57
agusti_gallego 
ranjith_qualiantech_com 
normalminoralways
closedfixed 
5
 
 
No
0056130: A eslint directive is disabled and not re-enabled.
In the file CreateTicketFromQuotation from the retail.posterminal module, there are two eslint-directives that disable the rule no-restricted-syntax (https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateTicketFromQuotation.js#L53 [^]). These directives do not have a corresponding line re-enabling them, so the rule gets disabled in the whole content. Therefore, in the POS2.js file that gets generated, this directive is ignored.
This has become an issue because SSMS does not load the retail.posterminal react code and, therefore, the build shows an error related to eslint in code from the events.client module: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/blob/master/web/org.openbravo.events.client/source/events/eventsflow.js#L276. [^]
In a local workspace, go to the POS2.js file that gets generated when building the app, find the two problematic eslint directives, and remove them. The eslint will show an error in the events.client code.
Fix the file in the posterminal module so that it re-enables the eslint directive properly, and then include the disable directive in the events.client file to avoid having errors in the builds.
No tags attached.
Issue History
2024-07-30 11:50agusti_gallegoNew Issue
2024-07-30 11:50agusti_gallegoAssigned To => Retail
2024-07-30 11:50agusti_gallegoTriggers an Emergency Pack => No
2024-07-30 12:22guilleaerStatusnew => scheduled
2024-07-30 12:22guilleaerAssigned ToRetail => ranjith_qualiantech_com
2024-07-31 09:55adrianromeroAssigned Toranjith_qualiantech_com => adrianromero
2024-07-31 09:56adrianromeroNote Added: 0167520
2024-07-31 11:22adrianromeroAssigned Toadrianromero => ranjith_qualiantech_com
2024-07-31 11:23adrianromeroNote Added: 0167522
2024-07-31 11:28hgbotNote Added: 0167523
2024-07-31 11:28hgbotNote Added: 0167524
2024-07-31 11:28hgbotNote Added: 0167525
2024-07-31 11:28hgbotNote Added: 0167526
2024-08-02 11:10hgbotNote Added: 0167649
2024-08-02 11:10hgbotNote Added: 0167650
2024-08-02 11:11hgbotNote Added: 0167651
2024-08-02 11:11hgbotNote Added: 0167652
2024-08-02 11:11hgbotNote Added: 0167653
2024-08-02 11:11hgbotNote Added: 0167654
2024-08-14 09:57hgbotResolutionopen => fixed
2024-08-14 09:57hgbotStatusscheduled => closed
2024-08-14 09:57hgbotFixed in Version => RR24Q4
2024-08-14 09:57hgbotNote Added: 0168077
2024-08-14 09:57hgbotNote Added: 0168078

Notes
(0167520)
adrianromero   
2024-07-31 09:56   
This is an issue in org.openbravo.events.client. We take it
(0167522)
adrianromero   
2024-07-31 11:23   
Returning the issue after clarified with Agustí. It looks like that it requires coordinated changes in several files to properly adjust all eslint directives
(0167523)
hgbot   
2024-07-31 11:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1636 [^]
(0167524)
hgbot   
2024-07-31 11:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/merge_requests/37 [^]
(0167525)
hgbot   
2024-07-31 11:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment/-/merge_requests/37 [^]
(0167526)
hgbot   
2024-07-31 11:28   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/77 [^]
(0167649)
hgbot   
2024-08-02 11:10   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider [^]
Changeset: 409680ba77311b2c15645a0996258089f142ae23
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 31-07-2024 11:23:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/commit/409680ba77311b2c15645a0996258089f142ae23 [^]

Related to ISSUE-56130: Added ESLint directive for for-of loop

---
M web/org.openbravo.retail.asyncpayprovider/source/utils/managemessages.js
M web/org.openbravo.retail.asyncpayprovider/source/utils/modelvalue.js
---
(0167650)
hgbot   
2024-08-02 11:10   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.asyncpayprovider/-/merge_requests/37 [^]
(0167651)
hgbot   
2024-08-02 11:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client [^]
Changeset: 808de72759f2dac5e7d9bdd561fa3bdace04b5fd
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 31-07-2024 11:23:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/commit/808de72759f2dac5e7d9bdd561fa3bdace04b5fd [^]

Related to ISSUE-56130: Added ESLint directive for for-of loop

---
M web/org.openbravo.events.client/source/events/eventsflow.js
---
(0167652)
hgbot   
2024-08-02 11:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/merge_requests/77 [^]
(0167653)
hgbot   
2024-08-02 11:11   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment/-/merge_requests/37 [^]
(0167654)
hgbot   
2024-08-02 11:11   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment [^]
Changeset: 79d531b59310028f4052028ef378184d312dddeb
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 31-07-2024 11:28:24
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.payment/-/commit/79d531b59310028f4052028ef378184d312dddeb [^]

Related to ISSUE-56130: Added ESLint directive for for-of loop

---
M web/org.openbravo.events.payment/source/actionpreparation/actionPreparation.js
M web/org.openbravo.events.payment/source/model/paymentLogin.js
---
(0168077)
hgbot   
2024-08-14 09:57   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 7d80910cc5640e7cfc03f42cd968a499faa17a9b
Author: Ranjith S R <ranjith.rangaraju.ext@openbravo.com>
Date: 14-08-2024 07:57:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/7d80910cc5640e7cfc03f42cd968a499faa17a9b [^]

Fixed ISSUE-56130: Added ESLint directive for for-of loop

---
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateTicketFromQuotation.js
---
(0168078)
hgbot   
2024-08-14 09:57   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1636 [^]