Openbravo Issue Tracking System - POS2 |
| View Issue Details |
|
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0056130 | POS2 | POS | public | 2024-07-30 11:50 | 2024-08-14 09:57 |
|
| Reporter | agusti_gallego | |
| Assigned To | ranjith_qualiantech_com | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | | OS | 5 | OS Version | |
| Product Version | | |
| Target Version | | Fixed in Version | | |
| Merge Request Status | |
| Review Assigned To | |
| OBNetwork customer | |
| Support ticket | |
| Regression level | |
| Regression date | |
| Regression introduced in release | |
| Regression introduced by commit | |
| Triggers an Emergency Pack | No |
|
| Summary | 0056130: A eslint directive is disabled and not re-enabled. |
| Description | In the file CreateTicketFromQuotation from the retail.posterminal module, there are two eslint-directives that disable the rule no-restricted-syntax (https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/blob/master/web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/CreateTicketFromQuotation.js#L53 [^]). These directives do not have a corresponding line re-enabling them, so the rule gets disabled in the whole content. Therefore, in the POS2.js file that gets generated, this directive is ignored.
This has become an issue because SSMS does not load the retail.posterminal react code and, therefore, the build shows an error related to eslint in code from the events.client module: https://gitlab.com/openbravo/product/pmods/org.openbravo.events.client/-/blob/master/web/org.openbravo.events.client/source/events/eventsflow.js#L276. [^] |
| Steps To Reproduce | In a local workspace, go to the POS2.js file that gets generated when building the app, find the two problematic eslint directives, and remove them. The eslint will show an error in the events.client code. |
| Proposed Solution | Fix the file in the posterminal module so that it re-enables the eslint directive properly, and then include the disable directive in the events.client file to avoid having errors in the builds.
|
| Additional Information | |
| Tags | No tags attached. |
| Relationships | |
| Attached Files | |
|
| Issue History |
| Date Modified | Username | Field | Change |
| 2024-07-30 11:50 | agusti_gallego | New Issue | |
| 2024-07-30 11:50 | agusti_gallego | Assigned To | => Retail |
| 2024-07-30 11:50 | agusti_gallego | Triggers an Emergency Pack | => No |
| 2024-07-30 12:22 | guilleaer | Status | new => scheduled |
| 2024-07-30 12:22 | guilleaer | Assigned To | Retail => ranjith_qualiantech_com |
| 2024-07-31 09:55 | adrianromero | Assigned To | ranjith_qualiantech_com => adrianromero |
| 2024-07-31 09:56 | adrianromero | Note Added: 0167520 | |
| 2024-07-31 11:22 | adrianromero | Assigned To | adrianromero => ranjith_qualiantech_com |
| 2024-07-31 11:23 | adrianromero | Note Added: 0167522 | |
| 2024-07-31 11:28 | hgbot | Note Added: 0167523 | |
| 2024-07-31 11:28 | hgbot | Note Added: 0167524 | |
| 2024-07-31 11:28 | hgbot | Note Added: 0167525 | |
| 2024-07-31 11:28 | hgbot | Note Added: 0167526 | |
| 2024-08-02 11:10 | hgbot | Note Added: 0167649 | |
| 2024-08-02 11:10 | hgbot | Note Added: 0167650 | |
| 2024-08-02 11:11 | hgbot | Note Added: 0167651 | |
| 2024-08-02 11:11 | hgbot | Note Added: 0167652 | |
| 2024-08-02 11:11 | hgbot | Note Added: 0167653 | |
| 2024-08-02 11:11 | hgbot | Note Added: 0167654 | |
| 2024-08-14 09:57 | hgbot | Resolution | open => fixed |
| 2024-08-14 09:57 | hgbot | Status | scheduled => closed |
| 2024-08-14 09:57 | hgbot | Fixed in Version | => RR24Q4 |
| 2024-08-14 09:57 | hgbot | Note Added: 0168077 | |
| 2024-08-14 09:57 | hgbot | Note Added: 0168078 | |
|
Notes |
|
|
|
|
This is an issue in org.openbravo.events.client. We take it |
|
|
|
|
|
Returning the issue after clarified with AgustÃ. It looks like that it requires coordinated changes in several files to properly adjust all eslint directives |
|
|
|
(0167523)
|
|
hgbot
|
|
2024-07-31 11:28
|
|
|
|
|
(0167524)
|
|
hgbot
|
|
2024-07-31 11:28
|
|
|
|
|
(0167525)
|
|
hgbot
|
|
2024-07-31 11:28
|
|
|
|
|
(0167526)
|
|
hgbot
|
|
2024-07-31 11:28
|
|
|
|
|
(0167649)
|
|
hgbot
|
|
2024-08-02 11:10
|
|
|
|
|
(0167650)
|
|
hgbot
|
|
2024-08-02 11:10
|
|
|
|
|
(0167651)
|
|
hgbot
|
|
2024-08-02 11:11
|
|
|
|
|
(0167652)
|
|
hgbot
|
|
2024-08-02 11:11
|
|
|
|
|
(0167653)
|
|
hgbot
|
|
2024-08-02 11:11
|
|
|
|
|
(0167654)
|
|
hgbot
|
|
2024-08-02 11:11
|
|
|
|
|
(0168077)
|
|
hgbot
|
|
2024-08-14 09:57
|
|
|
|
|
(0168078)
|
|
hgbot
|
|
2024-08-14 09:57
|
|
|