Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0056101Retail ModulesRetail APIpublic2024-07-24 10:032024-08-13 12:41
Reporterkchoperena 
Assigned ToAtulOpenbravo 
PriorityhighSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0056101: In the DistributionOrder integration, lineNo is documented as number the code is expecting a string
DescriptionIn the DistributionOrder integration, lineNo is documented as number the code is expecting a string
Steps To ReproduceTry to integrate a distribution order:
[
  {
    "organization": "España",
    "documentNo": "1000128",
    "warehouseIssue": "RN",
    "warehouseReceipt": "RS",
    "description": null,
    "lines": [
      {
        "uOM": "Unit",
        "lineNo": 1,
        "product": "ISNegativeSalesTest0001",
        "operativeQuantity": 1,
        "qtyIssued": 0,
        "qtyReceived": 0,
        "qtyConfirmed": 1
      }
    ],
    "IsAutomaticallyIssueStock": true,
    "isOverrideDOWarehouseConf": true,
    "orderReference": null,
    "client": "AWO-QA",
    "isIssue": true,
    "orderDate": "2024-07-22",
    "scheduledDeliveryDate": "2024-07-22",
    "documentAction": "Confirm"
  }
]

Error:
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Filespng Screenshot from 2024-07-24 10-03-30.png (106,165) 2024-07-24 10:03
https://issues.openbravo.com/file_download.php?file_id=20034&type=bug
png

png Screenshot from 2024-07-24 10-04-29.png (92,631) 2024-07-24 10:04
https://issues.openbravo.com/file_download.php?file_id=20035&type=bug
png
Issue History
Date ModifiedUsernameFieldChange
2024-07-24 10:03kchoperenaNew Issue
2024-07-24 10:03kchoperenaAssigned To => Triage Omni OMS
2024-07-24 10:03kchoperenaFile Added: Screenshot from 2024-07-24 10-03-30.png
2024-07-24 10:03kchoperenaTriggers an Emergency Pack => No
2024-07-24 10:04kchoperenaFile Added: Screenshot from 2024-07-24 10-04-29.png
2024-07-24 19:00aferrazAssigned ToTriage Omni OMS => Triage Omni WMS
2024-07-24 23:25mtaalAssigned ToTriage Omni WMS => AtulOpenbravo
2024-08-08 09:13hgbotNote Added: 0167828
2024-08-08 09:21AtulOpenbravoNote Added: 0167829
2024-08-08 11:21AtulOpenbravoStatusnew => scheduled
2024-08-12 16:00hgbotResolutionopen => fixed
2024-08-12 16:00hgbotStatusscheduled => closed
2024-08-12 16:00hgbotNote Added: 0167988
2024-08-12 16:00hgbotNote Added: 0167989
2024-08-13 12:41hgbotNote Added: 0168028

Notes
(0167828)
hgbot   
2024-08-08 09:13   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/merge_requests/32 [^]
(0167829)
AtulOpenbravo   
2024-08-08 09:21   
- Make sure AWO-QAAdmin role has Web Services Enabled flag true.
- Login as AWOQAAdmin user
- Using swagger tool >>

http://localhost:8080/openbravo/api?urls.primaryName=Business%20API%20-%20Transactional%20Data#/DistributionOrder/Import_DistributionOrder [^]

- try to import below json

[
  {
    "organization": "España",
    "documentNo": "1000128",
    "warehouseIssue": "RN",
    "warehouseReceipt": "RS",
    "description": null,
    "lines": [
      {
        "uOM": "Unit",
        "lineNo": 1,
        "product": "ISNegativeSalesTest0001",
        "operativeQuantity": 1,
        "qtyIssued": 0,
        "qtyReceived": 0,
        "qtyConfirmed": 1
      }
    ],
    "IsAutomaticallyIssueStock": true,
    "isOverrideDOWarehouseConf": true,
    "orderReference": null,
    "client": "AWO-QA",
    "isIssue": true,
    "orderDate": "2024-08-08",
    "scheduledDeliveryDate": "2024-08-08",
    "documentAction": "Confirm"
  }
]

Realize that DO is imported successfully.
(0167988)
hgbot   
2024-08-12 16:00   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api [^]
Changeset: 753c6deb5c1aa3c5a63ac746f2716c6d2b397d9a
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 08-08-2024 12:39:28
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/commit/753c6deb5c1aa3c5a63ac746f2716c6d2b397d9a [^]

Fixed BUG-0056101: In the DistributionOrder integration, lineNo is
documented as number the code is expecting a string

**Cast Line No property value as Integer instead of String when
importing DO using API's

---
M src/org/openbravo/distributionorder/api/hook/distributionorderline/ImportDOLineBaseOBObjectFetcher.java
M src/org/openbravo/distributionorder/api/mappings/distributionorderline/ImportDOLineJavaPropertyMappingHandler.java
---
(0167989)
hgbot   
2024-08-12 16:00   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.distributionorder.api/-/merge_requests/32 [^]
(0168028)
hgbot   
2024-08-13 12:41   
Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests [^]
Changeset: 9ecdb72bb63ba4d9e31dabb7a6ae18d85b638d3e
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 13-08-2024 16:09:47
URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.api.tests/-/commit/9ecdb72bb63ba4d9e31dabb7a6ae18d85b638d3e [^]

Related to BUG-0056101: fix ci failures

**lineNo should be numeric instead of String

---
M src-test/data/importer/DistributionOrderAutoIssueUpdate.json
M src-test/data/importer/DistributionOrderIssueUpdate.json
M src-test/data/importer/DistributionOrderIssueUpdateWithDecimalQtys.json
M src-test/data/importer/DistributionOrderReceiptUpdate.json
M src-test/data/importer/DistributionOrderReceiptUpdateWithDecimalQtys.json
---